rneovim.git/test/functional/lua/ui_spec.lua, branch rahm

feat(vim.ui.open): support lemonade #30845

2024-10-18T09:22:15+00:00

test(vim.ui.open): opt.cmd

2024-09-16T09:58:04+00:00

fix(vim.ui)!: change open() to return `result|nil, errmsg|nil` #28612

2024-05-03T10:20:03+00:00

reverts e0d92b9cc20b58179599f53dfa74ca821935a539 #28502

Problem:
`vim.ui.open()` has a `pcall()` like signature, under the assumption
that this is the Lua idiom for returning result-or-error. However, the
`result|nil, errmsg|nil` pattern:
- has precedent in:
  - `io.open`
  - `vim.uv` (`:help luv-error-handling`)
- has these advantages:
  - Can be used with `assert()`:
    ```
    local result, err = assert(foobar())
    ```
  - Allows LuaLS to infer the type of `result`:
    ```
    local result, err = foobar()
    if err then
      ...
    elseif result then
      ...
    end
    ```

Solution:
- Revert to the `result|nil, errmsg|nil` pattern.
- Document the pattern in our guidelines.

fix(vim.ui)!: change open() to return pcall-like values #28502

2024-04-25T11:15:58+00:00

Problem:
`vim.ui.open` unnecessarily invents a different success/failure
convention. Its return type was changed in 57adf8c6e01d, so we might as
well change it to have a more conventional form.

Solution:
Change the signature to use the `pcall` convention of `status, result`.

test: improve test conventions

2024-04-23T16:17:04+00:00

Specifically, functions that are run in the context of the test runner
are put in module `test/testutil.lua` while the functions that are run
in the context of the test session are put in
`test/functional/testnvim.lua`.

Closes https://github.com/neovim/neovim/issues/27004.

fix(vim.ui.open): try wslview before explorer.exe #28424

2024-04-20T12:47:08+00:00

Problem:
explorer.exe is unreliable on WSL.

Solution:
Try wslview before explorer.exe.

fix #28410

fix(vim.ui): open() may wait indefinitely #28325

2024-04-15T11:33:09+00:00

Problem:
vim.ui.open "locks up" Nvim if the spawned process does not terminate. #27986

Solution:
- Change `vim.ui.open()`:
    - Do not call `wait()`.
    - Return a `SystemObj`. The caller can decide if it wants to `wait()`.
- Change `gx` to `wait()` only a short time.
    - Allows `gx` to show a message if the command fails, without the
      risk of waiting forever.

refactor(test): inject after_each differently

2024-04-10T14:53:50+00:00

test: improve test conventions

2024-04-08T20:51:00+00:00

Work on https://github.com/neovim/neovim/issues/27004.

fix(vim.ui.open): use explorer.exe instead of wslview #26947

2024-02-20T17:14:50+00:00

Problem:
`vim.ui.open` uses `wslview`, which is slow and require a package from external PPA:
https://wslutiliti.es/wslu/install.html#ubuntu

Solution:
Use `explorer.exe` instead. WSL supports it by default:
https://learn.microsoft.com/en-us/windows/wsl/filesystems#view-your-current-directory-in-windows-file-explorer