1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
|
{-# LANGUAGE ConstraintKinds #-}
{-# LANGUAGE DeriveAnyClass #-}
{-# LANGUAGE FlexibleContexts #-}
{-# LANGUAGE IncoherentInstances #-}
{-# LANGUAGE TypeOperators #-}
{-# LANGUAGE UndecidableInstances #-}
module Language.Fiddle.Compiler.ConsistencyCheck (checkConsistency) where
import Control.Monad (forM, forM_, unless, when)
import Control.Monad.Identity (Identity (Identity))
import Control.Monad.RWS (MonadState (get, put), MonadWriter (tell), gets, modify')
import Data.Foldable (Foldable (toList), foldlM)
import Data.Functor.Identity
import qualified Data.IntMap as IntMap
import Data.Kind (Type)
import Data.List (inits, intercalate)
import Data.List.NonEmpty (NonEmpty (..))
import qualified Data.List.NonEmpty as NonEmpty
import Data.Map (Map)
import qualified Data.Map as Map
import Data.Maybe (fromMaybe)
import qualified Data.Set as Set
import qualified Data.Text as Text
import Data.Word (Word32)
import Language.Fiddle.Ast
import Language.Fiddle.Compiler
import Language.Fiddle.Internal.Scopes
import Language.Fiddle.Types (Commented (unCommented), SourceSpan)
import Text.Printf (printf)
import Prelude hiding (unzip)
newtype GlobalState = GlobalState
{ globalScope :: Scope String (Either SizeBits SizeBytes)
}
newtype LocalState = LocalState (ScopePath String)
type I = Identity
type Annot = Commented SourceSpan
type SizeBits = Word32
type SizeBytes = Word32
checkConsistency ::
FiddleUnit Expanded I Annot ->
Compile () (FiddleUnit Checked I Annot)
checkConsistency =
fmap snd
. subCompile (GlobalState mempty)
. advanceStage (LocalState mempty)
instance CompilationStage Expanded where
type StageAfter Expanded = Checked
type StageMonad Expanded = Compile GlobalState
type StageState Expanded = LocalState
type StageFunctor Expanded = Identity
type StageAnnotation Expanded = Commented SourceSpan
deriving instance AdvanceStage Expanded FiddleUnit
deriving instance AdvanceStage Expanded Expression
deriving instance AdvanceStage Expanded ObjType
deriving instance AdvanceStage Expanded DeferredRegisterBody
deriving instance AdvanceStage Expanded RegisterBitsDecl
deriving instance AdvanceStage Expanded RegisterBitsTypeRef
deriving instance AdvanceStage Expanded AnonymousBitsType
deriving instance AdvanceStage Expanded BitType
deriving instance AdvanceStage Expanded EnumBody
deriving instance AdvanceStage Expanded EnumConstantDecl
deriving instance AdvanceStage Expanded PackageBody
deriving instance (AdvanceStage Expanded t) => AdvanceStage Expanded (Directed t)
instance AdvanceStage Expanded RegisterBody where
advanceStage s body = fst <$> registerBodyToStage3 s body
instance AdvanceStage Expanded ObjTypeBody where
advanceStage s body = fst <$> objTypeBodyToStage3 s body 0
instance AdvanceStage Expanded FiddleDecl where
modifyState t s = case t of
(BitsDecl id typ a) -> do
typeSize <- getTypeSize typ
insertTypeSize s id typeSize
return s
(PackageDecl n _ _) -> do
let strs = nameToList n
let (LocalState scopePath) = s
return $
LocalState $
scopePath {currentScope = strs ++ currentScope scopePath}
(UsingDecl n _) ->
let (LocalState scopePath) = s
in return $
LocalState $
scopePath
{ usingPaths = nameToList n : usingPaths scopePath
}
_ -> return s
nameToList :: Name f a -> [String]
nameToList (Name idents _) = map (\(Identifier (Text.unpack -> s) _) -> s) (toList idents)
objTypeBodyToStage3 ::
LocalState ->
ObjTypeBody Expanded I Annot ->
Word32 ->
Compile GlobalState (ObjTypeBody Checked I Annot, Word32)
objTypeBodyToStage3 st (ObjTypeBody bodyType decls a) startOff = do
let isUnion = case bodyType of
Union {} -> True
_ -> False
(cur, returned) <-
foldlM
( \(cursor, returned) decl ->
case undirected decl of
RegisterDecl mMod mIdent expr mBody a -> do
(s3RegisterBody, mCalculatedSize) <-
fUnzip <$> mapM (registerBodyToStage3 st) mBody
nExpr <- advanceStage st expr
let s3 =
mapDirected
( const $
RegisterDecl
mMod
mIdent
nExpr
s3RegisterBody
a
)
decl
declaredSizeBits <- fromIntegral <$> exprToSize expr
when ((declaredSizeBits `mod` 8) /= 0) $
tell
[ Diagnostic
Error
"Register size is not a multiple of 8. Please pad register size to align with 8. "
(unCommented a)
]
forM_ mCalculatedSize $ \(fromIntegral -> calculatedSize) ->
unless (calculatedSize == declaredSizeBits) $
let helpful =
if calculatedSize < declaredSizeBits
then
printf
"\nPerhaps you should add 'reserved(%d)' to the end of your register declaration?"
(declaredSizeBits - calculatedSize)
else ""
in tell
[ Diagnostic
Error
( printf
"Calculated size %d does not match declared size %d.%s"
calculatedSize
declaredSizeBits
helpful
)
(unCommented a)
]
if isUnion
then
checkUnion cursor (declaredSizeBits `div` 8) (s3 : returned) a
else
return (cursor + declaredSizeBits `div` 8, s3 : returned)
TypeSubStructure (Identity subBody) maybeIdent annot -> do
(newBody, size) <-
objTypeBodyToStage3
st
subBody
( if isUnion then startOff else cursor
)
let s3 = mapDirected (const $ TypeSubStructure (Identity newBody) maybeIdent annot) decl
checkTypesSubStructure subBody maybeIdent annot
if isUnion
then
checkUnion cursor size (s3 : returned) a
else
return (cursor + size, s3 : returned)
ReservedDecl expr annot -> do
size' <- fromIntegral <$> exprToSize expr
when ((size' `mod` 8) /= 0) $
tell
[ Diagnostic
Error
"Can only reserve a multiple of 8 bits in this context."
(unCommented a)
]
expr' <- advanceStage st expr
let size = size' `div` 8
let s3 = mapDirected (const $ ReservedDecl expr' annot) decl
if isUnion
then
checkUnion cursor size (s3 : returned) a
else
return (cursor + size, s3 : returned)
AssertPosStatement _ expr a -> do
declaredPos <- fromIntegral <$> exprToSize expr
let expectedPos = if isUnion then startOff else cursor + startOff
when (expectedPos /= declaredPos) $ do
tell
[ Diagnostic
Error
( printf
"Position assertion failed. Asserted 0x%x, calculated 0x%x"
declaredPos
expectedPos
)
(unCommented a)
]
return (cursor, returned)
)
(0, [])
decls
return (ObjTypeBody bodyType (reverse returned) a, cur)
where
checkTypesSubStructure
(ObjTypeBody bodyType decls _)
maybeIdent
annot =
let emitWarning s = tell [Diagnostic Warning s (unCommented annot)]
in case () of
()
| [_] <- decls,
(Union {}) <- bodyType ->
emitWarning "Union with a single field. Should this be a struct?"
()
| [_] <- decls,
(Struct {}) <- bodyType,
Nothing <- maybeIdent ->
emitWarning "Anonymous sub-struct with single field is superfluous."
()
| [] <- decls ->
emitWarning
( printf
"Empty sub-%s is superfluous."
( case bodyType of
Union {} -> "union"
Struct {} -> "struct"
)
)
_ -> return ()
fUnzip xs = (fst <$> xs, snd <$> xs)
pushApply :: Maybe (a, b) -> (Maybe a, Maybe b)
pushApply (Just (a, b)) = (Just a, Just b)
pushApply Nothing = (Nothing, Nothing)
registerBodyToStage3 ::
LocalState ->
RegisterBody Expanded I Annot ->
Compile GlobalState (RegisterBody Checked I Annot, Word32)
registerBodyToStage3
st
(RegisterBody bodyType (Identity deferredRegisterBody) a') = do
let isUnion = case bodyType of
Union {} -> True
_ -> False
case deferredRegisterBody of
DeferredRegisterBody decls a -> do
(cur, returned) <-
foldlM
( \(cursor, returned) decl ->
case undirected decl of
ReservedBits expr a -> do
size <- fromIntegral <$> exprToSize expr
expr' <- advanceStage st expr
let s3 =
mapDirected
(const $ ReservedBits expr' a)
decl
if isUnion
then checkUnion cursor size (s3 : returned) a
else
return (cursor + size, s3 : returned)
BitsSubStructure registerBody maybeIdent annot -> do
checkBitsSubStructure registerBody maybeIdent annot
(newBody, subsize) <- registerBodyToStage3 st registerBody
let s3 =
mapDirected
(const $ BitsSubStructure newBody maybeIdent annot)
decl
if isUnion
then checkUnion cursor subsize (s3 : returned) a
else
return (cursor + subsize, s3 : returned)
DefinedBits modifier identifier typeref a -> do
(s3TypeRef, size) <- registerBitsTypeRefToStage3 st typeref
let s3 =
mapDirected
(const $ DefinedBits modifier identifier s3TypeRef a)
decl
if isUnion
then checkUnion cursor size (s3 : returned) a
else
return (cursor + size, s3 : returned)
)
(0, [])
decls
return
( RegisterBody
bodyType
(Identity (DeferredRegisterBody (reverse returned) a))
a',
cur
)
where
checkBitsSubStructure
(RegisterBody bodyType (Identity (DeferredRegisterBody decls _)) _)
maybeIdent
annot =
let emitWarning s = tell [Diagnostic Warning s (unCommented annot)]
in case () of
()
| [_] <- decls,
(Union {}) <- bodyType ->
emitWarning "Union with a single field. Should this be a struct?"
()
| [_] <- decls,
(Struct {}) <- bodyType,
Nothing <- maybeIdent ->
emitWarning "Anonymous sub-struct with single field is superfluous."
()
| [] <- decls ->
emitWarning
( printf
"Empty sub-%s is superfluous."
( case bodyType of
Union {} -> "union"
Struct {} -> "struct"
)
)
_ -> return ()
registerBitsTypeRefToStage3 ::
LocalState ->
RegisterBitsTypeRef Expanded I Annot ->
Compile GlobalState (RegisterBitsTypeRef Checked I Annot, Word32)
registerBitsTypeRefToStage3 localState = \case
RegisterBitsArray ref expr a -> do
(ref', size) <- registerBitsTypeRefToStage3 localState ref
multiplier <- exprToSize expr
expr' <- advanceStage localState expr
return
( RegisterBitsArray ref' expr' a,
size * fromIntegral multiplier
)
RegisterBitsReference name a ->
(RegisterBitsReference name a,) <$> lookupTypeSize localState name
RegisterBitsJustBits expr a -> do
expr' <- advanceStage localState expr
(RegisterBitsJustBits expr' a,)
. fromIntegral
<$> exprToSize expr
checkUnion :: Word32 -> Word32 -> b -> Commented SourceSpan -> Compile s (Word32, b)
checkUnion cursor subsize ret a = do
when (cursor /= 0 && subsize /= cursor) $ do
tell
[ Diagnostic
Warning
( printf
"Jagged union found. Found size %d, expected %d.\n \
\ Please wrap smaller fields in a struct with padding so all \
\ fields are the same size?"
subsize
cursor
)
(unCommented a)
]
return (max cursor subsize, ret)
exprToSize ::
(NumberType stage ~ Integer) =>
Expression stage I Annot ->
Compile s Integer
exprToSize (LitNum num _) = return num
exprToSize e = do
tell [Diagnostic Error "Variables not allowed" (unCommented $ annot e)]
compilationFailure
lookupTypeSize :: LocalState -> Name I Annot -> Compile GlobalState SizeBits
lookupTypeSize (LocalState scopePath) (Name idents a) = do
-- Convert the list of identifiers to a string path
let path = fmap (\(Identifier s _) -> Text.unpack s) idents
-- Get the current scope and perform the lookup
results <- gets $ lookupScopeWithPath scopePath path . globalScope
case results of
-- Successfully resolved to a unique size
[(_, Right sz)] -> return sz
-- Multiple ambiguous results found
matches@(_ : _) -> do
-- Generate a list of ambiguous paths for error reporting
let ambiguousPaths =
map
( \(resolvedPath, _) ->
intercalate "." (NonEmpty.toList resolvedPath)
)
matches
tell
[ Diagnostic
Error
( printf
"Ambiguous occurrence of '%s'. Multiple matches found:\n%s"
(intercalate "." $ NonEmpty.toList path)
(unlines ambiguousPaths) -- List all ambiguous paths
)
(unCommented a)
]
compilationFailure
-- No matches found
_ -> do
tell
[ Diagnostic
Error
( printf
"Cannot resolve '%s'. No matching symbols found."
(intercalate "." $ NonEmpty.toList path)
)
(unCommented a)
]
compilationFailure
getTypeSize :: BitType Expanded I Annot -> Compile s SizeBits
getTypeSize (RawBits expr _) = fromIntegral <$> exprToSize expr
getTypeSize (EnumBitType expr (Identity (EnumBody constants _)) ann) = do
declaredSize <- fromIntegral <$> exprToSize expr
-- If the declared size is less than or equal to 4, we'll enforce that the
-- enum is packed. This is to make sure the user has covered all bases.
when (declaredSize <= 4) $ do
imap <-
foldlM
( \imap (undirected -> enumConst) -> do
number <- case enumConst of
EnumConstantDecl _ expr _ -> exprToSize expr
EnumConstantReserved expr _ -> exprToSize expr
when (number >= 2 ^ declaredSize) $
tell
[ Diagnostic
Error
( printf
"Enum constant too large. Max allowed %d\n"
((2 :: Int) ^ declaredSize)
)
(unCommented (annot enumConst))
]
return $ IntMap.insert (fromIntegral number) True imap
)
IntMap.empty
constants
let missing =
filter (not . (`IntMap.member` imap)) [0 .. 2 ^ declaredSize - 1]
unless (null missing) $
tell
[ Diagnostic
Warning
( printf
"Missing enum constants %s. Small enums should be fully \
\ populated. Use 'reserved' if needed."
(intercalate ", " (map show missing))
)
(unCommented ann)
]
return declaredSize
diagnosticError :: String -> Annot -> Compile a ()
diagnosticError str a = tell [Diagnostic Error str (unCommented a)]
insertTypeSize ::
LocalState ->
Identifier f Annot ->
SizeBits ->
Compile GlobalState ()
insertTypeSize (LocalState scopePath) (Identifier s annot) size = do
modifyM $
\(GlobalState globalScope) ->
let fullName =
NonEmpty.prependList
(currentScope scopePath)
(NonEmpty.singleton (Text.unpack s))
in case upsertScope fullName (Right size) globalScope of
(Just _, _) -> do
diagnosticError (printf "Duplicate type %s" s) annot
compilationFailure
(Nothing, n) -> return $ GlobalState n
where
modifyM fn = do
s <- get
put =<< fn s
|