aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Fix missing glyphs crash on WindowsChristian Duerr2020-12-29
| | | Fixes #4617.
* Draw cursor with rect rendererKirill Chibisov2020-12-28
| | | | | | | | This commit makes cursors being drawn via rects, thus it's always above underlines/strikeouts. Also, since the cursor isn't a glyph anymore, it can't be obscured due to atlas switching while glyphs are rendered. Fixes #4404. Fixes #3471.
* Hide "missing" glyp for zerowidth characterKirill Chibisov2020-12-23
| | | | | | | | | | | This patch prevents missing zerowidth glyphs from obscuring the rendered glyph of a cell. The missing glyph itself is also consistently loaded and displayed on all platforms. It is initialized once together with the ascii symbols and then written to the atlas only once for every cached missing glyph. Co-authored-by: Christian Duerr <contact@christianduerr.com>
* Disable shadows for transparent windows on macOSChristian Duerr2020-12-22
| | | | | | | | | | | | Commit 5725f58 introduced a performance regression on macOS due to excessive calls to the `invalidateShadow` function, however calling this function only on redraw after a resize was performed does not fix the underlying problem. As a solution, window shadows are now disabled completely for all transparent windows. This makes sure there is no performance impact, while still solving the problem with text artifacts on resize. Fixes #4604.
* Remove terminfo dependencyCaden Haustein2020-12-22
| | | | | Fixes #4597. Co-authored-by: Christian Duerr <contact@christianduerr.com>
* Fix artifacts on macOS with transparent windowsChristian Duerr2020-12-21
| | | | | | | | | | | Due to the way macOS draws shadows for transparent windows, resizing them will lead to text artifacts remaining present after a window has been resized. The `invalidateShadow` call is used whenever the opacity isn't `1.0` to make sure these shadows are cleared before redrawing, so no artifacts remain when resizing transparent windows. Fixes #889.
* Replace serde's derive with custom proc macroChristian Duerr2020-12-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This replaces the existing `Deserialize` derive from serde with a `ConfigDeserialize` derive. The goal of this new proc macro is to allow a more error-friendly deserialization for the Alacritty configuration file without having to manage a lot of boilerplate code inside the configuration modules. The first part of the derive macro is for struct deserialization. This takes structs which have `Default` implemented and will only replace fields which can be successfully deserialized. Otherwise the `log` crate is used for printing errors. Since this deserialization takes the default value from the struct instead of the value, it removes the necessity for creating new types just to implement `Default` on them for deserialization. Additionally, the struct deserialization also checks for `Option` values and makes sure that explicitly specifying `none` as text literal is allowed for all options. The other part of the derive macro is responsible for deserializing enums. While only enums with Unit variants are supported, it will automatically implement a deserializer for these enums which accepts any form of capitalization. Since this custom derive prevents us from using serde's attributes on fields, some of the attributes have been reimplemented for `ConfigDeserialize`. These include `#[config(flatten)]`, `#[config(skip)]` and `#[config(alias = "alias)]`. The flatten attribute is currently limited to at most one per struct. Additionally the `#[config(deprecated = "optional message")]` attribute allows easily defining uniform deprecation messages for fields on structs.
* Fix embedded _NET_WM_ICON on X11Christian Duerr2020-12-20
| | | | | | | | | | Previously the _NET_WM_ICON would use the .ico which was also used for the Windows icon. This icon used the dimensions 256x256, but the maximum supported image size is 192x192, so a new image with the dimensions 64x64 has been added. Since we know the image format anyways, the `image` dependency could also be easily replaced with `png`, which cuts out a few extra unused dependencies.
* Add search history supportChristian Duerr2020-12-20
| | | | | | | | | | | | This adds a history to the regex search limited to at most 255 entries. Whenever a search is either confirmed or cancelled, the last regex is entered into the history and can be accessed when a new search is started. This should help users recover complicated search regexes after accidentally discarding them, or handle repeated searches with the same regexes. Fixes #4095.
* Add separate mode for search bindingsChristian Duerr2020-12-19
|
* Fix crash due to clipboard not being properly released on WaylandKirill Chibisov2020-12-17
|
* Fix invalid ESC escape sequence parsingChristian Duerr2020-12-17
| | | | | | | | | This strictens the ESC escape sequence parser to prevent invalid intermediates from being ignored. Previously the parser would just look at the first intermediate without validating that the rest of them is empty. If an escape like `\e(#0` is used now, it will no longer be accepted as `\e(0` since the intermediate `#` is also present.
* Increase file watcher delay on BSDChristian Duerr2020-12-17
| | | | | | | | | | | Since BSD does not support inotify polling in the `notify` crate and instead relies on manual filesystem polling, this would cause a high CPU usage at 100 polls a second. A separate polling rate of once per second is now used for platforms which do not support filesystem polling, allowing users to still make use of live config reload on BSD. Fixes #3871.
* Fix draining of PTY when holding on exitChristian Duerr2020-12-17
| | | Fixes #4189.
* Fix typo in .editorconfigRay Hong2020-12-14
|
* Fix live reload with broken yaml on startChristian Duerr2020-12-14
| | | | | | | | | | | | | Since the current behavior would just load the default configuration file whenever the configuration file couldn't be loaded, the path was not set to any value. As a result however, the live config reload feature would not work with a broken yaml (one which cannot be deserialized, not one with warnings). If a configuration file has been specified, but the deserialization still failed, the path is now preserved on the default configuration file to make it possible to live reload a fix for the issue. Fixes #4561.
* Fix cursor reports with mouse outside of windowChristian Duerr2020-12-13
| | | | | | | | | | | Previously Alacritty would not report cursor escapes to the application when a mouse button was held down and the mouse was moved. This prevents applications like tmux from updating their selection. Similarly to how windowing libraries keep reporting mouse events when the left mouse button is held down over the window, the escape sequences are now clamped to within the grid and reported to applications. Fixes #4566.
* Bump glutin to 0.26.0Kirill Chibisov2020-12-11
| | | | | Fixes #4530. Fixes #4072. Fixes #1927.
* Remove live-shader-reload featureKirill Chibisov2020-12-10
| | | | | Since live-shader-reload is generally unused and unmaintained, and could only be used for debugging purposes, since it refers relative paths, this feature was removed for the sake of simplicity.
* Print multiline logs in one write callKirill Chibisov2020-12-10
| | | | Fixes potential split of multiline logs in the multithreaded context by writing them all at once.
* Render underline and strikeout rects in batchesIvan Avdeev2020-12-10
| | | | | | | | | | | | | | | Currently Alacritty requires a separate `draw` call to OpenGL whenever a new rectangle is rendered to the screen. With many rectangles visible, this has a significant impact on rendering performance. Instead of using separate draw calls, the new `RectRenderer` will build a batch of rectangles for rendering. This makes sure that multiple rectangles can be grouped together for single draw calls allowing a reduced impact on rendering time. Since this change is OpenGL 2 friendly, it should not make it more complicated to transition away from the 3.3+ requirements like an alternative instancing based implementation might have.
* Fix scrolling region performance with fixed linesChristian Duerr2020-12-10
| | | | | | | | | | | | | | | | | | | | This resolves an issue with Alacritty's scrolling region performance when there's a number of fixed lines at the top of the screen. This affects commonly used applications like tmux or vim. Instead of using separate logic for when the scrolling region starts at the top of the screen without any fixed lines, the code should now try to figure out the target position of these fixed lines ahead of time, swap them into place and still perform the optimized implementation to move the grid. This comes with the small trade-off that since lines are swapped before rotating the screen without clearing or removing any lines during the rotation process, that the places the fixed lines have been swapped with will appear out of order when using scrolling regions in the primary screen buffer. Since the use of scrolling regions primarily affects the alternate screen and most terminals don't keep any history at all, this should however not cause any problems.
* Remove alacritty.specChristian Duerr2020-12-08
| | | | Since Alacritty is now officially packaged by Fedora, it is no longer necessary to provide this in the official repository.
* Fix dimming of indexed colorsChristian Duerr2020-12-05
| | | | | | | | | | It seems like the list of colors might have changed a bit, leading to indexed colors not being transformed into their dim colors correctly. To prevent this from happening in the future, the dimming for colors in the range '0..=7' is now performed by offsetting them from the 'NamedColor::DimBlack'. Since this is the first dimmed color, this should always work as long as all dimmed colors are added in the correct order.
* Draw selection below Vi cursor when it's hiddenKirill Chibisov2020-11-28
|
* Fix DoS caused by excessive CSI parameter valuesChristian Duerr2020-11-26
|
* Remove redundant CLI flagsChristian Duerr2020-11-26
| | | | | | | | | | | | | This removes some of Alacritty's CLI flags since the same functionality is provided by the '--option' flag now. The removed flags are: * '--persistent-logging' * '--live-config-reload' * '--no-live-config-reload' * '--dimensions' * '--position' Fixes #4246.
* Fix CI upload assets tag matchingChristian Duerr2020-11-25
| | | | | | | | | The previous version would search for the last tag by matching the beginning of the tag name. By explicitly searching for the trailing `"` with grep, an exact tag match is now enforced. Since releases like v1.2.3 always match the beginning of their RCs (v1.2.3-rc4), this makes sure that the assets aren't pushed to the previous release.
* Fixed typo in INSTALL.mdEverlastinggit2020-11-24
|
* Remove copr from installation instructionsEverlastinggit2020-11-24
| | | | Since Fedora now provides Alacritty in the default repository, that should be used instead of the copr repository.
* Fix Cargo.lockKirill Chibisov2020-11-24
| | | During 07cfe8b the regenerated Cargo.lock file was somehow missed.
* Fix CHANGELOG sectionsKirill Chibisov2020-11-24
| | | | Commit 2fd2db4 added one more 'Added' section during rebase, thus merging it with existing one.
* Add blinking cursor supportDettorer2020-11-23
| | | | | | | | This adds support for blinking the terminal cursor. This can be controlled either using the configuration file, or using escape sequences. The supported control sequences for changing the blinking state are `CSI Ps SP q` and private mode 12.
* Add support for '~/' in config importsChristian Duerr2020-11-24
| | | | | | | | | | | This allows the configuration file imports to start with '~/' and resolve relative to the user's home directory. There is no support for '~user/' or '$HOME/' or any other shell expansion. However since paths relative to the home directory should be sufficient for everything, this provides a very simple solution without any significant drawbacks. Fixes #4157.
* Increase font size in CSDs on WaylandKirill Chibisov2020-11-22
| | | | | Winit changed the default font size for CSDs from 17pt to 11pt, this patch reverts that since it is too small to be readable.
* Fix stdout log message orderKirill Chibisov2020-11-19
| | | | | | | | | This patch makes sure that the message for the creation of a log file is always the first entry, before any other log file messages. Since we initialize our log file dynamically, the message is printed as soon as something is written to it. By making sure that we always write to a file first and then try stdout, we can ensure that the log file is always initialized before ever writing log messages to stdout.
* Ignore nonexistent config imports instead of raising an errorJames Simpson2020-11-19
| | | Fixes: #4330.
* Fix vi mode terminal resetChristian Duerr2020-11-19
| | | | | | | Since the vi mode is unrelated to the terminal emulation itself, it should not be reset during a `reset` to prevent unnecessary confusion. This also prevents the search from switching from vi mode to vi-less search without any indication to the user.
* Fix wide characters being cut offKirill Chibisov2020-11-17
| | | Fixes #791.
* Reduce number of GitHub Actions CI buildsChristian Duerr2020-11-17
| | | | | | By reducing the number of CI jobs for GitHub actions, it should be possible to get a faster overview over the status of all CI jobs. While this does increase the total build time of GitHub Actions by reducing parallelization, it should still finish within the SourceHut CI times.
* Add Alpine Linux build dependenciesChandler Swift2020-11-16
|
* Bump development version to 0.7.0-devChristian Duerr2020-11-15
| | | | This is only an update to the development version and does not represent a stable release.
* Fix unused import warningChristian Duerr2020-11-15
| | | This fixes an unused import warning introduced with 198d3cb.
* Fix zerowidth characters in the last columnKirill Chibisov2020-11-15
| | | | | | | | | This commit fixes the issue that when attempting to write zerowidth characters into the last column, it is written in the second to last column instead. Fixes #4227. Co-authored-by: Christian Duerr <contact@christianduerr.com>
* Load only gl 3.3 functionsKirill Chibisov2020-11-14
| | | | | | | | This commit makes 'gl::load_with' only load symbols from the minimal OpenGL (3.3) version alacritty aims to support. Doing so reduces the size of gl_bindings.rs from 21K LoC to 11K LoC, and also the actual loading by up to ~2x, thugh the loading is usually sub millisecond anyway.
* Feature gate 'image' when building without x11 featureKirill Chibisov2020-11-14
| | | | On Wayland there's no way to embed icon into the window, thus there's no point in loading it when x11 feature is disabled.
* Fix github releases tag patternChristian Duerr2020-11-14
|
* Update vte to 0.9.0Christian Duerr2020-11-13
|
* Add ability to select text during searchChristian Duerr2020-11-13
| | | | | | | | | | | | | This removes the restriction of not being able to select text while the search is active, making it a bit less jarring of a UX when the user tries to interact with the terminal during search. Since the selection was used during vi-less search to highlight the focused match, there is now an option for a focused match color, which uses the inverted normal match color by default. This focused match is used for both search modes. Other mouse interactions are now also possible during search, like opening URLs or clicking inside of mouse mode applications.
* Fix use after free when dropping zerowidth dataKirill Chibisov2020-11-13
| | | | | | | | | | | | Commit ec42b42ce601808070462111c0c28edb0e89babb added an optional pointer for each cell, thus some old code that was optimizing copying with 'ptr::copy' was duplicating "unique" pointers ('Box'), which was resulting in use after free, after attempting to free both of these pointers. By replacing these unsafe blocks with safe Rust, the issue itself is fixed and the potential for future memory problems is eliminated from this area of the code.