From f0cb1e7cf329f2672fe1335208c9a78562d8ab73 Mon Sep 17 00:00:00 2001 From: Christian Duerr Date: Sun, 19 Jul 2020 14:14:31 +0000 Subject: Bump alacritty_terminal version This change bumps the version of the `alacritty_terminal` crate to force it out of sync with the Alacritty application. Since it is a library that will be published on crates.io, it should be following semver rather than our binary's release version. While it would be possible to just keep it at 0.5.0, explicitly disconnecting it from the Alacritty version should give it a clean starting-off point and prevent unnecessary confusion. Bumping it to 0.10.0 instead of something like 0.6.0 should allow for a nice gap between the different versions without being too arbitrary. Changing the version to 0.1.0 is not an option since decreasing semver version would likely cause a lot of problems. While it would be possible to further separate the Alacritty terminal library from the Alacritty terminal emulator, by renaming it from `alacritty_terminal` to something different, I don't think that is necessary or a good idea at the moment. Even though the `alacritty_terminal` library *can* be used for other terminals, its primary goal is still to support the Alacritty terminal emulator and I don't see that changing. So making that clear in its name seems like a good idea. Since there is no plan to maintain this library separately from Alacritty, but to keep both tied together, the naming should reflect this. --- .github/pull_request_template.md | 3 +++ 1 file changed, 3 insertions(+) (limited to '.github') diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 802ca57a..9dc048b0 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -4,6 +4,9 @@ Please make sure to document all user-facing changes in the If support for a new escape sequence was added, it should be documented in `./docs/escape_support.md`. +Since `alacritty_terminal`'s version always tracks the next release, make sure +that the version is bumped according to semver when necessary. + Draft PRs are always welcome, though unless otherwise requested PRs will not be reviewed until all required and optional CI steps are successful and they have left the draft stage. -- cgit