From 2a676dfad837d1784ed0911d314bc263804ef4ef Mon Sep 17 00:00:00 2001 From: Chris Copeland Date: Fri, 15 Jul 2022 14:56:26 -0700 Subject: Fix thin strokes on macOS Remove the `font.use_thin_strokes` config, which only did anything on macOS and only prior to Big Sur. Instead, we will enable or disable "font smoothing" on macOS based on the `AppleFontSmoothing` user default. These changes let users get the "thin strokes" behavior by setting `AppleFontSmoothing` to 0 with: ```sh $ defaults write -g AppleFontSmoothing -int 0 ``` (Or replace `-g` with `org.alacritty` to apply this setting only to Alacritty.app, rather than the whole system.) Add a `removed` config attribute to show helpful warnings to users who are using config options that don't do anything anymore, and apply this attribute to `font.use_thin_strokes`. Bump `crossfont` to 0.5.0 to pick up the new font smoothing behavior. This release also includes a fix for a crash when trying to load a disabled font. Fixes #4616. Fixes #6108. --- alacritty/src/renderer/text/builtin_font.rs | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) (limited to 'alacritty/src/renderer/text') diff --git a/alacritty/src/renderer/text/builtin_font.rs b/alacritty/src/renderer/text/builtin_font.rs index 36d1ccdc..a4bf65e3 100644 --- a/alacritty/src/renderer/text/builtin_font.rs +++ b/alacritty/src/renderer/text/builtin_font.rs @@ -90,6 +90,7 @@ fn box_drawing(character: char, metrics: &Metrics, offset: &Delta) -> Raster left: 0, height: height as i32, width: width as i32, + advance: (0, 0), buffer, }; }, @@ -479,7 +480,15 @@ fn box_drawing(character: char, metrics: &Metrics, offset: &Delta) -> Raster let top = height as i32 + metrics.descent as i32; let buffer = BitmapBuffer::Rgb(canvas.into_raw()); - RasterizedGlyph { character, top, left: 0, height: height as i32, width: width as i32, buffer } + RasterizedGlyph { + character, + top, + left: 0, + height: height as i32, + width: width as i32, + advance: (0, 0), + buffer, + } } #[repr(packed)] -- cgit