From 19120f40be0d2555f984bcadafa0bde8f3df2311 Mon Sep 17 00:00:00 2001 From: Christian Duerr Date: Mon, 28 Nov 2022 02:06:19 +0000 Subject: Fix padding update not updating renderer This fixes an issue where it was possible to update the padding of the terminal without actually queueing an update for the renderer projection, leading to a blurry projection. Closes #6502. --- alacritty/src/display/mod.rs | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) (limited to 'alacritty/src') diff --git a/alacritty/src/display/mod.rs b/alacritty/src/display/mod.rs index ed1b1fc5..3e015874 100644 --- a/alacritty/src/display/mod.rs +++ b/alacritty/src/display/mod.rs @@ -620,14 +620,11 @@ impl Display { if let Some(dimensions) = pending_update.dimensions() { width = dimensions.width as f32; height = dimensions.height as f32; - - let renderer_update = self.pending_renderer_update.get_or_insert(Default::default()); - renderer_update.resize = true } let padding = config.window.padding(self.window.scale_factor as f32); - self.size_info = SizeInfo::new( + let mut new_size = SizeInfo::new( width, height, cell_width, @@ -638,16 +635,22 @@ impl Display { ); // Update number of column/lines in the viewport. - let message_bar_lines = - message_buffer.message().map_or(0, |m| m.text(&self.size_info).len()); + let message_bar_lines = message_buffer.message().map_or(0, |m| m.text(&new_size).len()); let search_lines = usize::from(search_active); - self.size_info.reserve_lines(message_bar_lines + search_lines); + new_size.reserve_lines(message_bar_lines + search_lines); // Resize PTY. - pty_resize_handle.on_resize(self.size_info.into()); + pty_resize_handle.on_resize(new_size.into()); // Resize terminal. - terminal.resize(self.size_info); + terminal.resize(new_size); + + // Queue renderer update if terminal dimensions/padding changed. + if new_size != self.size_info { + let renderer_update = self.pending_renderer_update.get_or_insert(Default::default()); + renderer_update.resize = true; + } + self.size_info = new_size; } /// Update the state of the renderer. -- cgit