From a75e9493449d90b54a140b76f6a96b684784a059 Mon Sep 17 00:00:00 2001 From: Dustin Date: Thu, 17 Oct 2019 15:24:21 -0400 Subject: Fix window title not filled by default In the config, if `window` is undefined, the derived `Default` for the String `title` is used, which is an empty String. This was unintended, and causes issues in gnome-shell (e.g. in the alt-tab dialog) when the window title is an empty string. This commit adds a manually implemented default for the `WindowConfig`, it's the same as the derived `Default`, except for the `title`, which will now always be "Alacritty" as originally intended. --- alacritty/src/cli.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'alacritty/src') diff --git a/alacritty/src/cli.rs b/alacritty/src/cli.rs index b0e3cc94..98edabcb 100644 --- a/alacritty/src/cli.rs +++ b/alacritty/src/cli.rs @@ -301,8 +301,7 @@ mod test { #[test] fn dynamic_title_ignoring_options_by_default() { - let mut config = Config::default(); - config.window.title = "Alacritty".to_string(); + let config = Config::default(); let old_dynamic_title = config.dynamic_title(); let config = Options::default().into_config(config); -- cgit