From 04707cbba630e3e4ad6b4200bef8ae7888c49e3b Mon Sep 17 00:00:00 2001 From: Nathan Lilienthal Date: Sun, 6 Jan 2019 19:06:57 -0500 Subject: Normalize Log Message Strings The general style for errors, warnings and info messages is to start with a capitalized letter and end without a period. The main exception is when dealing with nouns that are clearer with special case handling, e.g. "macOS failed to work" or "ioctl is borked". --- src/input.rs | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'src/input.rs') diff --git a/src/input.rs b/src/input.rs index 8b3bcbed..45956794 100644 --- a/src/input.rs +++ b/src/input.rs @@ -224,7 +224,7 @@ impl Action { .and_then(|clipboard| clipboard.load_primary() ) .map(|contents| { self.paste(ctx, &contents) }) .unwrap_or_else(|err| { - error!("Error loading data from clipboard. {}", Red(err)); + error!("Error loading data from clipboard: {}", Red(err)); }); }, Action::PasteSelection => { @@ -234,19 +234,19 @@ impl Action { .and_then(|clipboard| clipboard.load_selection() ) .map(|contents| { self.paste(ctx, &contents) }) .unwrap_or_else(|err| { - error!("Error loading data from clipboard. {}", Red(err)); + error!("Error loading data from clipboard: {}", Red(err)); }); } }, Action::Command(ref program, ref args) => { - trace!("running command: {} {:?}", program, args); + trace!("Running command {} with args {:?}", program, args); match start_daemon(program, args) { Ok(_) => { - debug!("spawned new proc"); + debug!("Spawned new proc"); }, Err(err) => { - warn!("couldn't run command: {}", err); + warn!("Couldn't run command {}", err); }, } }, @@ -546,8 +546,8 @@ impl<'a, A: ActionContext + 'a> Processor<'a, A> { args.push(text); match start_daemon(launcher.program(), &args) { - Ok(_) => debug!("Launched: {} {:?}", launcher.program(), args), - Err(_) => warn!("Unable to launch: {} {:?}", launcher.program(), args), + Ok(_) => debug!("Launched {} with args {:?}", launcher.program(), args), + Err(_) => warn!("Unable to launch {} with args {:?}", launcher.program(), args), } Some(()) -- cgit