From 62c1d999e1361fc68ee4e54865b205415fa0a38d Mon Sep 17 00:00:00 2001 From: Rachel K Date: Tue, 12 Mar 2019 19:44:47 +0000 Subject: Fix signal handling on Unix systems This removes the the signal handling machinery in tty::unix, and replaces it with functionality from signal-hook, which should be more robust. Signals caught by signal-hook wake up the existing I/O event loop, which then delegates back to the PTY to handle them. In particular, this allows `SIGCHLD` (i.e. child process exits) to shut down the terminal promptly, instead of sometimes leaving the window lingering. Fixes #915. Fixes #1276. Fixes #1313. As a side effect, this fixes a very rare bug on Linux, where a `read` from the PTY on the master side would sometimes "fail" with `EIO` if the child closed the client side at a particular moment. This was subject to a race condition, and was very difficult to trigger in practice. --- src/term/mod.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/term/mod.rs') diff --git a/src/term/mod.rs b/src/term/mod.rs index 63b0ca80..fc59ffd6 100644 --- a/src/term/mod.rs +++ b/src/term/mod.rs @@ -34,6 +34,8 @@ use crate::url::UrlParser; use crate::message_bar::MessageBuffer; use crate::term::color::Rgb; use crate::term::cell::{LineLength, Cell}; + +#[cfg(windows)] use crate::tty; pub mod cell; @@ -1336,7 +1338,7 @@ impl Term { #[inline] pub fn should_exit(&self) -> bool { - tty::process_should_exit() || self.should_exit + self.should_exit } } -- cgit