From 865727c062810e29fa33b5c04bb05510e7da3ddf Mon Sep 17 00:00:00 2001 From: Lucas Timmins Date: Sun, 2 Sep 2018 21:29:17 +0800 Subject: Remove redundant copy when selecting font_key --- src/renderer/mod.rs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/renderer/mod.rs b/src/renderer/mod.rs index b006f566..560685af 100644 --- a/src/renderer/mod.rs +++ b/src/renderer/mod.rs @@ -827,12 +827,13 @@ impl<'a> RenderApi<'a> { for cell in cells { // Get font key for cell // FIXME this is super inefficient. - let mut font_key = glyph_cache.font_key; - if cell.flags.contains(cell::Flags::BOLD) { - font_key = glyph_cache.bold_key; + let font_key = if cell.flags.contains(cell::Flags::BOLD) { + glyph_cache.bold_key } else if cell.flags.contains(cell::Flags::ITALIC) { - font_key = glyph_cache.italic_key; - } + glyph_cache.italic_key + } else { + glyph_cache.font_key + }; let glyph_key = GlyphKey { font_key, -- cgit