rneovim.git/ci, branch rahm Neovim fork with Rahm's personal hacks. ci: move external_deps job from cirrus-ci back to github actions 2023-09-03T10:06:32+00:00 dundargoc 33953936+dundargoc@users.noreply.github.com 2023-09-03T10:06:32+00:00 3bf2839dec09a7a8ad38b164eb06e193c107181a This partially reverts commit 7d0479c55810af9bf9f115ba69d1419ea81ec41e. The job has been particularly unstable when used with docker on cirrus-ci, which is especially bad as it's meant to be a non-flaky and simple test. 
This partially reverts commit 7d0479c55810af9bf9f115ba69d1419ea81ec41e.

The job has been particularly unstable when used with docker on
cirrus-ci, which is especially bad as it's meant to be a non-flaky and
simple test.
 ci: containerize the external dependencies test 2023-04-26T21:22:12+00:00 dundargoc 33953936+dundargoc@users.noreply.github.com 2023-04-26T21:22:12+00:00 7d0479c55810af9bf9f115ba69d1419ea81ec41e Cirrus ci automatically pushes/caches docker images, which makes containerization much simpler to handle. Moving this job to cirrus ci shortens the job by a minute, and reduces github actions CI usage by two minutes per PR. 
Cirrus ci automatically pushes/caches docker images, which makes
containerization much simpler to handle. Moving this job to cirrus ci
shortens the job by a minute, and reduces github actions CI usage by two
minutes per PR.
 ci: delete ci/ (#22227) 2023-02-12T10:50:08+00:00 dundargoc 33953936+dundargoc@users.noreply.github.com 2023-02-12T10:50:08+00:00 e81b4274fc18de4be753c07db642111129ff84ee Having CI scripts that is separate from the build system causes tremendous amounts of problems, headaches and bugs. Testing the validity of the scripts locally become near impossible as time goes on as they're only vetted if it works on whatever CI provider we happened to have at the time, with their own quirks and behavior. The extra indirection between "cmake <-> general CI scripts <-> GHA" is also a frequent source of problems, as the orchestration needs to be done with environment variables, cmake flags and github actions matrix strategy. This combination has turned out to be exceptionally fragile. Examples: https://github.com/neovim/neovim/commit/15394b6855c3b17be06bf2bfbac7797d9c3ebf1d https://github.com/neovim/neovim/commit/13aa23b62af4df3e7f10687b76fe8c04efa2a598 https://github.com/neovim/neovim/pull/22072#discussion_r1094390713 A lot of the code was inlined to .github/workflows/ci.yml without further modifications. While this in itself doesn't integrate with our build system any more than the current situation, it does 1. remove a level of indirection, and more importantly 2. allow us to slowly start integrating the CI into our build system now that all the relevant code is in one place. 
Having CI scripts that is separate from the build system causes
tremendous amounts of problems, headaches and bugs. Testing the validity
of the scripts locally become near impossible as time goes on as they're
only vetted if it works on whatever CI provider we happened to have at
the time, with their own quirks and behavior.

The extra indirection between "cmake <-> general CI scripts <-> GHA" is
also a frequent source of problems, as the orchestration needs to be
done with environment variables, cmake flags and github actions matrix
strategy. This combination has turned out to be exceptionally fragile.

Examples:
https://github.com/neovim/neovim/commit/15394b6855c3b17be06bf2bfbac7797d9c3ebf1d
https://github.com/neovim/neovim/commit/13aa23b62af4df3e7f10687b76fe8c04efa2a598
https://github.com/neovim/neovim/pull/22072#discussion_r1094390713

A lot of the code was inlined to .github/workflows/ci.yml without
further modifications. While this in itself doesn't integrate with our
build system any more than the current situation, it does
1. remove a level of indirection, and more importantly
2. allow us to slowly start integrating the CI into our build system now
   that all the relevant code is in one place.
 ci: show all logs at the end of a run (#22226) 2023-02-11T17:16:04+00:00 dundargoc 33953936+dundargoc@users.noreply.github.com 2023-02-11T17:16:04+00:00 3a5dddf24f9d4d8959194b0cd3c6a7dd0cbd73ae * ci: show all logs at the end of a run The current CI won't show the logs on error due to early exit. This will at least show the logs, although for all tests at once. 
* ci: show all logs at the end of a run

The current CI won't show the logs on error due to early exit. This will
at least show the logs, although for all tests at once.
 ci: don't delete core dumps at the start of the run (#22223) 2023-02-11T13:51:41+00:00 dundargoc 33953936+dundargoc@users.noreply.github.com 2023-02-11T13:51:41+00:00 24ec0aaa7a1589fd4b67dc44f201842900d81c89 There shouldn't be any core dumps before we have started testing. 
There shouldn't be any core dumps before we have started testing.
 ci: inline build commands and remove before_script.sh (#22202) 2023-02-11T12:27:43+00:00 dundargoc 33953936+dundargoc@users.noreply.github.com 2023-02-11T12:27:43+00:00 883ec20d9f91bde9c348bfcc0e1fcc3e3533cd89 Abstracting the build commands to a separate script makes it more difficult to reason about it and more error-prone. 
Abstracting the build commands to a separate script makes it more
difficult to reason about it and more error-prone.
 ci: inline test.sh to run_tests.sh (#22198) 2023-02-09T23:42:37+00:00 dundargoc 33953936+dundargoc@users.noreply.github.com 2023-02-09T23:42:37+00:00 fe1e6b82f4f3ff3d919d1243f37e9216781bb786 This will get rid of the common/ directory. 
This will get rid of the common/ directory.
 ci: inline internal caching script to Github actions (#22192) 2023-02-09T20:13:03+00:00 dundargoc 33953936+dundargoc@users.noreply.github.com 2023-02-09T20:13:03+00:00 ec932961cc5596009f3179edd620bc778a1503d7 I don't think it's possible to meaningfully abstract away caching on multiple providers, as each provider has different mechanisms on how they work. 
I don't think it's possible to meaningfully abstract away caching on
multiple providers, as each provider has different mechanisms
on how they work.
 build: remove codecov related files (#20859) 2023-02-09T10:04:02+00:00 dundargoc 33953936+dundargoc@users.noreply.github.com 2023-02-09T10:04:02+00:00 ad00b034261dac70f728012339bd05fc89f8e90e These aren't needed as we don't use codecov anymore. 
These aren't needed as we don't use codecov anymore.
 ci: remove fail summary (#22174) 2023-02-08T17:32:17+00:00 dundargoc 33953936+dundargoc@users.noreply.github.com 2023-02-08T17:32:17+00:00 2294210660056df2f8abb277776cfd68f3fb1156 The tests already have a summary at the end, there's no need for an additional fail summary wrapper. 
The tests already have a summary at the end, there's no need for an
additional fail summary wrapper.