rneovim.git/src, branch usermarks Neovim fork with Rahm's personal hacks. Merge remote-tracking branch 'upstream/master' into usermarks 2023-01-25T18:31:31+00:00 Josh Rahm joshuarahm@gmail.com 2023-01-25T18:31:31+00:00 9243becbedbb6a1592208051f8fa2b090dcc5e7d 






Merge pull request #21885 from lewis6991/refactor/options
2023-01-25T13:46:23+00:00

Lewis Russell
lewis6991@gmail.com

2023-01-25T13:46:23+00:00

e2a9d71521a1acdc5a554e3d9f54dfe543914db5


Problems:
    - Scope of local variables in options code is too large.
    - did_set_string_option() is too large (>1000LOC).
    - Setting options for a particular window or buffer requires a changing context (assigning curwin/curbuf).

Solutions:
    - Reduce the scope of local variables.
    - Break up did_set_string_option so it doesn't contain specific logic about each individual option (1038 LOC -> 310 LOC).
    - Begin work on making functions not depend on curbuf or curwin and pass window or buffer handles explicitly.







Problems:
    - Scope of local variables in options code is too large.
    - did_set_string_option() is too large (>1000LOC).
    - Setting options for a particular window or buffer requires a changing context (assigning curwin/curbuf).

Solutions:
    - Reduce the scope of local variables.
    - Break up did_set_string_option so it doesn't contain specific logic about each individual option (1038 LOC -> 310 LOC).
    - Begin work on making functions not depend on curbuf or curwin and pass window or buffer handles explicitly.








refactor(optionstr.c): move handling of formatlistpat
2023-01-25T12:17:38+00:00

Lewis Russell
lewis6991@gmail.com

2023-01-25T12:17:38+00:00

7bee622fdc72d7461ed43ea170cca20056891d2c












refactor(optionstr.c): break up did_set_expropt
2023-01-25T12:13:06+00:00

Lewis Russell
lewis6991@gmail.com

2023-01-25T12:06:12+00:00

15499fa856f6fbaf3208a26647db95259ae76e8e












refactor(optionstr.c): remove some redundant parens
2023-01-25T11:48:55+00:00

Lewis Russell
lewis6991@gmail.com

2023-01-25T10:23:26+00:00

f37ec6026fcb3f9a124aab61418a6ae7145d14e9












refactor(optionstr.c): break up did_option_listflags
2023-01-25T11:48:55+00:00

Lewis Russell
lewis6991@gmail.com

2023-01-25T10:20:45+00:00

b278e0740e1cafb5818de9de9206eea4dfee9795












refactor(optionstr.c): add did_set_string_option_for
2023-01-25T11:48:55+00:00

Lewis Russell
lewis6991@gmail.com

2023-01-24T13:15:15+00:00

38ed4321646c8e167182c440ecd320ef12cadcad












refactor(optionstr.c): break up did_set_string_option 52
2023-01-25T11:48:53+00:00

Lewis Russell
lewis6991@gmail.com

2023-01-23T12:40:28+00:00

414e71fa4fb5949979af6b7c86cd5e06a13b8cf7












refactor(optionstr.c): break up did_set_string_option 51
2023-01-25T11:48:53+00:00

Lewis Russell
lewis6991@gmail.com

2023-01-23T12:22:03+00:00

0012ed2bc74f08d0a8e68b23de87f66235c7a68f












refactor(optionstr.c): remove some simple did_set_* functions 2
2023-01-25T11:48:53+00:00

Lewis Russell
lewis6991@gmail.com

2023-01-23T12:16:34+00:00

2654a9e9d8db3f1179636bfe5419aad13b5aeada