<feed xmlns='http://www.w3.org/2005/Atom'>
<title>rneovim.git/test/functional/ui, branch usermarks</title>
<subtitle>Neovim fork with Rahm's personal hacks.
</subtitle>
<link rel='alternate' type='text/html' href='https://git.josher.dev/cgit/rneovim.git/'/>
<entry>
<title>revert: "refactor(win_close): remove "force", don't pass on "free_buf" (#21921)" (#21979)</title>
<updated>2023-01-24T10:31:07+00:00</updated>
<author>
<name>zeertzjq</name>
<email>zeertzjq@outlook.com</email>
</author>
<published>2023-01-24T10:31:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.josher.dev/cgit/rneovim.git/commit/?id=c6ab8dfc15e0f6f1a805ce2145e2b4f0072b33d1'/>
<id>c6ab8dfc15e0f6f1a805ce2145e2b4f0072b33d1</id>
<content type='text'>
This reverts commit 0371d0f7afa5e01dd2ac8bbd3abcf0f7454872b3.

&gt; 'bufhidden' option exists. I don't think we should assume autoclosing
windows are fine just because 'hidden' is set.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit 0371d0f7afa5e01dd2ac8bbd3abcf0f7454872b3.

&gt; 'bufhidden' option exists. I don't think we should assume autoclosing
windows are fine just because 'hidden' is set.</pre>
</div>
</content>
</entry>
<entry>
<title>refactor(win_close): remove "force", don't pass on "free_buf" (#21921)</title>
<updated>2023-01-23T10:55:11+00:00</updated>
<author>
<name>zeertzjq</name>
<email>zeertzjq@outlook.com</email>
</author>
<published>2023-01-23T10:55:11+00:00</published>
<link rel='alternate' type='text/html' href='https://git.josher.dev/cgit/rneovim.git/commit/?id=0371d0f7afa5e01dd2ac8bbd3abcf0f7454872b3'/>
<id>0371d0f7afa5e01dd2ac8bbd3abcf0f7454872b3</id>
<content type='text'>
Problem:
The "force" flag of win_close() complicates the code and adds edge cases
where it is not clear what the correct behavior should be.
The "free_buf" flag of win_close() is passed on to float windows when
closing the last window of a tabpage, which doesn't make much sense.

Solution:
Remove the "force" flag and always close float windows as if :close! is
used when closing the last window of a tabpage, and set the "free_buf"
flag for a float window based on whether its buffer can be freed.
As 'hidden' is on by default, this change shouldn't affect many people.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Problem:
The "force" flag of win_close() complicates the code and adds edge cases
where it is not clear what the correct behavior should be.
The "free_buf" flag of win_close() is passed on to float windows when
closing the last window of a tabpage, which doesn't make much sense.

Solution:
Remove the "force" flag and always close float windows as if :close! is
used when closing the last window of a tabpage, and set the "free_buf"
flag for a float window based on whether its buffer can be freed.
As 'hidden' is on by default, this change shouldn't affect many people.</pre>
</div>
</content>
</entry>
<entry>
<title>fix(extmarks): problems with folded virtual lines (#21930)</title>
<updated>2023-01-22T23:43:04+00:00</updated>
<author>
<name>luukvbaal</name>
<email>31730729+luukvbaal@users.noreply.github.com</email>
</author>
<published>2023-01-22T23:43:04+00:00</published>
<link rel='alternate' type='text/html' href='https://git.josher.dev/cgit/rneovim.git/commit/?id=323ea17a19911f88c15b36e2251657edfa09b30b'/>
<id>323ea17a19911f88c15b36e2251657edfa09b30b</id>
<content type='text'>
Problem:    When a folded line has virtual lines attached, the following
            problems occur:
              - The virtual lines are drawn empty.
              - The 'foldtext' line is drawn empty.
              - The cursor is drawn incorrectly.
Solution:   Check whether virtual lines belong to a folded line.

Fix #17027
Fix #19557
Fix #21837

Co-authored-by: zeertzjq &lt;zeertzjq@outlook.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Problem:    When a folded line has virtual lines attached, the following
            problems occur:
              - The virtual lines are drawn empty.
              - The 'foldtext' line is drawn empty.
              - The cursor is drawn incorrectly.
Solution:   Check whether virtual lines belong to a folded line.

Fix #17027
Fix #19557
Fix #21837

Co-authored-by: zeertzjq &lt;zeertzjq@outlook.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>vim-patch:8.2.0382: some tests fail when run under valgrind (#21936)</title>
<updated>2023-01-21T12:50:46+00:00</updated>
<author>
<name>zeertzjq</name>
<email>zeertzjq@outlook.com</email>
</author>
<published>2023-01-21T12:50:46+00:00</published>
<link rel='alternate' type='text/html' href='https://git.josher.dev/cgit/rneovim.git/commit/?id=0f52e2c849cbd923fc30b8bbef088b6f7642aeab'/>
<id>0f52e2c849cbd923fc30b8bbef088b6f7642aeab</id>
<content type='text'>
Problem:    Some tests fail when run under valgrind.
Solution:   Increase timeouts.

https://github.com/vim/vim/commit/353c351bd22e4dac4c3ae9cd7731032348f248c4

Cherry-pick Test_pum_with_preview_win() from patch 8.2.0011.

Co-authored-by: Bram Moolenaar &lt;Bram@vim.org&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Problem:    Some tests fail when run under valgrind.
Solution:   Increase timeouts.

https://github.com/vim/vim/commit/353c351bd22e4dac4c3ae9cd7731032348f248c4

Cherry-pick Test_pum_with_preview_win() from patch 8.2.0011.

Co-authored-by: Bram Moolenaar &lt;Bram@vim.org&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>perf(statuscolumn): only fill click defs array once per redraw (#21884)</title>
<updated>2023-01-19T23:47:02+00:00</updated>
<author>
<name>luukvbaal</name>
<email>31730729+luukvbaal@users.noreply.github.com</email>
</author>
<published>2023-01-19T23:47:02+00:00</published>
<link rel='alternate' type='text/html' href='https://git.josher.dev/cgit/rneovim.git/commit/?id=999bb983f0f44b16126b79ba105f079ac1df21ff'/>
<id>999bb983f0f44b16126b79ba105f079ac1df21ff</id>
<content type='text'>
Problem:    'statuscolumn' click definitions are cleared, evaluated,
            allocated and filled each redraw for every row in a window.
            This despite the fact that we only store a single click
            definition array for the entire column as opposed to one
            for each row.
Solution:   Only fill the 'statuscolumn' click definition array once per
            window per redraw.

Resolve https://github.com/neovim/neovim/issues/21767.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Problem:    'statuscolumn' click definitions are cleared, evaluated,
            allocated and filled each redraw for every row in a window.
            This despite the fact that we only store a single click
            definition array for the entire column as opposed to one
            for each row.
Solution:   Only fill the 'statuscolumn' click definition array once per
            window per redraw.

Resolve https://github.com/neovim/neovim/issues/21767.</pre>
</div>
</content>
</entry>
<entry>
<title>vim-patch:8.2.4655: cmdline completion popup menu positioned wrong (#21894)</title>
<updated>2023-01-19T07:13:27+00:00</updated>
<author>
<name>zeertzjq</name>
<email>zeertzjq@outlook.com</email>
</author>
<published>2023-01-19T07:13:27+00:00</published>
<link rel='alternate' type='text/html' href='https://git.josher.dev/cgit/rneovim.git/commit/?id=6e3890f4ce002ba308c09166b00e8ee86b6efa03'/>
<id>6e3890f4ce002ba308c09166b00e8ee86b6efa03</id>
<content type='text'>
Problem:    Command line completion popup menu positioned wrong when using a
            terminal window.
Solution:   Position the popup menu differently when editing the command line.
            (Yegappan Lakshmanan, closes vim/vim#10050, closes vim/vim#10035)

https://github.com/vim/vim/commit/1104a6d0c2004d39e9b6cb8f804d12b628a69869

The test in the patch looks a bit hard to understand.
Add a Lua test that is more straightforward.

Co-authored-by: Yegappan Lakshmanan &lt;yegappan@yahoo.com&gt;</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Problem:    Command line completion popup menu positioned wrong when using a
            terminal window.
Solution:   Position the popup menu differently when editing the command line.
            (Yegappan Lakshmanan, closes vim/vim#10050, closes vim/vim#10035)

https://github.com/vim/vim/commit/1104a6d0c2004d39e9b6cb8f804d12b628a69869

The test in the patch looks a bit hard to understand.
Add a Lua test that is more straightforward.

Co-authored-by: Yegappan Lakshmanan &lt;yegappan@yahoo.com&gt;</pre>
</div>
</content>
</entry>
<entry>
<title>fix(statusline): don't leak memory with truncated click labels</title>
<updated>2023-01-19T02:36:29+00:00</updated>
<author>
<name>zeertzjq</name>
<email>zeertzjq@outlook.com</email>
</author>
<published>2023-01-18T11:10:58+00:00</published>
<link rel='alternate' type='text/html' href='https://git.josher.dev/cgit/rneovim.git/commit/?id=01ddc097474627f35cc34fb7015dd26505e2ddcc'/>
<id>01ddc097474627f35cc34fb7015dd26505e2ddcc</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>fix(statusline): don't leak memory with zero-width click labels</title>
<updated>2023-01-19T02:36:29+00:00</updated>
<author>
<name>zeertzjq</name>
<email>zeertzjq@outlook.com</email>
</author>
<published>2023-01-18T07:12:45+00:00</published>
<link rel='alternate' type='text/html' href='https://git.josher.dev/cgit/rneovim.git/commit/?id=295a264b65bd072bf858496e0e5de83d5b1f5ffa'/>
<id>295a264b65bd072bf858496e0e5de83d5b1f5ffa</id>
<content type='text'>
A zero-width click label isn't assigned to any click definition, so its
function name should be freed when filling click definitions.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
A zero-width click label isn't assigned to any click definition, so its
function name should be freed when filling click definitions.
</pre>
</div>
</content>
</entry>
<entry>
<title>fix(statuscolumn): always fill click defs array (#21878)</title>
<updated>2023-01-18T09:55:03+00:00</updated>
<author>
<name>zeertzjq</name>
<email>zeertzjq@outlook.com</email>
</author>
<published>2023-01-18T09:55:03+00:00</published>
<link rel='alternate' type='text/html' href='https://git.josher.dev/cgit/rneovim.git/commit/?id=36555730daaac8a9b88878a869c0cef6d5b701f0'/>
<id>36555730daaac8a9b88878a869c0cef6d5b701f0</id>
<content type='text'>
Click definitions are always filled for tabline, statusline and winbar,
so they should also be always filled for statuscolumn, otherwise it will
leak memory.

Note: this doesn't actually change the existing code much, because of a
typo in the existing code.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Click definitions are always filled for tabline, statusline and winbar,
so they should also be always filled for statuscolumn, otherwise it will
leak memory.

Note: this doesn't actually change the existing code much, because of a
typo in the existing code.</pre>
</div>
</content>
</entry>
<entry>
<title>fix(tabline): avoid memory leak in tabline click definitions (#21847)</title>
<updated>2023-01-17T01:51:01+00:00</updated>
<author>
<name>luukvbaal</name>
<email>31730729+luukvbaal@users.noreply.github.com</email>
</author>
<published>2023-01-17T01:51:01+00:00</published>
<link rel='alternate' type='text/html' href='https://git.josher.dev/cgit/rneovim.git/commit/?id=f6929ea51d21034c6ed00d68a727c2c7cd7ec6ac'/>
<id>f6929ea51d21034c6ed00d68a727c2c7cd7ec6ac</id>
<content type='text'>
Problem:    Memory is leaked in tabline click definitions since
            https://github.com/neovim/neovim/pull/21008.
Solution:   Add back a call to `stl_clear_click_defs()` that was lost in
            the refactor PR.</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Problem:    Memory is leaked in tabline click definitions since
            https://github.com/neovim/neovim/pull/21008.
Solution:   Add back a call to `stl_clear_click_defs()` that was lost in
            the refactor PR.</pre>
</div>
</content>
</entry>
</feed>
