diff options
| author | dundargoc <33953936+dundargoc@users.noreply.github.com> | 2022-05-16 00:59:58 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-15 15:59:58 -0700 |
| commit | f8af81445bb48966d54f4a956842d935d009d275 (patch) | |
| tree | 59fe07ee345a223818a50d514f6aba5102eb4f49 /.github/workflows | |
| parent | 59ba66d1ab64be1b01154d0cab7f8af9fe02e93d (diff) | |
| download | rneovim-f8af81445bb48966d54f4a956842d935d009d275.tar.gz rneovim-f8af81445bb48966d54f4a956842d935d009d275.tar.bz2 rneovim-f8af81445bb48966d54f4a956842d935d009d275.zip | |
ci: remove mingw job #18580
Unnecessary CI builds increase the change of spurious failures, which are costly
noise. Of course, we should fix all legitimate bugs, but we also cannot
micro-manage every platform, so there needs to be a clear motivation for the CI
builds that we maintain.
Reasons against maintaining a mingw CI job:
1. The windows mingw build is slow.
2. Failures:
- https://github.com/neovim/neovim/issues/18494
- https://github.com/neovim/neovim/issues/18495
3. The mingw artifact is 10x bigger than the windows MSVC artifact:
https://github.com/neovim/neovim/issues/10560
4. Our releases publish the MSVC (not mingw) artifact for Windows users:
https://github.com/neovim/neovim/releases
5. Non-MSVCRT has limitations documented by libuv: http://docs.libuv.org/en/v1.x/process.html
> On Windows file descriptors greater than 2 are available to the child process only if the child processes uses the MSVCRT runtime.
Closes https://github.com/neovim/neovim/issues/18551
Diffstat (limited to '.github/workflows')
| -rw-r--r-- | .github/workflows/ci.yml | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c60473d541..9a98c6097c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -236,21 +236,16 @@ jobs: env: DEPS_BUILD_DIR: ${{ format('{0}/nvim-deps', github.workspace) }} DEPS_PREFIX: ${{ format('{0}/nvim-deps/usr', github.workspace) }} - - strategy: - fail-fast: false - matrix: - config: [ MINGW_64-gcov, MSVC_64 ] - name: windows (${{ matrix.config }}) + name: windows (MSVC_64) steps: - uses: actions/checkout@v2 - uses: actions/cache@v2 with: path: ${{ env.DEPS_BUILD_DIR }} - key: ${{ matrix.config }}-${{ hashFiles('third-party\**') }} + key: ${{ hashFiles('third-party\**') }} - name: Run CI run: powershell ci\build.ps1 env: - CONFIGURATION: ${{ matrix.config }} + CONFIGURATION: MSVC_64 |