diff options
| author | Dundar Göc <gocdundar@gmail.com> | 2022-02-11 16:09:12 +0100 |
|---|---|---|
| committer | Dundar Göc <gocdundar@gmail.com> | 2022-02-12 11:03:32 +0100 |
| commit | 0c901baee11ad1961d034281d7f83f1d66292f89 (patch) | |
| tree | 26287add1feca40e379e43e1a76d1fbbfb554851 | |
| parent | a7321e37a75fff5c0048b0779cf91d504455d6f3 (diff) | |
| download | rneovim-0c901baee11ad1961d034281d7f83f1d66292f89.tar.gz rneovim-0c901baee11ad1961d034281d7f83f1d66292f89.tar.bz2 rneovim-0c901baee11ad1961d034281d7f83f1d66292f89.zip | |
revert: "ci: use continue-on-error instead of "|| true""
This reverts commit 559aa4179c639f5ebd45474a36361343ac2371cf.
I mistakenly believed both ways of writing were equivalent; this is
untrue. Setting continue-on-error to true will make the job pass, but
an error annotation will still be created which is misleading since it's
not actually an error.
| -rw-r--r-- | .github/workflows/labeler.yml | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index 0e20e96cb6..08f0ce1763 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -27,11 +27,9 @@ jobs: PR_TITLE: ${{ github.event.pull_request.title }} steps: - name: "Extract commit type and add as label" - continue-on-error: true - run: gh pr edit "$PR_NUMBER" --add-label "$(echo "$PR_TITLE" | sed -E 's|([[:alpha:]]+)(\(.*\))?!?:.*|\1|')" + run: gh pr edit "$PR_NUMBER" --add-label "$(echo "$PR_TITLE" | sed -E 's|([[:alpha:]]+)(\(.*\))?!?:.*|\1|')" || true - name: "Extract commit scope and add as label" - continue-on-error: true - run: gh pr edit "$PR_NUMBER" --add-label "$(echo "$PR_TITLE" | sed -E 's|[[:alpha:]]+\((.+)\)!?:.*|\1|')" + run: gh pr edit "$PR_NUMBER" --add-label "$(echo "$PR_TITLE" | sed -E 's|[[:alpha:]]+\((.+)\)!?:.*|\1|')" || true upload-pr-number: runs-on: ubuntu-latest |