diff options
| author | Michael Lingelbach <m.j.lbach@gmail.com> | 2021-12-19 12:49:56 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-19 12:49:56 -0800 |
| commit | d6b939a13f0eb0660b1d59ed456d6f379b7c1b66 (patch) | |
| tree | b80e8e9b8ed2eca6c541bbfce7512cec154ffa57 /runtime/lua/vim/lsp.lua | |
| parent | 115d4da88261d1f464b015622888504a26aef434 (diff) | |
| download | rneovim-d6b939a13f0eb0660b1d59ed456d6f379b7c1b66.tar.gz rneovim-d6b939a13f0eb0660b1d59ed456d6f379b7c1b66.tar.bz2 rneovim-d6b939a13f0eb0660b1d59ed456d6f379b7c1b66.zip | |
fix(lsp): avoid attaching to unloaded buffers (#16723)
Closes https://github.com/neovim/neovim/issues/16562 https://github.com/neovim/neovim/issues/16249 https://github.com/neovim/neovim/issues/16297
* buf_attach_client can be called on an unloaded buffer
* on_attach will prematurely fail, while the language server client
tracks this buffer as attached
* The language server client will track this buffer as attached despite
textDocument/didChange notifications not being sent to the server
* Instead, check if the buffer is loaded and return early, warning via
the lsp logger that buf_attach_client was called on an invalid buffer
Diffstat (limited to 'runtime/lua/vim/lsp.lua')
| -rw-r--r-- | runtime/lua/vim/lsp.lua | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/runtime/lua/vim/lsp.lua b/runtime/lua/vim/lsp.lua index 2e530ec17a..25cde843a0 100644 --- a/runtime/lua/vim/lsp.lua +++ b/runtime/lua/vim/lsp.lua @@ -1156,6 +1156,12 @@ function lsp.buf_attach_client(bufnr, client_id) client_id = {client_id, 'n'}; } bufnr = resolve_bufnr(bufnr) + if not vim.api.nvim_buf_is_loaded(bufnr) then + local _ = log.warn() and log.warn( + string.format("buf_attach_client called on unloaded buffer (id: %d): ", bufnr) + ) + return false + end local buffer_client_ids = all_buffer_active_clients[bufnr] -- This is our first time attaching to this buffer. if not buffer_client_ids then |