diff options
author | Björn Linse <bjorn.linse@gmail.com> | 2021-10-25 21:51:29 +0200 |
---|---|---|
committer | Björn Linse <bjorn.linse@gmail.com> | 2022-01-15 22:08:12 +0100 |
commit | 95ab979fde66d8f9f97fceb943bfe9422739a0f8 (patch) | |
tree | 282421964ebc7edb30c04415d55497e1ffd24862 /runtime/lua/vim/lsp/buf.lua | |
parent | c09147aad99a88dc39c47c276b431ade4c83ac9d (diff) | |
download | rneovim-95ab979fde66d8f9f97fceb943bfe9422739a0f8.tar.gz rneovim-95ab979fde66d8f9f97fceb943bfe9422739a0f8.tar.bz2 rneovim-95ab979fde66d8f9f97fceb943bfe9422739a0f8.zip |
refactor(extmarks): use a more efficient representation
marktree.c was originally constructed as a "generic" datatype,
to make the prototyping of its internal logic as simple as possible
and also as the usecases for various kinds of extmarks/decorations was not yet decided.
As a consequence of this, various extra indirections and allocations was
needed to use marktree to implement extmarks (ns/id pairs) and
decorations of different kinds (some which is just a single highlight
id, other an allocated list of virtual text/lines)
This change removes a lot of indirection, by making Marktree specialized
for the usecase. In particular, the namespace id and mark id is stored
directly, instead of the 64-bit global id particular to the Marktree
struct. This removes the two maps needed to convert between global and
per-ns ids.
Also, "small" decorations are stored inline, i.e. those who
doesn't refer to external heap memory anyway. That is highlights (with
priority+flags) are stored inline, while virtual text, which anyway
occurs a lot of heap allocations, do not. (previously a hack was used
to elide heap allocations for highlights with standard prio+flags)
TODO(bfredl): the functionaltest-lua CI version of gcc is having
severe issues with uint16_t bitfields, so splitting up compound
assignments and redundant casts are needed. Clean this up once we switch
to a working compiler version.
Diffstat (limited to 'runtime/lua/vim/lsp/buf.lua')
0 files changed, 0 insertions, 0 deletions