refactor(api): consistent VALIDATE messages #22262

Problem:
Validation messages are not consistently formatted.
- Parameter names sometimes are NOT quoted.
- Descriptive names (non-parameters) sometimes ARE quoted.

Solution:
Always quote the `name` value passed to a VALIDATE macro _unless_ the
value has whitespace.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/nvim/api/command.c b/src/nvim/api/command.c
index cae3927dfd..81b70b07d0 100644
--- a/src/nvim/api/command.c
+++ b/src/nvim/api/command.c
@@ -1017,7 +1017,7 @@ void create_user_command(String name, Object command, Dict(user_command) *opts,
   VALIDATE_S(uc_validate_name(name.data), "command name", name.data, {
     goto err;
   });
-  VALIDATE_S(!mb_islower(name.data[0]), "command name (must begin with an uppercase letter)",
+  VALIDATE_S(!mb_islower(name.data[0]), "command name (must start with uppercase)",
              name.data, {
     goto err;
   });
@@ -1163,7 +1163,7 @@ void create_user_command(String name, Object command, Dict(user_command) *opts,
       goto err;
     });
   } else if (HAS_KEY(opts->complete)) {
-    VALIDATE(false, "%s", "Invalid complete: expected Function or String", {
+    VALIDATE_EXP(false, "complete", "Function or String", NULL, {
       goto err;
     });
   }
@@ -1190,7 +1190,7 @@ void create_user_command(String name, Object command, Dict(user_command) *opts,
     rep = command.data.string.data;
     break;
   default:
-    VALIDATE(false, "%s", "Invalid command: expected Function or String", {
+    VALIDATE_EXP(false, "command", "Function or String", NULL, {
       goto err;
     });
   }