diff options
| author | bfredl <bjorn.linse@gmail.com> | 2023-08-24 15:14:23 +0200 |
|---|---|---|
| committer | bfredl <bjorn.linse@gmail.com> | 2023-08-24 22:40:56 +0200 |
| commit | cefd774fac76b91f5368833555818c80c992c3b1 (patch) | |
| tree | 146d6cb8fde01d28c5b03b9640f9e2515c4a89b7 /src/nvim/buffer.c | |
| parent | daf7abbc4238dc269e22dd431bc4b1627ef9b6a1 (diff) | |
| download | rneovim-cefd774fac76b91f5368833555818c80c992c3b1.tar.gz rneovim-cefd774fac76b91f5368833555818c80c992c3b1.tar.bz2 rneovim-cefd774fac76b91f5368833555818c80c992c3b1.zip | |
refactor(memline): distinguish mutating uses of ml_get_buf()
ml_get_buf() takes a third parameters to indicate whether the
caller wants to mutate the memline data in place. However
the vast majority of the call sites is using this function
just to specify a buffer but without any mutation. This makes
it harder to grep for the places which actually perform mutation.
Solution: Remove the bool param from ml_get_buf(). it now works
like ml_get() except for a non-current buffer. Add a new
ml_get_buf_mut() function for the mutating use-case, which can
be grepped along with the other ml_replace() etc functions which
can modify the memline.
Diffstat (limited to 'src/nvim/buffer.c')
| -rw-r--r-- | src/nvim/buffer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nvim/buffer.c b/src/nvim/buffer.c index fd912a65e0..1e093916d3 100644 --- a/src/nvim/buffer.c +++ b/src/nvim/buffer.c @@ -4250,7 +4250,7 @@ bool buf_contents_changed(buf_T *buf) if (buf->b_ml.ml_line_count == curbuf->b_ml.ml_line_count) { differ = false; for (linenr_T lnum = 1; lnum <= curbuf->b_ml.ml_line_count; lnum++) { - if (strcmp(ml_get_buf(buf, lnum, false), ml_get(lnum)) != 0) { + if (strcmp(ml_get_buf(buf, lnum), ml_get(lnum)) != 0) { differ = true; break; } |