aboutsummaryrefslogtreecommitdiff
path: root/src/nvim/diff.c
diff options
context:
space:
mode:
authorzeertzjq <zeertzjq@outlook.com>2022-07-25 20:06:24 +0800
committerzeertzjq <zeertzjq@outlook.com>2022-07-25 20:48:21 +0800
commit8543de3a862d55a762c130aa6a9d0e2a6c0b4838 (patch)
tree5c436051cfe8faef17347c532a17b344be1984b8 /src/nvim/diff.c
parent611b43369e73b0da799226f70a6821c0c31ca222 (diff)
downloadrneovim-8543de3a862d55a762c130aa6a9d0e2a6c0b4838.tar.gz
rneovim-8543de3a862d55a762c130aa6a9d0e2a6c0b4838.tar.bz2
rneovim-8543de3a862d55a762c130aa6a9d0e2a6c0b4838.zip
vim-patch:8.2.5163: crash when deleting buffers in diff mode
Problem: Crash when deleting buffers in diff mode. Solution: Recompute diffs later. Skip window without a valid buffer. https://github.com/vim/vim/commit/cd38bb4d83c942c4bad596835c6766cbf32e5195
Diffstat (limited to 'src/nvim/diff.c')
-rw-r--r--src/nvim/diff.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/src/nvim/diff.c b/src/nvim/diff.c
index 75021e90d6..136fc5402b 100644
--- a/src/nvim/diff.c
+++ b/src/nvim/diff.c
@@ -115,7 +115,10 @@ void diff_buf_delete(buf_T *buf)
tp->tp_diff_invalid = true;
if (tp == curtab) {
- diff_redraw(true);
+ // don't redraw right away, more might change or buffer state
+ // is invalid right now
+ need_diff_redraw = true;
+ redraw_later(curwin, VALID);
}
}
}
@@ -648,7 +651,8 @@ void diff_redraw(bool dofold)
need_diff_redraw = false;
FOR_ALL_WINDOWS_IN_TAB(wp, curtab) {
- if (!wp->w_p_diff) {
+ // when closing windows or wiping buffers skip invalid window
+ if (!wp->w_p_diff || !buf_valid(wp->w_buffer)) {
continue;
}
redraw_later(wp, SOME_VALID);