diff options
| author | Famiu Haque <famiuhaque@protonmail.com> | 2022-09-27 21:16:28 +0600 |
|---|---|---|
| committer | Famiu Haque <famiuhaque@protonmail.com> | 2022-09-28 09:29:43 +0600 |
| commit | 4b7904d16b11915b16ea46b96f1ea6e28d87d5fd (patch) | |
| tree | f57971615622d4ae3f6d289da8fcb6730f8a28f1 /src/nvim/eval.c | |
| parent | 1d337d4e2f2265b13ecf19a3bc17ad302d3b0d96 (diff) | |
| download | rneovim-4b7904d16b11915b16ea46b96f1ea6e28d87d5fd.tar.gz rneovim-4b7904d16b11915b16ea46b96f1ea6e28d87d5fd.tar.bz2 rneovim-4b7904d16b11915b16ea46b96f1ea6e28d87d5fd.zip | |
refactor: replace unnecessary helper functions in optionstr.c
Replaces unnecessary helper functions in `optionstr.c` such as
`get_option_flags()`, `get_option_fullname()`, `set_option_flag()`,
`is_global_option()`, etc. with a single `get_option()` helper function
that allows direct access to the `options` array.
Also refactors `f_exists()` to use `get_varp_scope` instead of using
`get_option_tv`. This opens up the path for removing `getoptions_T`
altogether later down the line since the hidden option logic is no
longer needed.
Diffstat (limited to 'src/nvim/eval.c')
| -rw-r--r-- | src/nvim/eval.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/nvim/eval.c b/src/nvim/eval.c index c2a7b6bba5..6eaf3d1f5e 100644 --- a/src/nvim/eval.c +++ b/src/nvim/eval.c @@ -3659,7 +3659,6 @@ static int eval_index(char **arg, typval_T *rettv, int evaluate, int verbose) int get_option_tv(const char **const arg, typval_T *const rettv, const bool evaluate) FUNC_ATTR_NONNULL_ARG(1) { - bool working = (**arg == '+'); // has("+option") int opt_flags; // Isolate the option name and find its value. @@ -3704,10 +3703,6 @@ int get_option_tv(const char **const arg, typval_T *const rettv, const bool eval rettv->v_type = VAR_STRING; rettv->vval.v_string = stringval; } - } else if (working && (opt_type == gov_hidden_bool - || opt_type == gov_hidden_number - || opt_type == gov_hidden_string)) { - ret = FAIL; } *option_end = c; // put back for error messages |