diff options
| author | zeertzjq <zeertzjq@outlook.com> | 2023-01-21 09:24:09 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-21 09:24:09 +0800 |
| commit | e86d2734a93e159d44df8132dee6b994e5922d18 (patch) | |
| tree | e8a3015ebc88d880f9e749a7e69fbcf0d8793037 /src/nvim/eval/executor.c | |
| parent | 1c16d0994d08f1a6c396bc46833d0bfdade29422 (diff) | |
| download | rneovim-e86d2734a93e159d44df8132dee6b994e5922d18.tar.gz rneovim-e86d2734a93e159d44df8132dee6b994e5922d18.tar.bz2 rneovim-e86d2734a93e159d44df8132dee6b994e5922d18.zip | |
refactor: use uint8_t for blobs and ga_append() (#21916)
A blob is used as a sequence of bytes and usually accessed individually,
not as as a NUL-terminuated string, so uint8_t should be better.
Not sure about ga_append(), but using uint8_t leads to fewer casts.
Diffstat (limited to 'src/nvim/eval/executor.c')
| -rw-r--r-- | src/nvim/eval/executor.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nvim/eval/executor.c b/src/nvim/eval/executor.c index 831c468288..9caea2fef1 100644 --- a/src/nvim/eval/executor.c +++ b/src/nvim/eval/executor.c @@ -51,7 +51,7 @@ int eexe_mod_op(typval_T *const tv1, const typval_T *const tv2, const char *cons blob_T *const b1 = tv1->vval.v_blob; blob_T *const b2 = tv2->vval.v_blob; for (int i = 0; i < tv_blob_len(b2); i++) { - ga_append(&b1->bv_ga, (char)tv_blob_get(b2, i)); + ga_append(&b1->bv_ga, tv_blob_get(b2, i)); } } return OK; |