'inccommand': rework

- Eliminate/isolate static/global variables
- Remove special-case parameter from buflist_new()
- Remove special-case ECMD_RESERVED_BUFNR
- To determine when u_undo_and_forget() should be done, check
  b_changedtick instead of a heuristic.
- use mb_string2cells() instead of strlen() to measure the :sub patterns
- call ml_close() before buf_clear_file(). Avoids leaks caught by ASan.

Original patch by:
  Robin Elrharbi-Fleury (Robinhola)
  Audrey Rayé (Adrey06)
  Philémon Hullot (DesbyP)
  Aymeric Collange (aym7)
  Clément Guyomard (Clement0)

1 files changed, 11 insertions, 14 deletions

diff --git a/src/nvim/ex_docmd.c b/src/nvim/ex_docmd.c
index d8b92e9ec0..30347cbe85 100644
--- a/src/nvim/ex_docmd.c
+++ b/src/nvim/ex_docmd.c
@@ -1248,7 +1248,7 @@ static char_u * do_one_cmd(char_u **cmdlinep,
   memset(&ea, 0, sizeof(ea));
   ea.line1 = 1;
   ea.line2 = 1;
-  ea.is_live = flags & DOCMD_LIVE_PREVIEW;
+  ea.is_live = flags & DOCMD_LIVE;
   ex_nesting_level++;
 
   /* When the last file has not been edited :q has to be typed twice. */
@@ -9652,25 +9652,22 @@ static void ex_terminal(exarg_T *eap)
 
 /// Check whether commandline starts with a live command
 ///
-/// @param[in] cmd_live Commandline to check. May start with a range.
+/// @param[in] cmd Commandline to check. May start with a range.
 ///
 /// @return True if first command is a live command
-///         Currently :s is the only one
-bool is_live(char_u *cmd_live)
+bool cmd_is_live(char_u *cmd)
 {
-  exarg_T ea;
-  ea.cmd = cmd_live;
+  if (cmd == NULL) {
+    return false;
+  }
 
+  exarg_T ea;
   // parse the command line
-  if (ea.cmd != NULL) {
-    ea.cmd = skip_range(ea.cmd, NULL);
-    if (*ea.cmd == '*') {
-      ea.cmd = skipwhite(ea.cmd + 1);
-    }
-    find_command(&ea, NULL);
-  } else {
-    return false;
+  ea.cmd = skip_range(cmd, NULL);
+  if (*ea.cmd == '*') {
+    ea.cmd = skipwhite(ea.cmd + 1);
   }
+  find_command(&ea, NULL);
 
   return (ea.cmdidx == CMD_substitute);
 }