diff options
| author | Eliseo Martínez <eliseomarmol@gmail.com> | 2014-11-10 00:03:47 +0100 |
|---|---|---|
| committer | Eliseo Martínez <eliseomarmol@gmail.com> | 2014-11-11 01:43:13 +0100 |
| commit | 4e02a1bf46995e784ea6f7688113a02a8dd3f8ed (patch) | |
| tree | 80971b55c1ec443acde47c43b6905e9ca754d9ef /src/nvim/fileio.c | |
| parent | 1002e3fe1ddb1d95c838197dc802c3b1ba094bd3 (diff) | |
| download | rneovim-4e02a1bf46995e784ea6f7688113a02a8dd3f8ed.tar.gz rneovim-4e02a1bf46995e784ea6f7688113a02a8dd3f8ed.tar.bz2 rneovim-4e02a1bf46995e784ea6f7688113a02a8dd3f8ed.zip | |
Fix warnings: fileio.c: readfile(): Dead assignment: HI.
Problem : Dead assignment @ 1754.
Diagnostic : Harmless issue.
Rationale : It's true `iconv_fd` is not going to be used again (we are
in the failure handler). But what is being done (assigning
sentinel value to mark as "empty" after destroying) is in
fact good practice, which could turn significant if more
code is added later on. So, we don't want to remove this.
Resolution : Leave it there, but exclude from analysis.
Diffstat (limited to 'src/nvim/fileio.c')
| -rw-r--r-- | src/nvim/fileio.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/nvim/fileio.c b/src/nvim/fileio.c index ecc05a9faa..16431d14c3 100644 --- a/src/nvim/fileio.c +++ b/src/nvim/fileio.c @@ -1751,7 +1751,9 @@ failed: # ifdef USE_ICONV if (iconv_fd != (iconv_t)-1) { iconv_close(iconv_fd); +# ifndef __clang_analyzer__ iconv_fd = (iconv_t)-1; +# endif } # endif |