diff options
| author | dundargoc <33953936+dundargoc@users.noreply.github.com> | 2023-02-02 23:56:25 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-02 23:56:25 +0100 |
| commit | ebd2372f928c6f1cfe823d36aabf479f6930232f (patch) | |
| tree | 277d19740498c2be4486df9bd8dd411b5b4547d1 /src/nvim/message.c | |
| parent | 0ea4156464c982f0451cd486e2152934c3dd2204 (diff) | |
| download | rneovim-ebd2372f928c6f1cfe823d36aabf479f6930232f.tar.gz rneovim-ebd2372f928c6f1cfe823d36aabf479f6930232f.tar.bz2 rneovim-ebd2372f928c6f1cfe823d36aabf479f6930232f.zip | |
refactor: use flexible arrays instead of the length-of-one trick (#22072)
The "length-of-one" trick, where the last element of a struct is an
array of size 1, but extra size is allocated when calling malloc where
it uses more than 1 element in the array, cause problems with some
compilers. Some compilers set _FORTIFY_SOURCE=2 by default which
incorrectly considers it as an overflow. More information:
https://github.com/neovim/neovim/issues/223#issuecomment-1413828554
Using flexible array members allows us to to properly convey to the
compiler that its size may be larger than 1. This also enables us to
remove lengthy workarounds that are unreliable, as they depend on
CMAKE_BUILD_TYPE which isn't defined for multi-config generators.
Closes: https://github.com/neovim/neovim/issues/223
Diffstat (limited to 'src/nvim/message.c')
| -rw-r--r-- | src/nvim/message.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/nvim/message.c b/src/nvim/message.c index 3b3dfcd5b6..40453211b4 100644 --- a/src/nvim/message.c +++ b/src/nvim/message.c @@ -64,7 +64,7 @@ struct msgchunk_S { char sb_eol; // true when line ends after this text int sb_msg_col; // column in which text starts int sb_attr; // text attributes - char sb_text[1]; // text to be displayed, actually longer + char sb_text[]; // text to be displayed }; // Magic chars used in confirm dialog strings |