ui: Replace cursor_{on,off} by busy_{stop,start}

Switching cursor off is only necessary in two occasions:

- When redrawing to avoid terminal flickering
- When the editor is busy

The first can now be handled by the TUI, so most calls to ui_cursor_off can be
removed from the core.

So, before this commit it was only necessary to switch the cursor off to notify
the user that nvim was running some long operation. Now the cursor_{on,off}
functions have been replaced by busy_{stop,start} which can be handled in a
UI-specific way(turning the cursor off or showing a busy indicator, for
example).

To make things even more simpler, nvim is always busy except when waiting for
user input or other asynchronous events: It automatically switches to a non-busy
state when the event loop is about to be entered for more than 100 milliseconds.

`ui_busy_start` can be called when its not desired to change the busy state in
the event loop (As its now done by functions that perform blocking shell
invocations).

1 files changed, 4 insertions, 1 deletions

diff --git a/src/nvim/os/shell.c b/src/nvim/os/shell.c
index 8cf7e7161d..290d6a9ec9 100644
--- a/src/nvim/os/shell.c
+++ b/src/nvim/os/shell.c
@@ -99,7 +99,6 @@ int os_call_shell(char_u *cmd, ShellOpts opts, char_u *extra_args)
   char *output = NULL, **output_ptr = NULL;
   int current_state = State;
   bool forward_output = true;
-  ui_flush();
 
   // While the child is running, ignore terminating signals
   signal_reject_deadly();
@@ -239,7 +238,11 @@ static int shell(const char *cmd,
     job_close_in(job);
   }
 
+  // invoke busy_start here so event_poll_until wont change the busy state for
+  // the UI
+  ui_busy_start();
   status = job_wait(job, -1);
+  ui_busy_stop();
 
   // prepare the out parameters if requested
   if (output) {