diff options
| author | Jan Edmund Lazo <janedmundlazo@hotmail.com> | 2018-09-08 11:19:55 -0400 |
|---|---|---|
| committer | Jan Edmund Lazo <janedmundlazo@hotmail.com> | 2018-09-08 11:31:24 -0400 |
| commit | 213a66441fb1b01ed30ed1beef4d1aa540549171 (patch) | |
| tree | a5a57875d02db45d1fce573350d8cba6c4bf7b62 /src/nvim/quickfix.c | |
| parent | 1790f81f56087e45f24e82fb8d5f99a9e0f59d49 (diff) | |
| download | rneovim-213a66441fb1b01ed30ed1beef4d1aa540549171.tar.gz rneovim-213a66441fb1b01ed30ed1beef4d1aa540549171.tar.bz2 rneovim-213a66441fb1b01ed30ed1beef4d1aa540549171.zip | |
vim-patch:8.0.1031: "text" argument for getqflist() is confusing
Problem: "text" argument for getqflist() is confusing. (Lcd47)
Solution: Use "lines" instead. (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/2c809b7c7d2bb5e4b7fd09c3d312cadecf0c1ff0
Diffstat (limited to 'src/nvim/quickfix.c')
| -rw-r--r-- | src/nvim/quickfix.c | 22 |
1 files changed, 8 insertions, 14 deletions
diff --git a/src/nvim/quickfix.c b/src/nvim/quickfix.c index ec11e5d849..5b701695fd 100644 --- a/src/nvim/quickfix.c +++ b/src/nvim/quickfix.c @@ -4122,15 +4122,12 @@ enum { }; // Parse text from 'di' and return the quickfix list items -static int qf_get_list_from_text(dictitem_T *di, dict_T *retdict) +static int qf_get_list_from_lines(dictitem_T *di, dict_T *retdict) { int status = FAIL; - // Only string and list values are supported - if ((di->di_tv.v_type == VAR_STRING - && di->di_tv.vval.v_string != NULL) - || (di->di_tv.v_type == VAR_LIST - && di->di_tv.vval.v_list != NULL)) { + // Only a List value is supported + if (di->di_tv.v_type == VAR_LIST && di->di_tv.vval.v_list != NULL) { list_T *l = tv_list_alloc(kListLenMayKnow); qf_info_T *qi = xmalloc(sizeof(*qi)); memset(qi, 0, sizeof(*qi)); @@ -4158,8 +4155,8 @@ int get_errorlist_properties(win_T *wp, dict_T *what, dict_T *retdict) qf_info_T *qi = &ql_info; dictitem_T *di; - if ((di = tv_dict_find(what, S_LEN("text"))) != NULL) { - return qf_get_list_from_text(di, retdict); + if ((di = tv_dict_find(what, S_LEN("lines"))) != NULL) { + return qf_get_list_from_lines(di, retdict); } if (wp != NULL) { @@ -4474,12 +4471,9 @@ static int qf_set_properties(qf_info_T *qi, dict_T *what, int action, } } - if ((di = tv_dict_find(what, S_LEN("text"))) != NULL) { - // Only string and list values are supported - if ((di->di_tv.v_type == VAR_STRING - && di->di_tv.vval.v_string != NULL) - || (di->di_tv.v_type == VAR_LIST - && di->di_tv.vval.v_list != NULL)) { + if ((di = tv_dict_find(what, S_LEN("lines"))) != NULL) { + // Only a List value is supported + if (di->di_tv.v_type == VAR_LIST && di->di_tv.vval.v_list != NULL) { if (action == 'r') { qf_free_items(qi, qf_idx); } |