Use abort() instead of assert(false) for things that should never happen

assert() is compiled out for release builds, but we don't want to
continue running in these impossible situations.

This also resolves the "implicit fallthrough" warnings for the asserts
in switch cases.

1 files changed, 1 insertions, 1 deletions

diff --git a/src/nvim/quickfix.c b/src/nvim/quickfix.c
index a625c09f78..d24d170a39 100644
--- a/src/nvim/quickfix.c
+++ b/src/nvim/quickfix.c
@@ -5648,7 +5648,7 @@ static int get_qfline_items(qfline_T *qfp, list_T *list)
           == FAIL)) {
     // tv_dict_add* fail only if key already exist, but this is a newly
     // allocated dictionary which is thus guaranteed to have no existing keys.
-    assert(false);
+    abort();
   }
 
   return OK;