diff options
| author | Eliseo Martínez <eliseomarmol@gmail.com> | 2014-11-04 15:41:46 +0100 |
|---|---|---|
| committer | Eliseo Martínez <eliseomarmol@gmail.com> | 2014-11-06 09:51:44 +0100 |
| commit | 336aab5eef68a493dcd1ddc2dfe6405b6ee7a0a9 (patch) | |
| tree | ce27d5eecc6a3865ce1b07bb0c80a95a62031b54 /src/nvim/regexp.c | |
| parent | 9de544c785aa11a9edf380bc8aeaabad75357aa9 (diff) | |
| download | rneovim-336aab5eef68a493dcd1ddc2dfe6405b6ee7a0a9.tar.gz rneovim-336aab5eef68a493dcd1ddc2dfe6405b6ee7a0a9.tar.bz2 rneovim-336aab5eef68a493dcd1ddc2dfe6405b6ee7a0a9.zip | |
Fix warnings: regexp.c: skip_regexp: Np dereference: FP.
Problem: Derefence of null pointer @ 1208.
http://neovim.org/doc/reports/clang/report-24b5ca.html#Path10
Diagnostic: False positive.
Rationale : Error is reported to happen if after `if (*newp == NULL) {`
body, `*newp` continues being NULL, and false branch of
following `if (*newp != NULL)` is taken. Now, `vim_strsave`
cannot return NULL, so error cannot happen.
Resolution: Remove dead code (leftover since OOM refactors).
Diffstat (limited to 'src/nvim/regexp.c')
| -rw-r--r-- | src/nvim/regexp.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/nvim/regexp.c b/src/nvim/regexp.c index 90da02bb1b..4e5ae403d6 100644 --- a/src/nvim/regexp.c +++ b/src/nvim/regexp.c @@ -1199,10 +1199,7 @@ char_u *skip_regexp(char_u *startp, int dirc, int magic, char_u **newp) *newp = vim_strsave(startp); p = *newp + (p - startp); } - if (*newp != NULL) - STRMOVE(p, p + 1); - else - ++p; + STRMOVE(p, p + 1); } else ++p; /* skip next character */ if (*p == 'v') |