test: simplify platform detection (#21020)

Extend the capabilities of is_os to detect more platforms such as
freebsd and openbsd. Also remove `iswin()` helper function as it can be
replaced by `is_os("win")`.

7 files changed, 22 insertions, 23 deletions

diff --git a/test/functional/legacy/011_autocommands_spec.lua b/test/functional/legacy/011_autocommands_spec.lua
index 0fa9290f3c..7ae851467f 100644
--- a/test/functional/legacy/011_autocommands_spec.lua
+++ b/test/functional/legacy/011_autocommands_spec.lua
@@ -18,11 +18,11 @@ local clear, feed_command, expect, eq, neq, dedent, write_file, feed =
   helpers.clear, helpers.feed_command, helpers.expect, helpers.eq, helpers.neq,
   helpers.dedent, helpers.write_file, helpers.feed
 local command = helpers.command
-local iswin = helpers.iswin
 local read_file = helpers.read_file
+local is_os = helpers.is_os
 
 local function has_gzip()
-  local null = iswin() and 'nul' or '/dev/null'
+  local null = is_os('win') and 'nul' or '/dev/null'
   return os.execute('gzip --help >' .. null .. ' 2>&1') == 0
 end
 
diff --git a/test/functional/legacy/025_jump_tag_hidden_spec.lua b/test/functional/legacy/025_jump_tag_hidden_spec.lua
index dd89a3680e..15bd56a601 100644
--- a/test/functional/legacy/025_jump_tag_hidden_spec.lua
+++ b/test/functional/legacy/025_jump_tag_hidden_spec.lua
@@ -23,7 +23,7 @@ describe('jump to a tag with hidden set', function()
     feed_command('set hidden')
 
     -- Create a link from test25.dir to the current directory.
-    if helpers.iswin() then
+    if helpers.is_os('win') then
       feed_command('!rd /q/s test25.dir')
       feed_command('!mklink /j test25.dir .')
     else
@@ -33,7 +33,7 @@ describe('jump to a tag with hidden set', function()
 
     -- Create tags.text, with the current directory name inserted.
     feed_command('/tags line')
-    feed_command('r !' .. (helpers.iswin() and 'cd' or 'pwd'))
+    feed_command('r !' .. (helpers.is_os('win') and 'cd' or 'pwd'))
     feed('d$/test<cr>')
     feed('hP:.w! tags.test<cr>')
 
@@ -44,7 +44,7 @@ describe('jump to a tag with hidden set', function()
     feed('G<C-]> x:yank a<cr>')
     feed_command("call delete('tags.test')")
     feed_command("call delete('Xxx')")
-    if helpers.iswin() then
+    if helpers.is_os('win') then
       feed_command('!rd /q test25.dir')
     else
       feed_command('!rm -f test25.dir')
diff --git a/test/functional/legacy/097_glob_path_spec.lua b/test/functional/legacy/097_glob_path_spec.lua
index dd5a26ad3b..a62dc4d4c8 100644
--- a/test/functional/legacy/097_glob_path_spec.lua
+++ b/test/functional/legacy/097_glob_path_spec.lua
@@ -10,7 +10,7 @@ describe('glob() and globpath()', function()
   setup(clear)
 
   setup(function()
-    if helpers.iswin() then
+    if helpers.is_os('win') then
       os.execute("md sautest\\autoload")
       os.execute(".>sautest\\autoload\\Test104.vim 2>nul")
       os.execute(".>sautest\\autoload\\footest.vim 2>nul")
@@ -28,7 +28,7 @@ describe('glob() and globpath()', function()
     -- Consistent sorting of file names
     command('set nofileignorecase')
 
-    if helpers.iswin() then
+    if helpers.is_os('win') then
       command([[$put =glob('Xxx{')]])
       command([[$put =glob('Xxx$')]])
 
@@ -72,7 +72,7 @@ describe('glob() and globpath()', function()
   end)
 
   teardown(function()
-    if helpers.iswin() then
+    if helpers.is_os('win') then
       os.execute('del /q/f Xxx{ Xxx$')
       os.execute('rd /q /s sautest')
     else
diff --git a/test/functional/legacy/delete_spec.lua b/test/functional/legacy/delete_spec.lua
index 4ba4c8d356..cefcd6c6c4 100644
--- a/test/functional/legacy/delete_spec.lua
+++ b/test/functional/legacy/delete_spec.lua
@@ -48,7 +48,7 @@ describe('Test for delete()', function()
 
   it('symlink directory delete', function()
     command("call mkdir('Xdir1')")
-    if helpers.iswin() then
+    if helpers.is_os('win') then
       command("silent !mklink /j Xlink Xdir1")
     else
       command("silent !ln -s Xdir1 Xlink")
diff --git a/test/functional/legacy/excmd_spec.lua b/test/functional/legacy/excmd_spec.lua
index ece88d26bd..eb480a6689 100644
--- a/test/functional/legacy/excmd_spec.lua
+++ b/test/functional/legacy/excmd_spec.lua
@@ -7,12 +7,12 @@ local exec_lua = helpers.exec_lua
 local expect_exit = helpers.expect_exit
 local feed = helpers.feed
 local funcs = helpers.funcs
-local iswin = helpers.iswin
 local meths = helpers.meths
 local read_file = helpers.read_file
 local source = helpers.source
 local eq = helpers.eq
 local write_file = helpers.write_file
+local is_os = helpers.is_os
 
 local function sizeoflong()
   if not exec_lua('return pcall(require, "ffi")') then
@@ -376,7 +376,7 @@ describe(':confirm command dialog', function()
       {3:(Y)es, [N]o: }^                                                              |
     ]])
     feed('Y')
-    if iswin() then
+    if is_os('win') then
       screen:expect([[
         foobar                                                                     |
         {0:~                                                                          }|
@@ -416,7 +416,7 @@ describe(':confirm command dialog', function()
       {3:(Y)es, [N]o: }^                                                              |
     ]])
     feed('Y')
-    if iswin() then
+    if is_os('win') then
       screen:expect([[
         foobar                                                                     |
         {1:                                                                           }|
@@ -493,7 +493,7 @@ describe(':confirm command dialog', function()
       {3:(Y)es, [N]o: }^                                                              |
     ]])
     feed('Y')
-    if iswin() then
+    if is_os('win') then
       screen:expect([[
         a                                                                          |
         b                                                                          |
diff --git a/test/functional/legacy/filechanged_spec.lua b/test/functional/legacy/filechanged_spec.lua
index 747eca1c45..cea1d6ac30 100644
--- a/test/functional/legacy/filechanged_spec.lua
+++ b/test/functional/legacy/filechanged_spec.lua
@@ -1,7 +1,7 @@
 local helpers = require('test.functional.helpers')(after_each)
 local clear, source = helpers.clear, helpers.source
 local call, eq, meths = helpers.call, helpers.eq, helpers.meths
-local iswin = helpers.iswin
+local is_os = helpers.is_os
 local skip = helpers.skip
 
 local function expected_empty()
@@ -17,7 +17,7 @@ describe('file changed dialog', function()
   end)
 
   it('works', function()
-    skip(iswin())
+    skip(is_os('win'))
     source([[
       func Test_file_changed_dialog()
         au! FileChangedShell
diff --git a/test/functional/legacy/memory_usage_spec.lua b/test/functional/legacy/memory_usage_spec.lua
index eec89aa919..8d9b28e1fc 100644
--- a/test/functional/legacy/memory_usage_spec.lua
+++ b/test/functional/legacy/memory_usage_spec.lua
@@ -3,15 +3,14 @@ local clear = helpers.clear
 local eval = helpers.eval
 local eq = helpers.eq
 local feed_command = helpers.feed_command
-local iswin = helpers.iswin
 local retry = helpers.retry
 local ok = helpers.ok
 local source = helpers.source
 local poke_eventloop = helpers.poke_eventloop
-local uname = helpers.uname
 local load_adjust = helpers.load_adjust
 local write_file = helpers.write_file
-local isCI = helpers.isCI
+local is_os = helpers.is_os
+local is_ci = helpers.is_ci
 
 local function isasan()
   local version = eval('execute("version")')
@@ -22,8 +21,8 @@ clear()
 if isasan() then
   pending('ASAN build is difficult to estimate memory usage', function() end)
   return
-elseif iswin() then
-  if isCI('github') then
+elseif is_os('win') then
+  if is_ci('github') then
     pending('Windows runners in Github Actions do not have a stable environment to estimate memory usage', function() end)
     return
   elseif eval("executable('wmic')") == 0 then
@@ -38,7 +37,7 @@ end
 local monitor_memory_usage = {
   memory_usage = function(self)
     local handle
-    if iswin() then
+    if is_os('win') then
       handle = io.popen('wmic process where processid=' ..self.pid..' get WorkingSetSize')
     else
       handle = io.popen('ps -o rss= -p '..self.pid)
@@ -169,7 +168,7 @@ describe('memory usage', function()
     -- Allow for 20% tolerance at the upper limit. That's very permissive, but
     -- otherwise the test fails sometimes.  On Sourcehut CI with FreeBSD we need to
     -- be even much more permissive.
-    local upper_multiplier = uname() == 'freebsd' and 19 or 12
+    local upper_multiplier = is_os('freebsd') and 19 or 12
     local lower = before.last * 8 / 10
     local upper = load_adjust((after.max + (after.last - before.last)) * upper_multiplier / 10)
     check_result({before=before, after=after, last=last},
@@ -179,7 +178,7 @@ describe('memory usage', function()
   end)
 
   it('releases memory when closing windows when folds exist', function()
-    if helpers.is_os('mac') then
+    if is_os('mac') then
       pending('macOS memory compression causes flakiness')
     end
     local pid = eval('getpid()')