test(diagnostic): add test case for signs

1 files changed, 20 insertions, 31 deletions

diff --git a/test/functional/lua/diagnostic_spec.lua b/test/functional/lua/diagnostic_spec.lua
index 9397af9d9f..45aa4915cd 100644
--- a/test/functional/lua/diagnostic_spec.lua
+++ b/test/functional/lua/diagnostic_spec.lua
@@ -874,6 +874,26 @@ describe('vim.diagnostic', function()
         return count_extmarks(diagnostic_bufnr, diagnostic_ns)
       ]])
     end)
+
+    it('sets signs', function()
+      local result = exec_lua [[
+        vim.diagnostic.config({
+          signs = true,
+        })
+
+        local diagnostics = {
+          make_error('Error', 1, 1, 1, 2),
+          make_warning('Warning', 3, 3, 3, 3),
+        }
+
+        vim.diagnostic.set(diagnostic_ns, diagnostic_bufnr, diagnostics)
+
+        return vim.fn.sign_getplaced(diagnostic_bufnr, {group = '*'})[1].signs
+      ]]
+
+      eq({2, 'DiagnosticSignError'}, {result[1].lnum, result[1].name})
+      eq({4, 'DiagnosticSignWarn'}, {result[2].lnum, result[2].name})
+    end)
   end)
 
   describe('show_line_diagnostics()', function()
@@ -995,37 +1015,6 @@ describe('vim.diagnostic', function()
     end)
   end)
 
-  describe('set_signs()', function()
-    -- TODO(tjdevries): Find out why signs are not displayed when set from Lua...??
-    pending('sets signs by default', function()
-      exec_lua [[
-        vim.diagnostic.config({
-          update_in_insert = true,
-          signs = true,
-        })
-
-        local diagnostics = {
-          make_error('Delayed Diagnostic', 1, 1, 1, 2),
-          make_error('Delayed Diagnostic', 3, 3, 3, 3),
-        }
-
-        vim.api.nvim_win_set_buf(0, diagnostic_bufnr)
-        vim.diagnostic.set(diagnostic_ns, diagnostic_bufnr, diagnostics)
-
-        vim.diagnostic._set_signs(diagnostic_ns, diagnostic_bufnr, diagnostics)
-        -- return vim.fn.sign_getplaced()
-      ]]
-
-      nvim("input", "o")
-      nvim("input", "<esc>")
-
-      -- TODO(tjdevries): Find a way to get the signs to display in the test...
-      eq(nil, exec_lua [[
-        return im.fn.sign_getplaced()[1].signs
-      ]])
-    end)
-  end)
-
   describe('setloclist()', function()
     it('sets diagnostics in lnum order', function()
       local loc_list = exec_lua [[