Merge #6214 from ZyX-I/split-eval'/isolated-unittests

Run all unit tests in separate processes

5 files changed, 119 insertions, 120 deletions

diff --git a/test/unit/eval/decode_spec.lua b/test/unit/eval/decode_spec.lua
index 742b754d8a..2d7597c0f4 100644
--- a/test/unit/eval/decode_spec.lua
+++ b/test/unit/eval/decode_spec.lua
@@ -1,4 +1,5 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
+local itp = helpers.gen_itp(it)
 
 local cimport = helpers.cimport
 local to_cstr = helpers.to_cstr
@@ -11,25 +12,11 @@ local decode = cimport('./src/nvim/eval/decode.h', './src/nvim/eval_defs.h',
                        './src/nvim/message.h')
 
 describe('json_decode_string()', function()
-  local saved_p_enc = nil
-
-  before_each(function()
-    saved_p_enc = decode.p_enc
-  end)
-
-  after_each(function()
-    decode.emsg_silent = 0
-    decode.p_enc = saved_p_enc
-    while decode.delete_first_msg() == 1 do
-      -- Delete all messages
-    end
-  end)
-
   local char = function(c)
     return ffi.gc(decode.xmemdup(c, 1), decode.xfree)
   end
 
-  it('does not overflow when running with `n…`, `t…`, `f…`', function()
+  itp('does not overflow when running with `n…`, `t…`, `f…`', function()
     local rettv = ffi.new('typval_T', {v_type=decode.VAR_UNKNOWN})
     decode.emsg_silent = 1
     -- This will not crash, but if `len` argument will be ignored it will parse
@@ -56,7 +43,7 @@ describe('json_decode_string()', function()
     eq(decode.VAR_UNKNOWN, rettv.v_type)
   end)
 
-  it('does not overflow and crash when running with `n`, `t`, `f`', function()
+  itp('does not overflow and crash when running with `n`, `t`, `f`', function()
     local rettv = ffi.new('typval_T', {v_type=decode.VAR_UNKNOWN})
     decode.emsg_silent = 1
     eq(0, decode.json_decode_string(char('n'), 1, rettv))
@@ -67,7 +54,7 @@ describe('json_decode_string()', function()
     eq(decode.VAR_UNKNOWN, rettv.v_type)
   end)
 
-  it('does not overflow when running with `"…`', function()
+  itp('does not overflow when running with `"…`', function()
     local rettv = ffi.new('typval_T', {v_type=decode.VAR_UNKNOWN})
     decode.emsg_silent = 1
     eq(0, decode.json_decode_string('"t"', 2, rettv))
@@ -84,7 +71,8 @@ describe('json_decode_string()', function()
     eq(msg, ffi.string(decode.last_msg_hist.msg))
   end
 
-  it('does not overflow in error messages', function()
+  itp('does not overflow in error messages', function()
+    local saved_p_enc = decode.p_enc
     check_failure(']test', 1, 'E474: No container to close: ]')
     check_failure('[}test', 2, 'E474: Closing list with curly bracket: }')
     check_failure('{]test', 2,
@@ -129,11 +117,11 @@ describe('json_decode_string()', function()
     check_failure('[1test', 2, 'E474: Unexpected end of input: [1')
   end)
 
-  it('does not overflow with `-`', function()
+  itp('does not overflow with `-`', function()
     check_failure('-0', 1, 'E474: Missing number after minus sign: -')
   end)
 
-  it('does not overflow and crash when running with `"`', function()
+  itp('does not overflow and crash when running with `"`', function()
     local rettv = ffi.new('typval_T', {v_type=decode.VAR_UNKNOWN})
     decode.emsg_silent = 1
     eq(0, decode.json_decode_string(char('"'), 1, rettv))
diff --git a/test/unit/eval/encode_spec.lua b/test/unit/eval/encode_spec.lua
index 98fc8305e0..058c55093e 100644
--- a/test/unit/eval/encode_spec.lua
+++ b/test/unit/eval/encode_spec.lua
@@ -1,4 +1,5 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
+local itp = helpers.gen_itp(it)
 local eval_helpers = require('test.unit.eval.helpers')
 
 local cimport = helpers.cimport
@@ -18,25 +19,25 @@ describe('encode_list_write()', function()
     return encode.encode_list_write(l, to_cstr(s), #s)
   end
 
-  it('writes empty string', function()
+  itp('writes empty string', function()
     local l = list()
     eq(0, encode_list_write(l, ''))
     eq({[type_key]=list_type}, lst2tbl(l))
   end)
 
-  it('writes ASCII string literal with printable characters', function()
+  itp('writes ASCII string literal with printable characters', function()
     local l = list()
     eq(0, encode_list_write(l, 'abc'))
     eq({'abc'}, lst2tbl(l))
   end)
 
-  it('writes string starting with NL', function()
+  itp('writes string starting with NL', function()
     local l = list()
     eq(0, encode_list_write(l, '\nabc'))
     eq({null_string, 'abc'}, lst2tbl(l))
   end)
 
-  it('writes string starting with NL twice', function()
+  itp('writes string starting with NL twice', function()
     local l = list()
     eq(0, encode_list_write(l, '\nabc'))
     eq({null_string, 'abc'}, lst2tbl(l))
@@ -44,13 +45,13 @@ describe('encode_list_write()', function()
     eq({null_string, 'abc', 'abc'}, lst2tbl(l))
   end)
 
-  it('writes string ending with NL', function()
+  itp('writes string ending with NL', function()
     local l = list()
     eq(0, encode_list_write(l, 'abc\n'))
     eq({'abc', null_string}, lst2tbl(l))
   end)
 
-  it('writes string ending with NL twice', function()
+  itp('writes string ending with NL twice', function()
     local l = list()
     eq(0, encode_list_write(l, 'abc\n'))
     eq({'abc', null_string}, lst2tbl(l))
@@ -58,7 +59,7 @@ describe('encode_list_write()', function()
     eq({'abc', 'abc', null_string}, lst2tbl(l))
   end)
 
-  it('writes string starting, ending and containing NL twice', function()
+  itp('writes string starting, ending and containing NL twice', function()
     local l = list()
     eq(0, encode_list_write(l, '\na\nb\n'))
     eq({null_string, 'a', 'b', null_string}, lst2tbl(l))
@@ -66,7 +67,7 @@ describe('encode_list_write()', function()
     eq({null_string, 'a', 'b', null_string, 'a', 'b', null_string}, lst2tbl(l))
   end)
 
-  it('writes string starting, ending and containing NUL with NL between twice', function()
+  itp('writes string starting, ending and containing NUL with NL between twice', function()
     local l = list()
     eq(0, encode_list_write(l, '\0\n\0\n\0'))
     eq({'\n', '\n', '\n'}, lst2tbl(l))
@@ -74,7 +75,7 @@ describe('encode_list_write()', function()
     eq({'\n', '\n', '\n\n', '\n', '\n'}, lst2tbl(l))
   end)
 
-  it('writes string starting, ending and containing NL with NUL between twice', function()
+  itp('writes string starting, ending and containing NL with NUL between twice', function()
     local l = list()
     eq(0, encode_list_write(l, '\n\0\n\0\n'))
     eq({null_string, '\n', '\n', null_string}, lst2tbl(l))
@@ -82,7 +83,7 @@ describe('encode_list_write()', function()
     eq({null_string, '\n', '\n', null_string, '\n', '\n', null_string}, lst2tbl(l))
   end)
 
-  it('writes string containing a single NL twice', function()
+  itp('writes string containing a single NL twice', function()
     local l = list()
     eq(0, encode_list_write(l, '\n'))
     eq({null_string, null_string}, lst2tbl(l))
@@ -90,7 +91,7 @@ describe('encode_list_write()', function()
     eq({null_string, null_string, null_string}, lst2tbl(l))
   end)
 
-  it('writes string containing a few NLs twice', function()
+  itp('writes string containing a few NLs twice', function()
     local l = list()
     eq(0, encode_list_write(l, '\n\n\n'))
     eq({null_string, null_string, null_string, null_string}, lst2tbl(l))
diff --git a/test/unit/eval/helpers.lua b/test/unit/eval/helpers.lua
index c3c27e4fed..1377d5b501 100644
--- a/test/unit/eval/helpers.lua
+++ b/test/unit/eval/helpers.lua
@@ -1,4 +1,4 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(nil)
 
 local cimport = helpers.cimport
 local to_cstr = helpers.to_cstr
@@ -46,12 +46,6 @@ local function list(...)
   return ret
 end
 
-local special_tab = {
-  [eval.kSpecialVarFalse] = false,
-  [eval.kSpecialVarNull] = nil_value,
-  [eval.kSpecialVarTrue] = true,
-}
-
 local ptr2key = function(ptr)
   return tostring(ptr)
 end
@@ -60,64 +54,74 @@ local lst2tbl
 local dct2tbl
 
 local typvalt2lua
-local typvalt2lua_tab
+local typvalt2lua_tab = nil
 
-typvalt2lua_tab = {
-  [tonumber(eval.VAR_SPECIAL)] = function(t)
-    return special_tab[t.vval.v_special]
-  end,
-  [tonumber(eval.VAR_NUMBER)] = function(t)
-    return {[type_key]=int_type, value=tonumber(t.vval.v_number)}
-  end,
-  [tonumber(eval.VAR_FLOAT)] = function(t)
-    return tonumber(t.vval.v_float)
-  end,
-  [tonumber(eval.VAR_STRING)] = function(t)
-    local str = t.vval.v_string
-    if str == nil then
-      return null_string
-    else
-      return ffi.string(str)
-    end
-  end,
-  [tonumber(eval.VAR_LIST)] = function(t, processed)
-    return lst2tbl(t.vval.v_list, processed)
-  end,
-  [tonumber(eval.VAR_DICT)] = function(t, processed)
-    return dct2tbl(t.vval.v_dict, processed)
-  end,
-  [tonumber(eval.VAR_FUNC)] = function(t, processed)
-    return {[type_key]=func_type, value=typvalt2lua_tab[eval.VAR_STRING](t, processed or {})}
-  end,
-  [tonumber(eval.VAR_PARTIAL)] = function(t, processed)
-    local p_key = ptr2key(t)
-    if processed[p_key] then
-      return processed[p_key]
-    end
-    local pt = t.vval.v_partial
-    local value, auto, dict, argv = nil, nil, nil, nil
-    if pt ~= nil then
-      value = ffi.string(pt.pt_name)
-      auto = pt.pt_auto and true or nil
-      argv = {}
-      for i = 1, pt.pt_argc do
-        argv[i] = typvalt2lua(pt.pt_argv[i - 1], processed)
+local function typvalt2lua_tab_init()
+  if typvalt2lua_tab then
+    return
+  end
+  typvalt2lua_tab = {
+    [tonumber(eval.VAR_SPECIAL)] = function(t)
+      return ({
+        [eval.kSpecialVarFalse] = false,
+        [eval.kSpecialVarNull] = nil_value,
+        [eval.kSpecialVarTrue] = true,
+      })[t.vval.v_special]
+    end,
+    [tonumber(eval.VAR_NUMBER)] = function(t)
+      return {[type_key]=int_type, value=tonumber(t.vval.v_number)}
+    end,
+    [tonumber(eval.VAR_FLOAT)] = function(t)
+      return tonumber(t.vval.v_float)
+    end,
+    [tonumber(eval.VAR_STRING)] = function(t)
+      local str = t.vval.v_string
+      if str == nil then
+        return null_string
+      else
+        return ffi.string(str)
       end
-      if pt.pt_dict ~= nil then
-        dict = dct2tbl(pt.pt_dict)
+    end,
+    [tonumber(eval.VAR_LIST)] = function(t, processed)
+      return lst2tbl(t.vval.v_list, processed)
+    end,
+    [tonumber(eval.VAR_DICT)] = function(t, processed)
+      return dct2tbl(t.vval.v_dict, processed)
+    end,
+    [tonumber(eval.VAR_FUNC)] = function(t, processed)
+      return {[type_key]=func_type, value=typvalt2lua_tab[eval.VAR_STRING](t, processed or {})}
+    end,
+    [tonumber(eval.VAR_PARTIAL)] = function(t, processed)
+      local p_key = ptr2key(t)
+      if processed[p_key] then
+        return processed[p_key]
       end
-    end
-    return {
-      [type_key]=func_type,
-      value=value,
-      auto=auto,
-      args=argv,
-      dict=dict,
-    }
-  end,
-}
+      local pt = t.vval.v_partial
+      local value, auto, dict, argv = nil, nil, nil, nil
+      if pt ~= nil then
+        value = ffi.string(pt.pt_name)
+        auto = pt.pt_auto and true or nil
+        argv = {}
+        for i = 1, pt.pt_argc do
+          argv[i] = typvalt2lua(pt.pt_argv[i - 1], processed)
+        end
+        if pt.pt_dict ~= nil then
+          dict = dct2tbl(pt.pt_dict)
+        end
+      end
+      return {
+        [type_key]=func_type,
+        value=value,
+        auto=auto,
+        args=argv,
+        dict=dict,
+      }
+    end,
+  }
+end
 
 typvalt2lua = function(t, processed)
+  typvalt2lua_tab_init()
   return ((typvalt2lua_tab[tonumber(t.v_type)] or function(t_inner)
     assert(false, 'Converting ' .. tonumber(t_inner.v_type) .. ' was not implemented yet')
   end)(t, processed or {}))
@@ -169,9 +173,10 @@ lst2tbl = function(l, processed)
   return ret
 end
 
-local hi_key_removed = eval._hash_key_removed()
+local hi_key_removed = nil
 
 local function dict_iter(d, return_hi)
+  hi_key_removed = hi_key_removed or eval._hash_key_removed()
   local init_s = {
     todo=d.dv_hashtab.ht_used,
     hi=d.dv_hashtab.ht_array,
@@ -320,25 +325,28 @@ local lua2typvalt_type_tab = {
   end,
 }
 
-local special_vals = {
-  [null_string] = {eval.VAR_STRING, {v_string=ffi.cast('char_u*', nil)}},
-  [null_list] = {eval.VAR_LIST, {v_list=ffi.cast('list_T*', nil)}},
-  [null_dict] = {eval.VAR_DICT, {v_dict=ffi.cast('dict_T*', nil)}},
-  [nil_value] = {eval.VAR_SPECIAL, {v_special=eval.kSpecialVarNull}},
-  [true] = {eval.VAR_SPECIAL, {v_special=eval.kSpecialVarTrue}},
-  [false] = {eval.VAR_SPECIAL, {v_special=eval.kSpecialVarFalse}},
-}
+local special_vals = nil
 
-for k, v in pairs(special_vals) do
-  local tmp = function(typ, vval)
-    special_vals[k] = function()
-      return typvalt(typ, vval)
+lua2typvalt = function(l, processed)
+  if not special_vals then
+    special_vals = {
+      [null_string] = {'VAR_STRING', {v_string=ffi.cast('char_u*', nil)}},
+      [null_list] = {'VAR_LIST', {v_list=ffi.cast('list_T*', nil)}},
+      [null_dict] = {'VAR_DICT', {v_dict=ffi.cast('dict_T*', nil)}},
+      [nil_value] = {'VAR_SPECIAL', {v_special=eval.kSpecialVarNull}},
+      [true] = {'VAR_SPECIAL', {v_special=eval.kSpecialVarTrue}},
+      [false] = {'VAR_SPECIAL', {v_special=eval.kSpecialVarFalse}},
+    }
+
+    for k, v in pairs(special_vals) do
+      local tmp = function(typ, vval)
+        special_vals[k] = function()
+          return typvalt(eval[typ], vval)
+        end
+      end
+      tmp(v[1], v[2])
     end
   end
-  tmp(v[1], v[2])
-end
-
-lua2typvalt = function(l, processed)
   processed = processed or {}
   if l == nil or l == nil_value then
     return special_vals[nil_value]()
@@ -360,7 +368,7 @@ lua2typvalt = function(l, processed)
     return typvalt(eval.VAR_STRING, {v_string=eval.xmemdupz(to_cstr(l), #l)})
   elseif type(l) == 'cdata' then
     local tv = typvalt(eval.VAR_UNKNOWN)
-    eval.tv_copy(l, tv)
+    eval.copy_tv(l, tv)
     return tv
   end
 end
diff --git a/test/unit/eval/tricks_spec.lua b/test/unit/eval/tricks_spec.lua
index 4c5184995c..ec79a9cad5 100644
--- a/test/unit/eval/tricks_spec.lua
+++ b/test/unit/eval/tricks_spec.lua
@@ -1,4 +1,5 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
+local itp = helpers.gen_itp(it)
 
 local cimport = helpers.cimport
 local to_cstr = helpers.to_cstr
@@ -15,7 +16,7 @@ local eval_expr = function(expr)
 end
 
 describe('NULL typval_T', function()
-  it('is produced by $XXX_UNEXISTENT_VAR_XXX', function()
+  itp('is produced by $XXX_UNEXISTENT_VAR_XXX', function()
     -- Required for various tests which need to check whether typval_T with NULL
     -- string works correctly. This test checks that unexistent environment
     -- variable produces NULL string, not that some specific environment
@@ -29,13 +30,13 @@ describe('NULL typval_T', function()
     eq(nil, rettv.vval.v_string)
   end)
 
-  it('is produced by v:_null_list', function()
+  itp('is produced by v:_null_list', function()
     local rettv = eval_expr('v:_null_list')
     eq(eval.VAR_LIST, rettv.v_type)
     eq(nil, rettv.vval.v_list)
   end)
 
-  it('is produced by v:_null_dict', function()
+  itp('is produced by v:_null_dict', function()
     local rettv = eval_expr('v:_null_dict')
     eq(eval.VAR_DICT, rettv.v_type)
     eq(nil, rettv.vval.v_dict)
diff --git a/test/unit/eval/tv_clear_spec.lua b/test/unit/eval/tv_clear_spec.lua
index 96eccdbd71..47d4661ad8 100644
--- a/test/unit/eval/tv_clear_spec.lua
+++ b/test/unit/eval/tv_clear_spec.lua
@@ -1,4 +1,5 @@
-local helpers = require('test.unit.helpers')
+local helpers = require('test.unit.helpers')(after_each)
+local itp = helpers.gen_itp(it)
 local eval_helpers = require('test.unit.eval.helpers')
 
 local alloc_log_new = helpers.alloc_log_new
@@ -26,7 +27,7 @@ after_each(function()
 end)
 
 describe('clear_tv()', function()
-  it('successfully frees all lists in [&l [1], *l, *l]', function()
+  itp('successfully frees all lists in [&l [1], *l, *l]', function()
     local l_inner = {1}
     local list = {l_inner, l_inner, l_inner}
     local list_tv = ffi.gc(lua2typvalt(list), nil)
@@ -53,7 +54,7 @@ describe('clear_tv()', function()
       a.freed(list_p),
     })
   end)
-  it('successfully frees all lists in [&l [], *l, *l]', function()
+  itp('successfully frees all lists in [&l [], *l, *l]', function()
     local l_inner = {[type_key]=list_type}
     local list = {l_inner, l_inner, l_inner}
     local list_tv = ffi.gc(lua2typvalt(list), nil)
@@ -77,7 +78,7 @@ describe('clear_tv()', function()
       a.freed(list_p),
     })
   end)
-  it('successfully frees all dictionaries in [&d {}, *d]', function()
+  itp('successfully frees all dictionaries in [&d {}, *d]', function()
     local d_inner = {}
     local list = {d_inner, d_inner}
     local list_tv = ffi.gc(lua2typvalt(list), nil)
@@ -99,7 +100,7 @@ describe('clear_tv()', function()
       a.freed(list_p),
     })
   end)
-  it('successfully frees all dictionaries in [&d {a: 1}, *d]', function()
+  itp('successfully frees all dictionaries in [&d {a: 1}, *d]', function()
     local d_inner = {a=1}
     local list = {d_inner, d_inner}
     local list_tv = ffi.gc(lua2typvalt(list), nil)