aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/nvim/terminal.c2
-rw-r--r--test/functional/terminal/buffer_spec.lua23
2 files changed, 25 insertions, 0 deletions
diff --git a/src/nvim/terminal.c b/src/nvim/terminal.c
index 8c08e98b5c..cec7fc84a5 100644
--- a/src/nvim/terminal.c
+++ b/src/nvim/terminal.c
@@ -240,6 +240,8 @@ Terminal *terminal_open(TerminalOptions opts)
set_option_value((uint8_t *)"relativenumber", false, NULL, OPT_LOCAL);
buf_set_term_title(curbuf, (char *)curbuf->b_ffname);
RESET_BINDING(curwin);
+ // Reset cursor in current window.
+ curwin->w_cursor = (pos_T){ .lnum = 1, .col = 0, .coladd = 0 };
// Apply TermOpen autocmds _before_ configuring the scrollback buffer.
apply_autocmds(EVENT_TERMOPEN, NULL, NULL, false, curbuf);
diff --git a/test/functional/terminal/buffer_spec.lua b/test/functional/terminal/buffer_spec.lua
index a75ec129e4..b61eef948d 100644
--- a/test/functional/terminal/buffer_spec.lua
+++ b/test/functional/terminal/buffer_spec.lua
@@ -4,6 +4,7 @@ local feed, clear, nvim = helpers.feed, helpers.clear, helpers.nvim
local wait = helpers.wait
local eval, execute, source = helpers.eval, helpers.execute, helpers.source
local eq, neq = helpers.eq, helpers.neq
+local write_file = helpers.write_file
if helpers.pending_win32(pending) then return end
@@ -207,3 +208,25 @@ describe('terminal buffer', function()
end)
end)
+describe('No heap-buffer-overflow when using', function()
+
+ local testfilename = 'Xtestfile-functional-terminal-buffers_spec'
+
+ before_each(function()
+ write_file(testfilename, "aaaaaaaaaaaaaaaaaaaaaaaaaaaa")
+ end)
+
+ after_each(function()
+ os.remove(testfilename)
+ end)
+
+ it('termopen(echo) #3161', function()
+ execute('edit ' .. testfilename)
+ -- Move cursor away from the beginning of the line
+ feed('$')
+ -- Let termopen() modify the buffer
+ execute('call termopen("echo")')
+ wait()
+ execute('bdelete!')
+ end)
+end)