aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Fix warnings: window.c: close_last_window_tabpage(): Use after free: RI.Eliseo Martínez2015-02-21
| | | | | | | | | | | | | Problem : Use after free @ 1795. Diagnostic : Real issue. Rationale : prev_curtab can in fact be freed as a result of call `win_close_othertab(win, free_buf, prev_curtab);`, but it's later used at `sprintf(..., tabpage_index(prev_curtab));`. This was introduced at 3ffc5d81c34cfdd535573a50790690c88e4324bb. Resolution : Move prev_idx calculation before the call freeing prev_curtab.
* Fix warnings: screen.c: screen_puts_len(): Various (4): FP/MI.Eliseo Martínez2015-02-21
| | | | | | | | | | | | | | | | Problems : Assigned value is garbage or undefined @ 5363. Result of operation is garbage or undefined @ 5356. Result of operation is garbage or undefined @ 5320. Result of operation is garbage or undefined @ 5192. Diagnostic : False positives / Multithreading issues. Rationale : Suggested error paths contain incoherent values for has_mbyte, enc_utf8, and enc_dbcs, which should always hold the relationship has_mbyte = enc_utf8 || enc_dbcs, with enc_utf8 and enc_dbcs being mutually exclusive. Asserting on the globals, though, fails, because checker believes they could be modified by other threads in between. Resolution : Make local copy of globals and assert relationship on them.
* Merge PR #1997 'Remove term modules'Thiago de Arruda2015-02-21
|\
| * tui: Use unibi_format instead of unibi_runThiago de Arruda2015-02-21
| | | | | | | | | | | | | | | | The current will segfault for large chunks of output because the output buffer will be overrun. Using unibi_format is simple because we can simply flush the buffer when its full.
| * tui: Remove option cacheThiago de Arruda2015-02-21
| |
| * tui: Set setaf/setab capabilities for TERM=xtermThiago de Arruda2015-02-21
| | | | | | | | | | Many common terminals that set TERM=xterm and $COLORTERM support 256 colors. If this is detected, use force the hardcoded xterm's setaf/setab capabilities.
| * refactor: Remove term modules and termcap optionsThiago de Arruda2015-02-21
|/ | | | | | | | | | | | | | | - Removed term.c, term.h and term_defs.h - Tests for T_* values were removed. screen.c was simplified as a consequence(the best strategy for drawing is implemented in the UI layer) - Redraw functions now call ui.c functions directly. Updates are flushed with `ui_flush()` - Removed all termcap options(they now return empty strings for compatibility) - &term/&ttybuiltin options return a constant value(nvim) - &t_Co is still available, but it mirrors t_colors directly - Remove cursor tracking from screen.c and the `screen_start` function. Now the UI is expected to maintain cursor state across any call, and reset it when resized. - Remove unused code
* Merge PR #2032 'Some test fixes'Thiago de Arruda2015-02-21
|\
| * test: Add extra screen expectation to prevent race conditionThiago de Arruda2015-02-20
| | | | | | | | | | This is to ensure ctrl+c is only pressed after the command has started executing in the viml_system_spec.lua system() interrupt test.
| * test: Remove temporary files created by 072_undo_file_spec.luaThiago de Arruda2015-02-20
| |
| * test: Remove -g flag from pynvim call in Screen.debugThiago de Arruda2015-02-20
|/ | | | The flag is no longer valid(pynvim always starts a GUI)
* Merge #1983: Fix coverity issues. (5)Eliseo Martínez2015-02-20
|\
| * coverity/13746: Negative array index write: FP.Eliseo Martínez2015-02-20
| | | | | | | | | | | | | | | | Problem : Negative array index write @ 1042. Diagnostic : False positive. Rationale : Suggested error path cannot occur: idx should be >= 0, as previous check ensures there's a matching while/for. Resolution : Assert idx >= 0.
| * coverity/13683: Out-of-bounds access: RI.Eliseo Martínez2015-02-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Out-of-bounds access @ 3730. Diagnostic : Real issue. Rationale : str is constructed step by step, str_l growing each time. str_m is the maximum length of str. So, at every step, avail is computed to see if the piece to be added fits in. If not, piece is truncated to a max of `avail`, so that str stays in bounds. Such blocks where pieces are added are of the form `if (str_l < str_m)`. It then follows that once one of those pieces exhausts available space on str, no other such block should be entered. Formally: str_l < strl_m && avail = str_m - str_l && x >= avail --> str_l + x >= str_m Now, suggested error path successively enters blocks where str is exhausted. We're not sure if coverity just fails to follow above implications, or, on the contrary, it's aware of them, but it's signaling the more complex possibility of implications not being fulfilled because of possible arithmetic overflows. We opt then to assume this last case, as the possibility is in fact there. Resolution : Refactor code so that tracked condition doesn't depend on arithmetic implications. Check for overflow.
| * coverity/72768: Negative array index read: FP.Eliseo Martínez2015-02-20
|/ | | | | | | | | | | Problem : Negative array index read @ 5674. Diagnostic : False positive. Rationale : Problem occurs if for loop does not find any match, which implies shl->lnum == 0, and then we enter the `if (shl->lnum == lnum)` branch, which implies lnum == 0 as well. That's not possible, as function should not be called with lnum == 0. Resolution : Change conditions `shl->lnum == lnum` into `bot != -1`.
* Merge PR #1993 'legacy test: migrate test 72'Thiago de Arruda2015-02-20
|\
| * legacy test: migrate test 72Fabian Brosda2015-02-20
|/
* Merge PR #2025 'More fixes to the new TUI'Thiago de Arruda2015-02-20
|\
| * tui: Don't use 'timeout' for determining esc timeoutThiago de Arruda2015-02-20
| |
| * tui: Set default color attributes when scrollingThiago de Arruda2015-02-20
| | | | | | | | | | This is necessary for some terminals, or else they will clear/insert lines with wrong background color
| * tui: Fix terminfo extension indexesThiago de Arruda2015-02-20
| | | | | | | | | | For unibilium extension indexes, use signed integer type initialized with -1 to distinguish from the first extension string which will always have index 0.
| * tui: Replace uv_tty_t by uv_pipe_tThiago de Arruda2015-02-20
| | | | | | | | | | It seems uv_tty_t doesn't work properly on OSX(it is set to blocking mode, which causes UV_RUN_NOWAIT to misbehave).
| * tui: Only send the pastetoggle key if necessaryThiago de Arruda2015-02-20
|/
* Merge pull request #2022 from jszakmeister/update-msgpack-for-freebsd-fixJohn Szakmeister2015-02-20
|\ | | | | Update message pack to include the FreeBSD and OpenBSD byteswap fix.
| * Update message pack to include the FreeBSD and OpenBSD byteswap fix.John Szakmeister2015-02-19
| |
* | vim-patch:7.4.525 #1988Fabian Brosda2015-02-19
| | | | | | | | | | | | | | Problem: map() leaks memory when there is an error in the expression. Solution: Call clear_tv(). (Christian Brabandt) https://code.google.com/p/vim/source/detail?r=v7-4-525
* | Merge pull request #1964 from jszakmeister/fix-bashism-in-fs-spec-testJohn Szakmeister2015-02-19
|\ \ | |/ |/| Get rid of a bashism in the fs_spec test.
| * Get rid of a bashism in the fs_spec test.John Szakmeister2015-02-09
| | | | | | | | | | FreeBSD doesn't use bash by default, causing the group id to be print out in the middle of the test.
* | Merge #1979 'Enable -Wconversion'Justin M. Keyes2015-02-18
|\ \
| * | Enable -Wconversion: os_unix.c.Eliseo Martínez2015-02-18
| | |
| * | Enable -Wconversion: keymap.c.Eliseo Martínez2015-02-18
| | |
| * | Enable -Wconversion: indent.c.Eliseo Martínez2015-02-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Note: Clint was failing because of recommending not to use long. But converting to long is the proper refactoring here, in as far as other longs exist. We could, then, disable clint rule, or remove this file from checking. We choose the former, as it's being discussed what to do with longs, but a decision has not been taken. So, it seems most reasonable to allow longs for now, to enable proper refactorings, and then, when a decision is taken, refactor all longs to some other thing.
| * | Enable -Wconversion: mark.c.Eliseo Martínez2015-02-18
| | | | | | | | | | | | | | | | | | Refactoring summary: - MB_STRNICMP: Inlined. - MB_STRNCMP: Inlined.
| * | Enable -Wconversion: Passing-by: Remove dead code (MACOS_CONVERT).Eliseo Martínez2015-02-18
| | | | | | | | | | | | MacOS (pre Mac OS X) is not supported anymore.
| * | Enable -Wconversion: ui.c.Eliseo Martínez2015-02-18
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactoring summary: - ui_write(): len: int --> size_t * parse_abstract_ui_codes(): len: int --> size_t * string_convert(): lenp: int * --> size_t * - string_convert_ext(): lenp : int * --> size_t * unconvlenp: int * --> size_t * * utf8len_tab_zero: char[] --> uint8_t[] * iconv_string(): slen : int --> size_t unconvlenp: int * --> size_t * resultlenp: int * --> size_t * - mch_print_text_out(): len: int --> size_t * out_pos: int --> size_t
* | Merge PR #2007 'Fixes for the new TUI'Thiago de Arruda2015-02-18
|\ \
| * | input: Escape utf8 sequences that contain CSI/K_SPECIALThiago de Arruda2015-02-18
| | |
| * | tui: Remove support for overriding escape sequences with nvim optionsThiago de Arruda2015-02-18
| | | | | | | | | | | | | | | | | | | | | - Add xterm/iterm sequences for changing cursor shape(with tmux wrapping). Enabled by setting the NVIM_TUI_ENABLE_CURSOR_SHAPE environment variable. - Remove nvim_override parameter from unibi_out. In the future another way of overriding the terminal strings will be added.
| * | tui: Fix use after free(reported by clang static analyzer)Thiago de Arruda2015-02-18
| | |
| * | tui: Add support bracketed pasteThiago de Arruda2015-02-18
| | | | | | | | | | | | | | | Inspired by the vim-bracketed-paste plugin but adapted for the new TUI. Also initialize some variables of type `Error` that were uninitialized
| * | tui: Fix to_status_line terminfo sequence for xtermThiago de Arruda2015-02-17
| | | | | | | | | | | | | | | Moving the cursor to the status line(to set the title) requires a different sequence for xterm than the one used by urxvt.
| * | tui: Fix background clear for some terminalsThiago de Arruda2015-02-17
|/ / | | | | | | | | Some terminals will perform clearing functions using the current attributes. Ensure the default attributes are set before clearing.
* | fix rebase hiccup #1911Justin M. Keyes2015-02-17
| |
* | Merge #1717 'TabNew, TabNewEntered, TabClosed'Justin M. Keyes2015-02-16
|\ \
| * | Add TabClosed eventFelipe Morales2015-02-16
| | | | | | | | | | | | TabClosed is triggered when a tab page closes.
| * | Add TabNewEnteredFelipe Morales2015-02-16
| | | | | | | | | | | | TabNewEntered is triggered after vim has entered a buffer in new tab.
| * | Add TabNew eventFelipe Morales2015-02-16
|/ / | | | | | | | | TabNew triggers when entering a new tab page, but not when entering an already created one.
* | Merge PR #1820 'Reimplement builtin terminal UI with termkey/unibilium'Thiago de Arruda2015-02-16
|\ \
| * | test: Fix 051_highlight_spec.luaThiago de Arruda2015-02-16
| | | | | | | | | | | | | | | | | | - The syntax `gui=` is invalid when setting properties of highlight group. - Wait for the initial "-- More --" prompt before continuing. Required to avoid a race condition
| * | cleanup: Remove unused functions and builtin termcapsThiago de Arruda2015-02-16
| | |
generated by cgit (git 2.34.1) at 2025-09-25 23:19:32 +0000