aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* doc: update msgpack_rpc documentation to use nvim as variable name #1470James Baumgarten2014-11-17
|
* Merge pull request #1485 from equalsraf/tb-no-make-prgJohn Szakmeister2014-11-17
|\ | | | | Use cmake --build inside CMake scripts instead of calling Make directly
| * Use cmake --build instead of MakeRui Abreu Ferreira2014-11-14
| | | | | | | | | | | | | | - If possble try to abstract away from Make, and use cmake --build - third-party still needs to find Make to build some components - Removed search for Make from CMakeLists.txt * for CMake < 3.0 --build has no color output
* | Merge pull request #1157 from fwalch/remove-coverityJustin M. Keyes2014-11-16
|\ \ | | | | | | Travis: Remove Coverity build.
| * | Travis: Remove Coverity build.Florian Walch2014-11-16
| | | | | | | | | | | | Coverity is now handled by neovim/bot-ci.
* | | Merge pull request #1483 from ↵Justin M. Keyes2014-11-16
|\ \ \ | | | | | | | | | | | | | | | | oni-link/fix.mch_print_begin.memory.leak.stackversion coverity/13765,13766,13767,13768: Fix memory leaks in hardcopy.c
| * | | coverity/13765,13766,13767,13768: Fix memory leaks in hardcopy.coni-link2014-11-16
| |/ / | | | | | | | | | | | | | | | | | | | | | The function mch_print_begin() returns early in case of an error, but without freeing allocated memory. To fix this, use stack allocation instead of heap allocation for the variables res_prolog, res_encoding, res_cidfont and res_cmap.
* | | Merge pull request #1479 from Pyrohh/fix_comments_and_use_stdboolJustin M. Keyes2014-11-16
|\ \ \ | |/ / |/| | {farsi.c,arabic.c}: Fix comments and use stdbool
| * | arabic.c: Comment fixesMichael Reed2014-11-15
| | | | | | | | | | | | | | | - Use C99 style comments everywhere - Fix incorrect references to return values
| * | farsi.c: Misc. fixesMichael Reed2014-11-15
|/ / | | | | | | | | | | - Converted some functions to return bools, and changed their respective comments to reflect that. - Minor fixes to a few comments
* | Merge pull request #1471 from splinterofchaos/fix-jobstartJustin M. Keyes2014-11-15
|\ \ | | | | | | jobstart: Check prg arguments for NULL.
| * | jobstart: Check prg arguments for NULL.Scott Prager2014-11-13
| | |
* | | Merge pull request #1460 from elmart/clang-analysis-fixes-3Justin M. Keyes2014-11-15
|\ \ \ | | | | | | | | Fix clang analysis warnings. (3)
| * | | Fix warnings: charset.c: win_lbr_chartabsize(): Dead assignment: HI.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Dead assignment @ 1037. Diagnostic : Harmless issue. Rationale : `tab_corr` is in effect unused after signaled point. Previous code using it after that point was removed at 24ebb018e28187c61900b1616e4f79fec9d70878. Resolution : Remove dead assignment. As only one usage remains, remove variable and inline the only usage.
| * | | Fix warnings: undo.c: u_blockfree(): Use after free: FP.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Use-after-free @ 2686. Diagnostic : False positive. Rationale : Suggested error path is taking false branch `uhp->uh_next.ptr != NULL` @ 2506, which cannot happen when `uhp == buf->b_u_oldhead`. Resolution : Assert `buf->b_u_oldhead` is changed after freeing old one.
| * | | Fix warnings: syntax.c: get_id_list(): Double free: FP.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Double free @ 5213. Diagnostic : False positive. Rationale : Suggested error path contains two consecutive invocations of `ends_excmd(*p)` having different results, which is not possible. First invocation is before the while loop. Second invocation is the while loop condition itsef. Resolution : Refactor while loop into do-while loop. That removes the impossible path from analysis, and, in addition, is a bit more efficient.
| * | | Fix warnings: syntax.c: syn_regexec(): Uninitialized arg: MI.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Uninitialized argument value @ 2863. Diagnostic : Multithreading issue. Rationale : Error can only occur if global `syn_time_on` is changed while the function is executing. Resolution : Use local copy of gloval var.
| * | | Fix warnings: spell.c: spell_edit_score(): Garbage value: MI.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Assigned value is garbage or undefined @ 12526. Diagnostic : Multithreading issue. Rationale : Error only occurs if global has_mbyte is modified while function is executing. Resolution : Use local copy of global.
| * | | Fix warnings: spell.c: getroom(): Np dereference: FP/RI.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Dereference of null pointer @ 6089. Diagnostic : False positive / Real issue. Rationale : From the code, it seems the intent is that len parameter should never exceed SBLOCKSIZE. But the code checking for that does in fact cause a null pointer dereference just immediately after. Resolution : State precondition in doc and assert it at entry.
| * | | Fix warnings: spell.c: store_aff_word(): Garbage value: RI.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Result of operation is garbage or undefined @ 5809. Diagnostic : Real issue. Rationale : When copying flags, first access to `use_pfxlist[use_pfxlen]` was garbage if `spin->si_compflags` was null. Resolution : Make sure `use_pfxlist[use_pfxlen]` always has a value (NUL if `spin->si_compflags` is NULL).
| * | | Fix warnings: spell.c: spell_read_aff(): Uninitialized arg: RI.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Uninitialized argument value @ 4469. Diagnostic : Real issue. Rationale : Happens when a line contains a spell info item (NAME, HOME, VERSION, AUTHOR, EMAIL, COPYRIGHT), which expect a second item, but then the second item is not present. Resolution : Add guard (item count > 1) to failing branch.
| * | | Fix warnings: spell.c: spell_move_to(): Garbage value: RI.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Result of operation is garbage or undefined @ 2238. Diagnostic : Real issue. Rationale : Problem occurs when searching forward starting on an empty line. This is, at 2127: ``` p = buf + skip; endp = buf + len; while (p < endp) { ``` when skip == 0, len == 0, implying p == endp and therefore not entering the loop. Under those conditions, comparison ``` if (attr == HLF_COUNT) ``` at line 2242 is really using a garbage value for `attr`. Most of the time the error doesn't produce visible problems as it only affects when dealing with wrapped words. Resolution : Initialize `attr` at declaration to `HLF_COUNT`, which is used in the code when no bad word found yet.
| * | | Fix warnings: spell.c: spell_move_to(): Null arg: FP.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Argument with 'nonnull' attribute passed null @ 2118. Diagnostic : False positive. Rationale : Error happens when `if (buflen < len + MAXWLEN + 2) {` is not entered on the first iteration, which cannot happen because buflen is 0 on the first iteration, so the condition should always hold. Resolution : Assert existence of buffer with appropiate length after conditional (which prevents previous error path).
| * | | Fix warnings: spell.c: find_word(): Dead assignment: HI.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Dead assignment @ 1602. Diagnostic : Harmless issue. Rationale : Code using this assignment (line 1666) was disabled. Vim's tip at Wed Nov 12 13:07:54 2014 +0100 (changeset 6352:2f7bf5f90f57) hasn't changed this yet. Resolution : Disable assignment. Directive processors are used for that in order to match the way the other code was disabled.
| * | | Fix warnings: search.c: find_pattern_in_path(): Np dereference: MI.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Dereference of null pointer @ 4395. Diagnostic : Multithreading issue. Rationale : Problem occurs only if global g_do_tagpreview changed while funcion is executing. Resolution : Use local copy of global var.
| * | | Fix warnings: regexp_nfa.c: nfa_regatom(): Dead assignment: HI.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Dead assignment @ 1554. Diagnostic : Harmless issue. Rationale : `result` is used when analyzing if a bracketed expresion `[<whatever>]` can be condensed into a character class. Not used for anything else anywhere. So, it's safe to remove. Resolution : Remove dead assingment and move declaration of `result` to the scope where it's used.
| * | | Fix warnings: quickfix.c: qf_add_entry(): Np dereference: FP.Eliseo Martínez2014-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Dereference of null pointer @ 921. Diagnostic : False positive. Rationale : If `qi->qf_lists[qi->qf_curlist].qf_count == 0` doesn't hold, we should be calling function with nonnull `*prevp`. Resolution : Assert nonnull.
| * | | Fix warnings: option.c: do_set(): Dead assignment: HI.Eliseo Martínez2014-11-15
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem : Dead assignment @ 2566. Diagnostic : Harmless issue. Rationale : `nextchar` is used as a lookahead buffer for the character next to the currently examined token. Sometimes it also saves that char while original string is modified (original position of nextchar is nullified for the string to terminate there). In summary, it's an auxiliary variable with no particular complex meaning. Safe to remove if not used. Resolution : Remove dead assignment.
* | | Update README.mdJustin M. Keyes2014-11-14
| | |
* | | Update README.mdJustin M. Keyes2014-11-14
| | |
* | | vim-patch:7.4.378 #1217André Twupack2014-11-14
| | | | | | | | | | | | | | | | | | | | | Problem: Title of quickfist list is not kept for setqflist(list, 'r'). Solution: Keep the title. Add a test. (Lcd) https://code.google.com/p/vim/source/detail?r=v7-4-378
* | | Merge pull request #1473 from alexgenco/patch-1Justin M. Keyes2014-11-14
|\ \ \ | | | | | | | | Fix api metadata function name in docs
| * | | Fix api metadata function name in docsAlex Genco2014-11-13
|/ / / | | | | | | The documentation mentions `vim_get_api_metadata`, but the actual function is `vim_get_api_info`
* | | Merge #1322 'vim-patch:7.4.421 + vim-patch:7.4.437'Justin M. Keyes2014-11-13
|\ \ \
| * | | vim-patch:7.4.437Scott Prager2014-11-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: New and old regexp engine are not consistent. Solution: Also give an error for "\ze*" for the old regexp engine. https://code.google.com/p/vim/source/detail?r=v7-4-437
| * | | vim-patch:7.4.421Scott Prager2014-11-13
|/ / / | | | | | | | | | | | | | | | | | | Problem: Crash when searching for "\ze*". (Urtica Dioica) Solution: Disallow a multi after \ze and \zs. https://code.google.com/p/vim/source/detail?r=v7-4-421
* | | Merge pull request #1283 from splinterofchaos/breakindent-tabJustin M. Keyes2014-11-12
|\ \ \ | | | | | | | | vim-patch:7.4.416 + vim-patch:7.4.417
| * | | vim-patch:7.4.417Scott Prager2014-11-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: After splitting a window and setting 'breakindent' the default minimum with is not respected. Solution: Call briopt_check() when copying options to a new window. https://code.google.com/p/vim/source/detail?r=v7-4-417
| * | | vim-patch:7.4.416Scott Prager2014-11-11
| |/ / | | | | | | | | | | | | | | | | | | Problem: Problem with breakindent/showbreak and tabs. Solution: Handle tabs differently. (Christian Brabandt) https://code.google.com/p/vim/source/detail?name=v7-4-416
* | | Merge pull request #1345 from war1025/dev/wininfo_boolsJustin M. Keyes2014-11-12
|\ \ \ | |_|/ |/| | Convert some values into bools
| * | Convert some values from buffer_defs.h to boolsWayne Rowcliffe2014-11-12
|/ /
* | Merge pull request #1320 from splinterofchaos/ll-lockJustin M. Keyes2014-11-11
|\ \ | |/ |/| vim-patch:7.4.419
| * vim-patch:7.4.419Scott Prager2014-11-11
| | | | | | | | | | | | | | | | Problem: Whan part of a list is locked it's possible to make changes. Solution: Check if any of the list items is locked before make a change. (ZyX) https://code.google.com/p/vim/source/detail?r=v7-4-419
* | Merge pull request #1282 from splinterofchaos/cmd-undefJustin M. Keyes2014-11-11
|\ \ | | | | | | vim-patch:7.4.414 + vim-patch:7.4.415
| * | vim-patch:7.4.415Scott Prager2014-11-11
| | | | | | | | | | | | | | | | | | | | | Problem: Cannot build. Warning for shadowed variable. (John Little) Solution: Add missing change. Remove declaration. https://code.google.com/p/vim/source/detail?name=v7-4-414&r=20dbceb6f4713ccd01be45dc531abc269fbb7579
| * | vim-patch:7.4.414Scott Prager2014-11-11
| | | | | | | | | | | | | | | | | | | | | | | | Problem: Cannot define a command only when it's used. Solution: Add the CmdUndefined autocommand event. (partly by Yasuhiro Matsumoto) https://code.google.com/p/vim/source/detail?r=v7-4-414
| * | Fix fileio.c's diagram.Scott Prager2014-11-11
| |/
* | Merge pull request #923 from splinterofchaos/normal-boolJustin M. Keyes2014-11-11
|\ \ | |/ |/| Use bool in normal.h and .c.
| * normal.c: Replace last TRUE/FALSE/OK/FAIL's w/bool.Scott Prager2014-11-11
| |
| * Use bool in signatures of functions in normal.h.Scott Prager2014-11-11
| | | | | | | | | | | | | | | | | | | | Return bool from checkclearop, checkclearopq, add_to_showcmd, find_decl, nv_screengo, get_visual_text, and unadjust_for_sel as these functions all return either TRUE or FALSE or OK or FAIL, but not MAYBE. Change to arguments toplevel of normal_cmd, check of do_check_scrollbind, and locally and thisblock of finddecl, to bools as they represent predicates.
generated by cgit (git 2.34.1) at 2025-05-30 13:27:07 +0000