| Commit message (Collapse) | Author | Age |
... | |
| | | | | |
|
| |/ / /
| | | |
| | | |
| | | | |
Uncrustify is the source of truth where possible.
See also https://github.com/neovim/neovim/pull/18563
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Problem:
1. The main log routine does not protect itself against recursion.
log_lock() doesn't guard against recursion, it would deadlock...
2. 22b52dd462e5 (#11501) regressed 6f27f5ef91b3 (#10172), because
set_init_1..process_spawn tries to log (see backtrace below), but the
mutex isn't initialized yet. Even if the mutex were valid, we don't
want early logging to fallback to stderr because that can break
embedders when stdio is used for RPC.
frame 1: 0x00000001001d54f4 nvim`open_log_file at log.c:205:7
frame 2: 0x00000001001d5390 nvim`logmsg(log_level=1, context="UI: ", func_name=0x0000000000000000, line_num=-1, eol=true, fmt="win_viewport") at log.c:150:20
frame : 0x000000010039aea2 nvim`ui_call_win_viewport(grid=2, win=1000, topline=0, botline=1, curline=0, curcol=0, line_count=1) at ui_events_call.generated.h:321:3
frame 4: 0x00000001003dfefc nvim`ui_ext_win_viewport(wp=0x0000000101816400) at window.c:939:5
frame 5: 0x00000001003ec5b4 nvim`win_ui_flush at window.c:7303:7
frame 6: 0x00000001003a04c0 nvim`ui_flush at ui.c:508:3
frame 7: 0x00000001002966ba nvim`do_os_system(argv=0x0000600000c0c000, input=0x0000000000000000, len=0, output=0x0000000000000000, nread=0x00007ff7bfefe830, silent=false, forward_output=false) at shell.c:894:3
frame 8: 0x0000000100295f68 nvim`os_call_shell(cmd="unset nonomatch; vimglob() { while [ $# -ge 1 ]; do echo \"$1\"; shift; done }; vimglob >/var/folders/gk/3tttv_md06987tlwpyp62jrw0000gn/T/nvimwwvwfD/0 ~foo", opts=kShellOptExpand | kShellOptSilent | kShellOptHideMess, extra_args=0x0000000000000000) at shell.c:663:18
frame 9: 0x0000000100295845 nvim`call_shell(cmd="unset nonomatch; vimglob() { while [ $# -ge 1 ]; do echo \"$1\"; shift; done }; vimglob >/var/folders/gk/3tttv_md06987tlwpyp62jrw0000gn/T/nvimwwvwfD/0 ~foo", opts=kShellOptExpand | kShellOptSilent | kShellOptHideMess, extra_shell_arg=0x0000000000000000) at shell.c:712:14
frame 10: 0x0000000100294c6f nvim`os_expand_wildcards(num_pat=1, pat=0x00007ff7bfefeb20, num_file=0x00007ff7bfefee58, file=0x00007ff7bfefee60, flags=43) at shell.c:328:7
...
frame 23: 0x000000010028ccef nvim`expand_env_esc(srcp=",~foo", dst="~foo", dstlen=4094, esc=false, one=false, prefix=0x0000000000000000) at env.c:673:17
frame 24: 0x000000010026fdd5 nvim`option_expand(opt_idx=29, val=",~foo") at option.c:1950:3
frame 25: 0x000000010026f129 nvim`set_init_1(clean_arg=false) at option.c:558:19
frame 26: 0x00000001001ea25e nvim`early_init(paramp=0x00007ff7bfeff5f0) at main.c:198:3
frame 27: 0x00000001001ea6bf nvim`main(argc=1, argv=0x00007ff7bfeff848) at main.c:255:3
Solution:
1. Check for recursion, show "internal error" message.
- FUTURE: when "remote TUI" is merged, can we remove log_lock()?
2. Skip logging if log_init wasn't called yet.
|
| |\ \ \
| | | | |
| | | | | |
refactor(api): use hashy hash for looking up api method and event names
|
| | |/ /
| | | |
| | | |
| | | |
| | | | |
This avoids generating khash tables at runtime, and is consistent with
how evalfuncs lookup work.
|
| |/ /
| | |
| | |
| | |
| | | |
PPIndentWidth
The number of columns to use for indentation of preprocessor statements.
When set to -1 (default) IndentWidth is used also for preprocessor statements.
|
| |\ \
| | | |
| | | | |
ci(api-docs): run in drafts as well
|
| | | |
| | | |
| | | |
| | | |
| | | | |
A contributor should be able to be sure their PR passes the CI before
clicking "Ready for review".
|
| |\ \ \
| | | | |
| | | | | |
feat(api): pass structured modifiers to commands
|
| | | |/
| | |/|
| | | |
| | | |
| | | |
| | | |
| | | | |
Adds an `smods` key to `nvim_create_user_command` Lua command callbacks,
which has command modifiers but in a structured format. This removes the
need to manually parse command modifiers. It also reduces friction in
using `nvim_cmd` inside a Lua command callback.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
This will make it possible to see what needs to be fixed without having
uncrustify installed locally.
|
| | |/
| |/|
| | |
| | |
| | | |
Problem: Cursor position may be invalid after "0;" range.
Solution: Check the cursor position when it was set by ";" in the range.
https://github.com/vim/vim/commit/4d97a565ae8be0d4debba04ebd2ac3e75a0c8010
|
| |\ \
| | | |
| | | | |
ci: use ubuntu-latest for vim-patches and coverity-scan
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
Since we're not running tests or other things that are more sensitive to
changes in the VM environment, use ubuntu-latest to avoid the busy work
of updating the VM image.
|
| | |
| | |
| | |
| | |
| | | |
The async nature of feed_command caused a race condition on the calls
to delete, leaving the files on the root of the repo. Just use os.remove
and no need to wipeout.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In scripts/vim-patch.sh line 335:
printf '
^-- SC2183 (warning): This format string has 4 variables, but is passed 3 arguments.
In scripts/vim-patch.sh line 597:
list_missing_vimpatches 1 "$@" | while read -r vim_commit; do
^--------^ SC2030 (info): Modification of vim_commit is local (to subshell caused by pipeline)
In scripts/vim-patch.sh line 626:
done < <(git -C "${VIM_SOURCE_DIR}" diff-tree --no-commit-id --name-only -r "${vim_commit}" -- . ':!src/version.c')
^-----------^ SC2031 (info): vim_commit was modified in a subshell. That change might be lost.
For more information:
https://www.shellcheck.net/wiki/SC2183 -- This format string has 4 variable...
https://www.shellcheck.net/wiki/SC2030 -- Modification of vim_commit is loc...
https://www.shellcheck.net/wiki/SC2031 -- vim_commit was modified in a subs...
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
Previously the `offset!` directive populated the metadata in such a way
that the new range could be attributed to a specific capture. #14046
made it so the directive simply stored just the new range in the
metadata and information about what capture the range is based from is
lost.
This change reverts that whilst also correcting the docs.
|
| | |
|
| |\
| | |
| | | |
fix(winbar): only allow adding winbar when there is space
|
| | | |
|
| |/
| |
| |
| | |
It's more consistent to gather all removed options in one spot rather
than spreading it out.
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Previously, there was a bug where setting the local value of 'winbar' to
itself would cause winbar to appear on a floating window, which is
undesirable. This fix makes it so that it's explicitly required for the
window-local value of 'winbar' for a floating window to be set in order
for winbar to be shown on that window.
|
| |
| |
| |
| |
| | |
Problem: Using freed memory with "]d".
Solution: Copy the pattern before searching.
https://github.com/vim/vim/commit/e2fa213cf571041dbd04ab0329303ffdc980678a
|
| |\
| | |
| | | |
feat(lua): allow some viml functions to run in fast
|
| | |
| | |
| | | |
Co-authored-by: Justin M. Keyes <justinkz@gmail.com>
|
| | |
| | |
| | |
| | |
| | | |
This change adds the necessary plumbing to annotate functions in funcs.c
as being allowed in run in luv fast events.
|
| |\ \
| | | |
| | | | |
refactor(normal): convert function comments to doxygen format
|
| | | | |
|
| |/ /
| | |
| | | |
Same as https://github.com/neovim/neovim/pull/18458 but for rename
|
| | |
| | |
| | | |
related vim-8.2.{4402,4639}
|
| |\ \
| | | |
| | | | |
vim-patch:8.2.5010: the terminal debugger uses various global variables
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Problem: The terminal debugger uses various global variables.
Solution: Add a dictionary to hold the terminal debugger preferences.
https://github.com/vim/vim/commit/c9a431c7638ecebb6f2cb3eabd0e1b2b5e269c1e
Omit popup menu.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
https://github.com/vim/vim/commit/388a5d4f20b4b64341d1604aa238cab85827b892
https://github.com/vim/vim/commit/4466ad6baa22485abb1147aca3340cced4778a66
https://github.com/vim/vim/commit/6aa57295cfbe8f21c15f0671e45fd53cf990d404
Rename terminal.txt to nvim_terminal_emulator.txt in vim-patch.sh.
|
| |/ /
| | |
| | |
| | |
| | | |
Problem: Hoon and Moonscript files are not recognized.
Solution: Add filetype patterns. (Goc Dundar, closes vim/vim#10478)
https://github.com/vim/vim/commit/bf82df0dd48a26404b92a596498b6892c9572c53
|
| |\ \
| | | |
| | | | |
ci(mingw): only enable -municode for MinGW
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When enabling -municode for MSVC the following warning shows up:
"LINK : warning LNK4044: unrecognized option '/municode'; ignored".
This will ensure cleaner logs for the MSVC job.
|
| |/ /
| | |
| | |
| | |
| | | |
Problem: Access before start of text with a put command.
Solution: Check the length is more than zero.
https://github.com/vim/vim/commit/2a585c85013be22f59f184d49612074fd9b115d7
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
The client state is cleaned up both in client.stop() as well as in the
client.on_exit() handler. Technically, the client has not actually
stopped until the on_exit handler is called, so we should just do this
cleanup there and remove it from client.stop().
|
| | |
| | |
| | |
| | |
| | | |
This makes the common use case easier.
If one really needs access to all clients, they can create a filter
function which manually calls `get_active_clients`.
|
| | | |
|
| |\ \
| | | |
| | | | |
feat(api): add `win` and `buf` to `nvim_set_option_value`
|
| | |/
| | |
| | |
| | | |
Co-authored-by: Gregory Anders <8965202+gpanders@users.noreply.github.com>
|