aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge #7839 'coverity fixes'Justin M. Keyes2018-01-15
|\
| * coverity/161216: get_user_input: RETURN_LOCALJustin M. Keyes2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | *** CID 161216: Memory - illegal accesses (RETURN_LOCAL) /src/nvim/eval.c: 11143 in get_user_input() 11137 rettv->vval.v_string = 11138 (char_u *)getcmdline_prompt(inputsecret_flag ? NUL : '@', p, echo_attr, 11139 xp_type, xp_arg, input_callback); 11140 ex_normal_busy = save_ex_normal_busy; 11141 callback_free(&input_callback); 11142 >>> CID 161216: Memory - illegal accesses (RETURN_LOCAL) >>> Using "cancelreturn", which points to an out-of-scope variable "def". 11143 if (rettv->vval.v_string == NULL && cancelreturn != NULL) { 11144 rettv->vval.v_string = (char_u *)xstrdup(cancelreturn); 11145 } 11146 11147 xfree(xp_arg); 11148
| * coverity/169163: decode_string: Null pointer derefJustin M. Keyes2018-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | *** CID 169163: Null pointer dereferences (FORWARD_NULL) /src/nvim/eval/decode.c: 290 in decode_string() 284 if (elw_ret == -1) { 285 tv_clear(&tv); 286 return (typval_T) { .v_type = VAR_UNKNOWN, .v_lock = VAR_UNLOCKED }; 287 } 288 return tv; 289 } else { >>> CID 169163: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "s" to "xmemdupz", which dereferences it. (The dereference is assumed on the basis of the 'nonnull' parameter attribute.) 290 return (typval_T) { 291 .v_type = VAR_STRING, 292 .v_lock = VAR_UNLOCKED, 293 .vval = { .v_string = (char_u *)( 294 s_allocated ? (char *)s : xmemdupz(s, len)) }, 295 };
* | Merge #7855 from ckelsel/vim-8.0.0398Justin M. Keyes2018-01-15
|\ \
| * | vim-patch:8.0.0421: diff mode wrong when adding line at end of bufferckelsel2018-01-15
| | | | | | | | | | | | | | | | | | | | | | | | Problem: Diff mode is displayed wrong when adding a line at the end of a buffer. Solution: Adjust marks in diff mode. (James McCoy, closes vim/vim#1329) https://github.com/vim/vim/commit/f58a8475e17bd566760fc7e2a17d35ddf4edacf2
| * | vim-patch:8.0.0402: :map completion does not have <special>ckelsel2018-01-15
| | | | | | | | | | | | | | | | | | | | | Problem: :map completion does not have <special>. (Dominique Pelle) Solution: Recognize <special> in completion. Add a test. https://github.com/vim/vim/commit/cf5fdf7d1689ecb145b634dcb9c6e9fc60f63869
| * | vim-patch:8.0.0398: illegal memory access with "t"ckelsel2018-01-15
| | | | | | | | | | | | | | | | | | | | | Problem: Illegal memory access with "t". Solution: Use strncmp() instead of memcmp(). (Dominique Pelle, closes vim/vim#1528) https://github.com/vim/vim/commit/66727e16079fbac6db3897b5c3736ec9fba995bb
* | | tutor: don't resize (#7854)Felipe Morales2018-01-15
| | |
* | | Fix an off-by-one error in the documentation of nvim_buf_clear_highlight (#7853)mkotha2018-01-15
| | |
* | | man.lua: avoid float conversion on lua 5.3 (#7851)Filip SzymaƄski2018-01-15
|/ / | | | | | | | | Error detected while processing function man#open_page[58]..<SNR>54_put_page: line 8: E5105: Error while calling lua chunk: /usr/share/nvim/runtime/lua/man.lua:165: Vim(let):E805: Using a Float as a Number
* / vim-patch:8.0.0364 (#7837)KunMing Xie2018-01-13
|/ | | | | | | | | | | | | | vim-patch:8.0.0364: ]s does not move cursor with two spell errors in one line Problem: ]s does not move cursor with two spell errors in one line. (Manuel Ortega) Solution: Don't stop search immediately when wrapped, search the line first. (Ken Takata) Add a test. https://github.com/vim/vim/commit/d3f78dc9ebd729475a7f24a50a91112e300d5ac9 * disable spell test for now
* Merge #7821 'api: nvim_command_output'Justin M. Keyes2018-01-11
|\
| * api: nvim_command_output: direct implJustin M. Keyes2018-01-10
| |
| * api: change nvim_command_output behaviorJustin M. Keyes2018-01-10
|/ | | | | | | | | | | | | | | | | | | Implement nvim_command_output with `execute({cmd},"silent")`. Behavior changes: - does not provoke any hit-enter prompt - no longer prepends a newline char - does not capture some noise (like the "[New File]" message, see the change to tabnewentered_spec.lua) Technically ("bug-for-bug") this a breaking change. But the previous behavior of nvim_command_output meant that it probably wasn't used for anything outside of tests. Also remove the undocumented `v:command_output` variable which was a hack introduced only for the purposes of nvim_command_output. closes #7726
* ci/travis: require "sudo" for ASAN_UBSAN buildJustin M. Keyes2018-01-10
| | | | | | | | | | | | Workaround for this fun new issue: ==27404==LeakSanitizer has encountered a fatal error. ==27404==HINT: For debugging, try setting environment variable LSAN_OPTIONS=verbosity=1:log_threads=1 ==27404==HINT: LeakSanitizer does not work under ptrace (strace, gdb, etc) Failed: E /build|logs :: Runtime errors detected. https://github.com/travis-ci/travis-ci/issues/9033 https://github.com/google/sanitizers/issues/764
* cmake: install *.lua filesJustin M. Keyes2018-01-09
|
* Merge #7623 'man.vim: highlight bold, underlined text'Justin M. Keyes2018-01-09
|\
| * Address PR commentsGabriel Holodak2017-12-27
| |
| * Add functional tests for man highlightingGabriel Holodak2017-12-27
| |
| * Add support for escape sequencesGabriel Holodak2017-12-27
| |
| * Switch to processing in LuaGabriel Holodak2017-12-27
| |
| * Highlight backspaced charactersGabriel Holodak2017-12-27
| |
* | Merge #7826 from ckelsel/vim-8.0.0351Justin M. Keyes2018-01-08
|\ \
| * | vim-patch:8.0.0352: not easy to see when a typval needs to be clearedckelsel2018-01-08
| | | | | | | | | | | | | | | | | | | | | | | | Problem: The condition for when a typval needs to be cleared is too complicated. Solution: Init the type to VAR_UNKNOWN and clear it always. https://github.com/vim/vim/commit/f06e5a549f42396be3478ccc1b5f03be64e1173e
| * | vim-patch:8.0.0351: no test for concatenating an empty stringckelsel2018-01-08
|/ / | | | | | | | | | | | | | | Problem: No test for concatenating an empty string that results from out of bounds indexing. Solution: Add a simple test. https://github.com/vim/vim/commit/218426896cbb2129aa4e85803ea97c5b57df1eaa
* | ci/travis: install neovim npm module on osx (#7825)Jan Edmund Lazo2018-01-08
| | | | | | Always get latest nvm on osx to fix lts aliases.
* | Merge #7820 'ci/travis/macOS: skip ruby gem install'Justin M. Keyes2018-01-07
|\ \
| * | ci/travis: macOS: skip ruby-neovim installJustin M. Keyes2018-01-07
| | | | | | | | | | | | | | | | | | | | | With 6fa0a0a516f3 the neovim-ruby gem installs successfully, but ruby_spec.lua can't find it: g:ruby_host_prog needs to be set correctly. Just skip the whole thing for now, so that CI builds don't fail.
| * | ci/travis: macOS: switch ruby versionJustin M. Keyes2018-01-07
| | | | | | | | | | | | | | | Travis macOS builds are failing because of neovim-ruby gem dependencies. Switch default ruby to a newer version to make the builds pass.
* | | test: set_shell_powershell(): update flags (#7819)Justin M. Keyes2018-01-07
|/ /
* | Merge #7753 'win: enable more functional tests'Justin M. Keyes2018-01-06
|\ \
| * | test: win: yes is unavailable on WindowsJan Edmund Lazo2018-01-06
| | |
| * | win: test: check non-shell system()Jan Edmund Lazo2018-01-06
| | |
| * | test: use unix fileformat to test NULs on systemlistJan Edmund Lazo2018-01-06
| | |
| * | win: enable more functional testsJan Edmund Lazo2018-01-06
| | | | | | | | | | | | | | | | | | - plugin/shada_spec.lua: Use \r\n as Windows EOL for tests on BufWriteCmd, FileWriteCmd, FileAppendCmd. Alternative is 'set fileformat=unix'.
| * | win: enable tests in ex_terminal_specJan Edmund Lazo2018-01-06
| | |
| * | test: enable K_spec tests in WindowsJan Edmund Lazo2018-01-03
| | |
* | | version.c: update [ci skip] (#7780)Marvim the Paranoid Android2018-01-06
| | |
* | | third-party: revert to jemalloc 4.5.0Justin M. Keyes2018-01-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ref #7746 closes #7808 jemalloc-5.0.1 broke the Ubuntu Unstable PPA builds on arm64: https://launchpadlibrarian.net/351647411/buildlog_ubuntu-artful-arm64.neovim_0.2.0ubuntu1+git201712291800+3837+26~ubuntu17.10.1_BUILDING.txt.gz). make[5]: Entering directory '/<<BUILDDIR>>/neovim-0.2.0ubuntu1+git201712291800+3837+26~ubuntu17.10.1/build' Segmentation fault (core dumped) runtime/CMakeFiles/vimball-tags.dir/build.make:57: recipe for target 'runtime/CMakeFiles/vimball-tags' failed make[5]: *** [runtime/CMakeFiles/vimball-tags] Error 139 make[5]: Leaving directory '/<<BUILDDIR>>/neovim-0.2.0ubuntu1+git201712291800+3837+26~ubuntu17.10.1/build' CMakeFiles/Makefile2:7467: recipe for target 'runtime/CMakeFiles/vimball-tags.dir/all' failed jemalloc bug: https://github.com/jemalloc/jemalloc/issues/979
* | | tests: stderr output contains `cp` noiseJustin M. Keyes2018-01-05
| | | | | | | | | | | | closes #7811
* | | defaults: do :filetype stuff unless explicitly "off"Justin M. Keyes2018-01-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Until now, the default `:filetype ...` setup was skipped if the user config touched `:filetype` in any way (including implicitly via `:syntax on`). No one needs that, and it's very confusing. Instead, proceed with `:filetype ... on` unless the user explicitly called `:filetype ... off`. closes #7765
* | | Merge #7805 'eval.c: fix some scan-build warnings'Justin M. Keyes2018-01-03
|\ \ \
| * | | Add null check when adding variable to dict.Paul Rigge2018-01-02
| | | |
| * | | Add null pointer assertions for do_unlet_var.Paul Rigge2018-01-02
| | | |
| * | | Refactor profiling check in call_user_func.Paul Rigge2018-01-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | do_profiling is a global variable, and as such the clang static analyzer has trouble making arguments about it. This commit does one comparison against do_profiling and puts the result in a local variable. This prevents errors from the value of do_profiling changing between comparisons.
| * | | Add assertions for watchersPaul Rigge2018-01-02
| | | | | | | | | | | | | | | | | | | | | | | | The clang static analyzer convinced itself lp->ll_newkey could be NULL. This adds an assertion that checks this doesn't actually happen, as well as a parallel assertion for di->di_key.
| * | | Add another const to tv_copyPaul Rigge2018-01-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clang static analyzer had trouble with filter_map in eval.c because tv_copy could, in principle, change the v_type of argvars[0]. It saw a potential null pointer going somewhere it shouldn't as a result. The from argument in tv_copy should be const, which also cleans up the static analyzer's complaint.
| * | | Add assertion in set_var_lval for null pointer.Paul Rigge2018-01-02
| | | | | | | | | | | | | | | | If the lval is a index into a list, li should not be null.
* | | | vim-patch:8.0.0955: Test_existent_file() fails on some file systemsJustin M. Keyes2018-01-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: Test_existent_file() fails on some file systems. Solution: Run the test again with a sleep when the test fails without a sleep. (James McCoy, closes vim/vim#1984) https://github.com/vim/vim/commit/82de3c2c036bc89c2d9bdea236e0a7f1208a5571
* | | | Merge #7801 'tutor: adjust for 80 columns'Justin M. Keyes2018-01-03
|\ \ \ \