aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* fix(api): use original LHS in keymap error message #33135Gregory Anders2025-03-29
| | | | | | | | | | | | When setting a keymap with "unique" that already exists the error message contains the LHS of the keymap with termcodes replaced. In particular this means that keys like <Tab> show as an actual tab character, meaning the error message displays as "Mapping already exists for ", which is hard to debug for users. Instead, display the original LHS (without any simplification or parsed termcodes). This rperesents exactly what the user passed to the `lhs` argument of `nvim_set_keymap`, which makes it easier to find where the offending keymap is.
* vim-patch:9.1.1258: regexp: max \U and \%U value is limited by INT_MAX (#33156)zeertzjq2025-03-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: regexp: max \U and \%U value is limited by INT_MAX but gives a confusing error message (related: v8.1.0985). Solution: give a better error message when the value reaches INT_MAX When searching Vim allows to get up to 8 hex characters using the /\V and /\%V regex atoms. However, when using "/\UFFFFFFFF" the code point is already above what an integer variable can hold, which is 2,147,483,647. Since patch v8.1.0985, Vim already limited the max codepoint to INT_MAX (otherwise it caused a crash in the nfa regex engine), but instead of error'ing out it silently fell back to parse the number as a backslash value and not as a codepoint value and as such this "/[\UFFFFFFFF]" will happily find a "\" or an literal "F". And this "/[\d127-\UFFFFFFFF]" will error out as "reverse range in character class). Interestingly, the max Unicode codepoint value is U+10FFFF which still fits into an ordinary integer value, which means, that we don't even need to parse 8 hex characters, but 6 should have been enough. However, let's not limit Vim to search for only max 6 hex characters (which would be a backward incompatible change), but instead allow all 8 characters and only if the codepoint reaches INT_MAX, give a more precise error message (about what the max unicode codepoint value is). This allows to search for "[\U7FFFFFFE]" (will likely return "E486 Pattern not found") and "[/\U7FFFFFF]" now errors "E1517: Value too large, max Unicode codepoint is U+10FFFF". While this change is straight forward on architectures where long is 8 bytes, this is not so simple on Windows or 32bit architectures where long is 4 bytes (and therefore the test fails there). To account for that, let's make use of the vimlong_T number type and make a few corresponding changes in the regex engine code and cast the value to the expected data type. This however may not work correctly on systems that doesn't have the long long datatype (e.g. OpenVMS) and probably the test will fail there. fixes: vim/vim#16949 closes: vim/vim#16994 https://github.com/vim/vim/commit/f2b16986a194ab839c5a23bd7fe904f9fae1526f Co-authored-by: Christian Brabandt <cb@256bit.org>
* fix(checkhealth): don't override user "q" keymap #33132phanium2025-03-29
|
* fix: remove exec permission from .gitattributes #33140Ricardo Casía2025-03-29
| | | | | | | | Problem: .gitattributes was marked as executable, which isn’t needed for a config file and goes against the principle of least privilege. Solution: Set file mode to 100644 to reflect its intended use.
* refactor(diff): remove unreachable code (#33149)zeertzjq2025-03-29
|
* fix(pum): fix heap-buffer-overflow with 'rightleft' (#33146)zeertzjq2025-03-29
|
* vim-patch:9.1.1252: typos in code and docs related to 'diffopt' "inline:" ↵zeertzjq2025-03-29
| | | | | | | | | | | | (#33143) Problem: Typos in code and docs related to 'diffopt' "inline:". (after v9.1.1243) Solution: Fix typos and slightly improve the docs. (zeertzjq) closes: vim/vim#16997 https://github.com/vim/vim/commit/5a307c361cbe9f7ac438a917b905378d87f8f2de
* fix(cmdline): avoid empty @: register after :<CR> (#33126)luukvbaal2025-03-28
| | | Fix https://github.com/neovim/neovim/issues/33125
* fix(lsp): warn on missing config in :checkhealth #33087Micah Halter2025-03-28
| | | | | | | | | | | Problem When calling `:checkhealth vim.lsp` after the user has enabled a language server with `vim.lsp.enable` that has no configuration a runtime error is hit because the code expects for a configuration to exist. Solution: Check if a configuration was returned before parsing it, if it isn't returned then warn the user that the server has been enabled but a configuration was not found.
* fix(cmdline): empty ext_cmdline block events for :<CR> #33118luukvbaal2025-03-28
| | | | | Problem: An ext_cmdline block event that should be empty after :<CR> re-emits the previous cmdline. Solution: Clear `last_cmdline` even when `new_last_cmdline == NULL`.
* fix(provider)!: drop Python 3.7, 3.8 support #33088v1nh1shungry2025-03-28
| | | | | | Problem: #33022 didn't update `min_version` to 3.9, therefore Python 3.7 and 3.8 are still available. Solution: Update `min_version` to 3.9.
* refactor(treesitter): simplify injection retrieval #33104Riley Bruins2025-03-28
| | | | | | | Simplify the logic for retrieving the injection ranges for the language tree. The trees are now also sorted by starting position, regardless of whether they are part of a combined injection or not. This would be helpful if ranges are ever to be stored in an interval tree or other kind of sorted tree structure.
* fix(mouse): crash with click on win-separator in statusline (#33091)Shadman2025-03-28
| | | | | | | Problem: Clicking on window separator in statusline crashes Nvim due to out of bound memory access Solution: Check if the click location is within clicking range before applying it.
* Merge pull request #33086 from zeertzjq/vim-9.1.1243zeertzjq2025-03-28
|\ | | | | vim-patch:9.1.{1243,1246}
| * vim-patch:9.1.1246: coverity complains about some changes in v9.1.1243zeertzjq2025-03-28
| | | | | | | | | | | | | | | | | | | | | | Problem: coverity complains about some changes in v9.1.1243 Solution: remove duplicate code in diff_find_changed() (Yee Cheng Chin) closes: vim/vim#16988 https://github.com/vim/vim/commit/4f9b1243e3ef60b9efb64a4e789c55be3cdc7a25 Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
| * vim-patch:9.1.1243: diff mode is lacking for changes within lineszeertzjq2025-03-28
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: Diff mode's inline highlighting is lackluster. It only performs a line-by-line comparison, and calculates a single shortest range within a line that could encompass all the changes. In lines with multiple changes, or those that span multiple lines, this approach tends to end up highlighting much more than necessary. Solution: Implement new inline highlighting modes by doing per-character or per-word diff within the diff block, and highlight only the relevant parts, add "inline:simple" to the defaults (which is the old behaviour) This change introduces a new diffopt option "inline:<type>". Setting to "none" will disable all inline highlighting, "simple" (the default) will use the old behavior, "char" / "word" will perform a character/word-wise diff of the texts within each diff block and only highlight the differences. The new char/word inline diff only use the internal xdiff, and will respect diff options such as algorithm choice, icase, and misc iwhite options. indent-heuristics is always on to perform better sliding. For character highlight, a post-process of the diff results is first applied before we show the highlight. This is because a naive diff will create a result with a lot of small diff chunks and gaps, due to the repetitive nature of individual characters. The post-process is a heuristic-based refinement that attempts to merge adjacent diff blocks if they are separated by a short gap (1-3 characters), and can be further tuned in the future for better results. This process results in more characters than necessary being highlighted but overall less visual noise. For word highlight, always use first buffer's iskeyword definition. Otherwise if each buffer has different iskeyword settings we would not be able to group words properly. The char/word diffing is always per-diff block, not per line, meaning that changes that span multiple lines will show up correctly. Added/removed newlines are not shown by default, but if the user has 'list' set (with "eol" listchar defined), the eol character will be be highlighted correctly for the specific newline characters. Also, add a new "DiffTextAdd" highlight group linked to "DiffText" by default. It allows color schemes to use different colors for texts that have been added within a line versus modified. This doesn't interact with linematch perfectly currently. The linematch feature splits up diff blocks into multiple smaller blocks for better visual matching, which makes inline highlight less useful especially for multi-line change (e.g. a line is broken into two lines). This could be addressed in the future. As a side change, this also removes the bounds checking introduced to diff_read() as they were added to mask existing logic bugs that were properly fixed in vim/vim#16768. closes: vim/vim#16881 https://github.com/vim/vim/commit/9943d4790e42721a6777da9e12637aa595ba4965 Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
* vim-patch:9.1.1247: fragile setup to get (preferred) keys from ↵zeertzjq2025-03-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | key_name_entry (#33102) Problem: fragile setup to get (preferred) keys from key_name_entry (after v9.1.1179) Solution: refactor the code further, fix a bug with "pref_name" key entry introduced in v9.1.1180 (Yee Cheng Chin) The optimization introduced for using bsearch() with key_name_entry in vim/vim#16788 was fragile as it required synchronizing a non-obvious index (e.g. IDX_KEYNAME_SWU) with the array that could be accidentally changed by any one adding a key to it. Furthermore, the "pref_name" that was introduced in that change was unnecessary, and in fact introduced a bug, as we don't always want to use the canonical name. The bug is triggered when the user triggers auto-complete using a keycode, such as `:set <Scroll<Tab>`. The bug would end up showing two copies of `<ScrollWheelUp>` because both entries end up using the canonical name. In this change, remove `pref_name`, and simply use a boolean to track whether an entry is an alt name or not and modify logic to respect that. Add test to make sure auto-complete works with alt names closes: vim/vim#16987 https://github.com/vim/vim/commit/7d8e7df55190e8e4e5a66f443e4440b52edf2fdb In Nvim there is no `enabled` field, so put `is_alt` before `name` to reduce the size of the struct. Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
* Merge pull request #33101 from zeertzjq/vim-052b86bzeertzjq2025-03-28
|\ | | | | vim-patch: runtime file updates
| * vim-patch:f9f4e27: runtime(hyprlang): save and restore cpo setting in syntax ↵zeertzjq2025-03-28
| | | | | | | | | | | | | | | | | | | | | | script fixes: vim/vim#16970 closes: vim/vim#16973 https://github.com/vim/vim/commit/f9f4e27ad76ee36a5a49013a84a466800d26f360 Co-authored-by: Christian Brabandt <cb@256bit.org>
| * vim-patch:052b86b: runtime(solidity): update syntax script with error ↵zeertzjq2025-03-28
|/ | | | | | | | | | | | | | definitions closes: vim/vim#16978 References: - https://docs.soliditylang.org/en/latest/contracts.html#transient-storage - https://soliditylang.org/blog/2021/04/21/custom-errors/ https://github.com/vim/vim/commit/052b86ba6315e65eb034ac906128f9bd82d5f2d7 Co-authored-by: S0AndS0 <strangerthanbland@gmail.com>
* fix(health): message should mention "vim.provider" #33095Eisuke Kawashima2025-03-27
|
* Merge pull request #33098 from zeertzjq/vim-9.1.1245zeertzjq2025-03-28
|\ | | | | vim-patch:9.1.{1245,1249}
| * vim-patch:9.1.1249: tests: no test that 'listchars' "eol" doesn't affect "gM"zeertzjq2025-03-28
| | | | | | | | | | | | | | | | | | Problem: No test that 'listchars' "eol" doesn't affect "gM". Solution: Add a test (zeertzjq). closes: vim/vim#16990 https://github.com/vim/vim/commit/757c37da6dd99d23fed90c00e44dd65e351e19ac
| * vim-patch:9.1.1245: need some more tests for curly braces evaluationzeertzjq2025-03-28
|/ | | | | | | | | | | | Problem: need some more tests for curly braces evaluation Solution: Add a test for the regression introduced by patch v9.1.1242 (Yegappan Lakshmanan) closes: vim/vim#16986 https://github.com/vim/vim/commit/d9b82cfe846e988772f2eec40643d7009d61ffdf Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
* refactor(eval): move diff functions to diff.c (#33085)zeertzjq2025-03-27
| | | | They were moved in Vim in patch 8.1.1989. This change is required to port patch 9.1.1243.
* fix(ui): wincmd _ should not increase 'cmdheight' above 0 (#33056)luukvbaal2025-03-27
|
* fix(display): scroll logic does not take into account concealed topline (#33054)luukvbaal2025-03-27
|
* vim-patch:51a06ec: runtime(sh): consider sh as POSIX shell by default (#33078)zeertzjq2025-03-27
| | | | | | | | | | Also, do not set g:is_kornshell when g:is_posix is set. BSD shells are POSIX but many are derived from the ash shell. closes: vim/vim#16939 https://github.com/vim/vim/commit/51a06ecee06096672b2f10fc6cd76bd8f6dfe8c9 Co-authored-by: Mohamed Akram <mohd.akram@outlook.com>
* vim-patch:9.1.1224: cannot :put while keeping indent (#33076)zeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | Problem: cannot :put while keeping indent (Peter Aronoff) Solution: add the :iput ex command (64-bitman) fixes: vim/vim#16225 closes: vim/vim#16886 https://github.com/vim/vim/commit/e08f10a55c3f15b0b4af631908551d88ec4fe502 Cherry-pick test_put.vim changes from patch 8.2.1593. N/A patches: vim-patch:9.1.1213: cannot :put while keeping indent vim-patch:9.1.1215: Patch 9.1.1213 has some issues Co-authored-by: 64-bitman <60551350+64-bitman@users.noreply.github.com> Co-authored-by: Hirohito Higashi <h.east.727@gmail.com>
* Merge pull request #32953 from glepnir/vim-9.1.1214zeertzjq2025-03-27
|\ | | | | vim-patch:9.1.{1214,1217,1219}: matchfuzzy() "camelcase"
| * vim-patch:9.1.1219: Strange error with wrong type for matchfuzzy() "camelcase"zeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: Strange error with type for matchfuzzy() "camelcase". Solution: Show the error "Invalid value for argument camelcase" instead of "Invalid argument: camelcase" (zeertzjq). Note that using tv_get_string() will lead to confusion, as when the value cannot be converted to a string tv_get_string() will also give an error about that, but "camelcase" takes a boolean, not a string. Also don't use tv_get_string() for the "limit" argument above. closes: vim/vim#16926 https://github.com/vim/vim/commit/c4815c157b27923001e44bfd241fb540bf1fb518
| * vim-patch:9.1.1217: tests: typos in test_matchfuzzy.vimzeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | Problem: tests: typos in test_matchfuzzy.vim (after 9.1.1214). Solution: Fix the typos. Consistently put the function call on the second line in assertions for camelcase (zeertzjq). closes: vim/vim#16907 https://github.com/vim/vim/commit/85627732e0f5f4e31137fc12bcb809418a4f683f
| * vim-patch:9.1.1214: matchfuzzy() can be improved for camel case matchesglepnir2025-03-27
|/ | | | | | | | | | | | | | | | Problem: When searching for "Cur", CamelCase matches like "lCursor" score higher than exact prefix matches like Cursor, which is counter-intuitive (Maxim Kim). Solution: Add a 'camelcase' option to matchfuzzy() that lets users disable CamelCase bonuses when needed, making prefix matches rank higher. (glepnir) fixes: vim/vim#16504 closes: vim/vim#16797 https://github.com/vim/vim/commit/28e40a7b55ce471656cccc2260c11a29d5da447e Co-authored-by: glepnir <glephunter@gmail.com>
* Merge pull request #30189 from zeertzjq/vim-9.1.0598zeertzjq2025-03-27
|\ | | | | vim-patch: 'completefuzzycollect' option
| * vim-patch:9.1.1228: completion: current position column wrong after got a matchzeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: The current_pos.col was incorrectly updated to the length of the matching text. This will cause the next search to start from the wrong position. Solution: current_pos has already been updated in search_str_in_line and does not need to be changed (glepnir) closes: vim/vim#16941 https://github.com/vim/vim/commit/5753084042e17d794627d77e4300def031ce5498 Co-authored-by: glepnir <glephunter@gmail.com>
| * vim-patch:9.1.1201: 'completefuzzycollect' does not handle dictionary correctlyzeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | | | | | Problem: 'completefuzzycollect' does not handle dictionary correctly Solution: check for ctrl_x_mode_dictionary (glepnir) closes: vim/vim#16867 https://github.com/vim/vim/commit/587601671cd06ddc4d78f907d98578cdab96003f Cherry-pick a documentation fix from later. Co-authored-by: glepnir <glephunter@gmail.com>
| * vim-patch:1dc731a: runtime(doc): make :h 'completefuzzycollect' a bit clearerzeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | - Fix grammar - Use "matches" instead of "items" ("completion candidates" is used in some other places, but it's a bit verbose) - "When set" is a bit vague, instead use "For specified modes" closes: vim/vim#16871 https://github.com/vim/vim/commit/1dc731a49ff5d06ead4b506afa04288a5baafc1a
| * vim-patch:9.1.1197: process_next_cpt_value() uses wrong conditionzeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | | | Problem: process_next_cpt_value() uses wrong condition Solution: use cfc_has_mode() instead and remove redundant else if branch (glepnir) closes: vim/vim#16833 https://github.com/vim/vim/commit/53b14578e03f93a53fd6eb21c00caf96484742ed Co-authored-by: glepnir <glephunter@gmail.com>
| * vim-patch:9.1.1185: endless loop with completefuzzycollect and no match foundzeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | Problem: endless loop with completefuzzycollect and no match found Solution: move pointer to line end and break loop closes: vim/vim#16820 https://github.com/vim/vim/commit/dd42b05f8a37df03a9b77a16a47c08ab33af2b1f Co-authored-by: glepnir <glephunter@gmail.com>
| * vim-patch:9.1.1182: No cmdline completion for 'completefuzzycollect'zeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: No cmdline completion for the 'completefuzzycollect' option (after v9.1.1178) Solution: Add cmdline completion for the 'completefuzzycollect' option, improve its description in optwin.vim (zeertzjq). closes: vim/vim#16813 https://github.com/vim/vim/commit/53d59ecc1d93ce3a3f6d0182479d825852018ceb No code change is needed in Nvim as Nvim uses expand_set_str_generic() by default.
| * vim-patch:9.1.1181: Unnecessary STRLEN() calls in insexpand.czeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | Problem: Unnecessary STRLEN() calls in insexpand.c (after 9.1.1178). Solution: Use the already available length (zeertzjq). closes: vim/vim#16814 https://github.com/vim/vim/commit/4422de6316b544c282e6c74afd3df3ee3a4b1cfd
| * vim-patch:9.1.1178: not possible to generate completion candidates using ↵zeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fuzzy matching Problem: not possible to generate completion candidates using fuzzy matching Solution: add the 'completefuzzycollect' option for (some) ins-completion modes (glepnir) fixes vim/vim#15296 fixes vim/vim#15295 fixes vim/vim#15294 closes: vim/vim#16032 https://github.com/vim/vim/commit/f31cfa29bf72b0cdf6fa1b60346ea4e187bcafd1 Co-authored-by: glepnir <glephunter@gmail.com>
| * vim-patch:9.1.1131: potential out-of-memory issue in search.czeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: potential out-of-memory issue in search.c Solution: improve situation and refactor search.c slightly (John Marriott) - In function update_search_stat(): add a check for a theoretical null pointer reference, set and remember the length of lastpat, remove the three calls to STRLEN() and use the various string's associated lengths instead, add a check for an out-of-memory condition. - In function search_for_fuzz_match(): remove a call to strnsave() and thus avoid having to add a check for an out-of-memory condition, also replace the call to STRLEN() by ml_get_buf_len(). closes: vim/vim#16689 https://github.com/vim/vim/commit/b79fa3d9c8a08f15267797511d779e33bd33e68e Co-authored-by: John Marriott <basilisk@internode.on.net>
| * vim-patch:9.1.1008: tests: test for patch 9.1.1006 doesn't fail without the ↵zeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | | | patch Problem: tests: test for patch 9.1.1006 doesn't fail without the patch (after v9.1.1006) Solution: Add ctermbg=NONE to the highlight groups (zeertzjq). closes: vim/vim#16425 https://github.com/vim/vim/commit/faf250c9e4f6f9fa5db38d9373735e77ba438a90
| * vim-patch:9.1.1006: PmenuMatch completion highlight can be combinedzeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | | | | | Problem: PmenuMatch completion highlight can be combined Solution: Combine highlight groups PmenuMatch with Pmenu and PmenuMatchSel with PmenuSel (glepnir) fixes: vim/vim#15563 closes: vim/vim#16408 https://github.com/vim/vim/commit/9eff3ee81839d67999491d293879ada134df2d3e Co-authored-by: glepnir <glephunter@gmail.com>
| * vim-patch:9.1.0733: keyword completion does not work with fuzzyzeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: keyword completion does not work with fuzzy (egesip) Solution: handle ctrl_x_mode_normal() specifically (glepnir) fixes: vim/vim#15412 closes: vim/vim#15424 https://github.com/vim/vim/commit/7cfe693f9bfa74690867e4d96c25f2205d0d13e4 Co-authored-by: glepnir <glephunter@gmail.com>
| * vim-patch:26e4b00: runtime(doc): Revert outdated comment in completeopt's ↵zeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fuzzy documentation Originally, `:set completeopt+=fuzzy` did not affect how the candidate list is collected in default keyword completion. A comment was added to documentation as part of vim/vim#14912 to clarify it. vim/vim#15193 later changed the fuzzy behavior to now change the candidate collection behavior as well so the clarification in docs is now wrong. Remove them here. closes: vim/vim#15656 https://github.com/vim/vim/commit/26e4b000025ea0e25ea7877314d9095737431bae Co-authored-by: Yee Cheng Chin <ychin.git@gmail.com>
| * vim-patch:9.1.0705: Sorting of fuzzy filename completion is not stablezeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | Problem: Sorting of fuzzy filename completion is not stable Solution: Compare indexes when scores are equal. Fix some typos. (zeertzjq) closes: vim/vim#15593 https://github.com/vim/vim/commit/58d705238c0794ee3baa4173831ab157e709a48a
| * vim-patch:9.1.0654: completion does not respect completeslash with fuzzyzeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: completion does not respect completeslash with fuzzy (egesip) Solution: Change path separator on Windows, depending on 'completeslash' option value (glepnir) fixes: vim/vim#15392 closes: vim/vim#15418 https://github.com/vim/vim/commit/b9de1a057f9a0b6de6f64a9c1b2078c7069cdd7d Co-authored-by: glepnir <glephunter@gmail.com>
| * vim-patch:9.1.0634: Ctrl-P not working by defaultzeertzjq2025-03-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: Ctrl-P not working by default (Jesse Pavel, after v9.1.0598) Solution: Revert part of v9.1.0598 and set cur_match_pos correctly according to compl_dir_forward() fixes: vim/vim#15370 closes: vim/vim#15379 https://github.com/vim/vim/commit/13032a49b7d2a45e7c774cf23ee8f58f56b03781 Co-authored-by: Christian Brabandt <cb@256bit.org>