| Commit message (Collapse) | Author | Age |
... | |
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Scripts that define the build itself shouldn't be external as they lead
to hard to find bugs.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Instead use the cmake option, which should act as the definitive source
to determine whether we use CI or not.
|
| | | | |
| | | | |
| | | | |
| | | | | |
Having as few indirections as possible makes it easier to understand the
code.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Having CI scripts that is separate from the build system causes
tremendous amounts of problems, headaches and bugs. Testing the validity
of the scripts locally become near impossible as time goes on as they're
only vetted if it works on whatever CI provider we happened to have at
the time, with their own quirks and behavior.
The extra indirection between "cmake <-> general CI scripts <-> GHA" is
also a frequent source of problems, as the orchestration needs to be
done with environment variables, cmake flags and github actions matrix
strategy. This combination has turned out to be exceptionally fragile.
Examples:
https://github.com/neovim/neovim/commit/15394b6855c3b17be06bf2bfbac7797d9c3ebf1d
https://github.com/neovim/neovim/commit/13aa23b62af4df3e7f10687b76fe8c04efa2a598
https://github.com/neovim/neovim/pull/22072#discussion_r1094390713
A lot of the code was inlined to .github/workflows/ci.yml without
further modifications. While this in itself doesn't integrate with our
build system any more than the current situation, it does
1. remove a level of indirection, and more importantly
2. allow us to slowly start integrating the CI into our build system now
that all the relevant code is in one place.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
* ci: show all logs at the end of a run
The current CI won't show the logs on error due to early exit. This will
at least show the logs, although for all tests at once.
|
| | | | |
| | | | |
| | | | | |
Co-authored-by: Gregory Anders <greg@gpanders.com>
|
| | | | |
| | | | |
| | | | | |
There shouldn't be any core dumps before we have started testing.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Problem: The option initialization function is too long.
Solution: Move code to separate functions. (Yegappan Lakshmanan,
closes vim/vim#11966)
https://github.com/vim/vim/commit/6c41bedeed2a1f98fb9c55ff85634138782ad92a
Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
|
| | | | |
| | | | |
| | | | |
| | | | | |
Abstracting the build commands to a separate script makes it more
difficult to reason about it and more error-prone.
|
| | | | |
| | | | |
| | | | |
| | | | | |
As the trigger type is no longer pull_request_target there is no longer
any risk of using the lintcommit script directly from the user PR.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Problem: 'statusline' only supports one "%=" item.
Solution: Add support for multiple "%=" items. (TJ DeVries, Yegappan
Lakshmanan, closes vim/vim#11970, closes vim/vim#11965)
https://github.com/vim/vim/commit/3ec78f973fdaec2cea8e036ed38037b2fe40670b
Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
|
|\ \ \ \ \
| | | | | |
| | | | | | |
vim-patch:9.0.{1298,1299}: c_CTRL-R_CTRL-R doesn't trigger incsearch
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Problem: Change for triggering incsearch not sufficiently tested.
Solution: Add a test case. Simplify the code. (closes vim/vim#11971)
https://github.com/vim/vim/commit/412e0e4ed903682f352d8ea58ded480930cc664f
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Problem: Inserting a register on the command line does not trigger
incsearch or update hlsearch.
Solution: Have cmdline_insert_reg() return CMDLINE_CHANGED when appropriate
and handle it correctly. (Ken Takata, closes vim/vim#11960)
https://github.com/vim/vim/commit/c4b7dec38292fe1cfad7aa5f244031fc6f7c7a09
Co-authored-by: K.Takata <kentkt@csc.jp>
|
| | | | |
| | | | |
| | | | |
| | | | | |
BREAKING CHANGE: Unsaved changes are now preserved rather than discarded
when stdio channel is closed.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
refactor: replace char_u with char
Work on https://github.com/neovim/neovim/issues/459
|
| | | | |
| | | | |
| | | | | |
Anyone can review a refactor depending on what's being refactored.
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
MSVC has 4 different warning levels: 1 (severe), 2 (significant), 3
(production quality) and 4 (informational). Enabling level 3 warnings
mostly revealed conversion problems, similar to GCC/clang -Wconversion
flag.
|
| |_|/ /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
(#22210)
Problem: Wrong value for $LC_CTYPE makes the environ test fail.
Solution: Unset $LC_CTYPE when running tests. (closes vim/vim#11963)
https://github.com/vim/vim/commit/962d91643520ec3748fcf5af3263d89ccfcdda92
Co-authored-by: WuerfelDev <dev@wuerfeldev.de>
|
|\ \ \ \
| | | | |
| | | | | |
build(ci): let ASAN print tracebacks for more errors (SIGABORT, SIGILL)
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
refactor(tests): integrate lua-client into core and use core for functionaltests
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This replicates the old native.pid_wait(self._pid)
call, except using the proper libuv pattern (run loop unitil exit
callback)
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Eliminates lua-client and non-static libluv as test time dependencies
Note: the API for a public lua-client is not yet finished.
The interface needs to be adjusted to work in the embedded loop
of a nvim instance (to use it to talk between instances)
|
| | | | |
| | | | |
| | | | | |
Only the most important variables should be shown by default.
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
refactor(ui): remove some superfluous redraw and ui_flush() calls
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- <expr> mapping has no business saving and restoring the
low-level UI cursor. The cursor will be put in a reasonable
position after input is processed, chill out.
- TUI handles output needed for suspend
- vgetc() family of function does flushing
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
These are just ordinary boring events now. Modes already redraw events
themselves.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- Suggest reading CONTRIBUTING.md once, not for each commit failure
- Suggest using "fix" type if none of the provided types are appropriate
- Remove "dist" type. It's rarely used and can be replaced by using the
"build" type
|
| | | | | |
|
| |/ / /
|/| | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
More specifically, move the job testing the oldest supported cmake into
its own job. This opens the way for other jobs to use powerful and
advanced cmake features such as choosing which files to use with the -S
flag.
Removed testing from this job as this probably won't reveal anything
that other jobs already doesn't already show, since the only difference
is the cmake version.
|
| | | |
| | | |
| | | | |
This will get rid of the common/ directory.
|
| | | |
| | | |
| | | |
| | | | |
The default output is too verbose and messy for someone not already
familiar with lintcommit, which defeats it purpose.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Using the base branch as cache means that pull requests won't be able to
use the cache from the master branch, since the master branch cache
doesn't have a base_ref as it's generated from a push. Removing base_ref
makes the cache key from master and PR branch the same, provided the any
build files don't change.
|
|/ / /
| | |
| | |
| | |
| | | |
I don't think it's possible to meaningfully abstract away caching on
multiple providers, as each provider has different mechanisms
on how they work.
|
| | |
| | |
| | |
| | |
| | | |
The CI somtimes freezes on a specific test, wasting 45 minutes for the
entire job. Adding a timeout of 15 minutes to functionaltest and 5
minutes to unittests will mitigate the problem.
|
|\ \ \
| | | |
| | | |
| | | | |
* docs(maintain): add note on updating `luvref.txt`
* docs(luvref): update version info
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Previously, if the autocommands are not triggered, the tests may still
pass because no assertion is done. Add an assertion so that the tests
will fail if the autocommands aren't triggered.
|
| | | |
| | | |
| | | | |
These aren't needed as we don't use codecov anymore.
|
| | | |
| | | |
| | | |
| | | | |
When a TUI client has already stopped, handling UI events will cause a
heap-use-after-free, so ignore them.
|
| | | |
| | | |
| | | | |
Otherwise it will crash.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Having a clear separation between build code and test code makes it
easier to get a higher-level understanding of how the neovim build
works.
|