aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* build: various cmake fixes (#21902)dundargoc2023-01-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * build: various cmake refactors and simplifications - Add STATUS keyword to message to ensure messages are shown in the correct order. - Remove DEPS_CXX_COMPILER as we don't rely on C++ for any of our dependencies. - Simplify how msgpack and luv configure options are constructed. - Rely on the default installation for luv instead of manually passing configure, build and install commands. - Simplify return code conditional. * build: remove CMAKE_OSX_ARCHITECTURES_ALT_SEP workaround CMAKE_OSX_ARCHITECTURES_ALT_SEP was defined as a workaround to prevent the shell from interpreting `;`, which CMake uses as a list separator. However, the same thing can be achieved by instead passing CMAKE_OSX_ARCHITECTURES as a cache variable instead, which is a more idiomatic way of achieving the same thing. * build: define CMAKE_BUILD_TYPE before adding it to BUILD_TYPE_STRING The problem with the current setup is that CMAKE_BUILD_TYPE is defined after BUILD_TYPE_STRING. BUILD_TYPE_STRING will then be empty on the first run, meaning that dependencies are built without a build type. However, since CMAKE_BUILD_TYPE is a cache variable its value will persist in subsequent runs. On the second run BUILD_TYPE_STRING will have the correct value, but it's a different value from the ones the dependencies were built with. This will force some dependencies to be built again. Fixes https://github.com/neovim/neovim/issues/21672.
* docs: docs: use codeblocks in runtime/doc/options.txt (#21919)Sizhe Zhao2023-01-20
| | | | | ensure correct parsing with tree-sitter Co-authored-by: zeertzjq <zeertzjq@outlook.com>
* fix(lsp): fix `removed` param value in add_workspace_folder (#21915)Raphael2023-01-20
|
* vim-patch:9.0.0358: 'breakindent' does not indent non-lists (#21913)zeertzjq2023-01-20
| | | | | | | | | Problem: 'breakindent' does not indent non-lists with "breakindentopt=list:-1". Solution: Adjust indent computation. (Maxim Kim, closes vim/vim#11038) https://github.com/vim/vim/commit/119167265ebc7eced210a7f8ed2f4b90378f98f1 Co-authored-by: Maxim Kim <habamax@gmail.com>
* test(syn_attr_spec): add more information (#21912)zeertzjq2023-01-20
| | | This makes it clear on test failure what the attributes are.
* perf(statuscolumn): only fill click defs array once per redraw (#21884)luukvbaal2023-01-20
| | | | | | | | | | | Problem: 'statuscolumn' click definitions are cleared, evaluated, allocated and filled each redraw for every row in a window. This despite the fact that we only store a single click definition array for the entire column as opposed to one for each row. Solution: Only fill the 'statuscolumn' click definition array once per window per redraw. Resolve https://github.com/neovim/neovim/issues/21767.
* build: remove nvim as a dependency of unittests (#21903)dundargoc2023-01-19
| | | | | | Unittests rely on nvim-test and not nvim, leading to both nvim and nvim-test being compiled each time a file is changed. Furthermore, the dependencies are already specified by CMakeLists.txt and shouldn't need to be specified in Makefile as it's only meant to be syntactic sugar.
* refactor(highlight_group.c): reduce scope of localsLewis Russell2023-01-19
|
* refactor: replace char_u with char 25 (#21838)dundargoc2023-01-19
| | | | | refactor: replace char_u with char Work on https://github.com/neovim/neovim/issues/459
* fix(rpc): don't parse msgpack if buflen is 0 (#21899)zeertzjq2023-01-19
| | | | This prevents `buflen` from becoming a very large number when it is 0 when calling mpack_rtoken().
* fix: pass value instead of pointer to isalpha (#21898)dundargoc2023-01-19
|
* build: enable cmake workflow presets (#21860)dundargoc2023-01-19
| | | | | | | | | | | | | Workflow presets allows combining configure, build, test and packaging steps and makes it possible to run everything in a single command. So cmake --preset iwyu cmake --build --preset iwyu instead becomes cmake --workflow --preset iwyu Workflow presets requires at least cmake version 3.25 to use.
* vim-patch:8.2.4655: cmdline completion popup menu positioned wrong (#21894)zeertzjq2023-01-19
| | | | | | | | | | | | | Problem: Command line completion popup menu positioned wrong when using a terminal window. Solution: Position the popup menu differently when editing the command line. (Yegappan Lakshmanan, closes vim/vim#10050, closes vim/vim#10035) https://github.com/vim/vim/commit/1104a6d0c2004d39e9b6cb8f804d12b628a69869 The test in the patch looks a bit hard to understand. Add a Lua test that is more straightforward. Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
* refactor(eval.c): factor out get_number_tv() (#21893)zeertzjq2023-01-19
| | | It was refactored into a separate function in Vim in patch 8.2.0149.
* Merge pull request #21879 from zeertzjq/stl-click-zero-lenzeertzjq2023-01-19
|\ | | | | Fix statusline memory leaks with click labels
| * fix(statusline): don't leak memory with truncated click labelszeertzjq2023-01-19
| |
| * fix(statusline): don't leak memory with zero-width click labelszeertzjq2023-01-19
|/ | | | | A zero-width click label isn't assigned to any click definition, so its function name should be freed when filling click definitions.
* vim-patch:9.0.1221: code is indented more than necessary (#21891)zeertzjq2023-01-19
| | | | | | | | | Problem: Code is indented more than necessary. Solution: Use an early return where it makes sense. (Yegappan Lakshmanan, closes vim/vim#11833) https://github.com/vim/vim/commit/f97a295ccaa9803367f3714cdefce4e2283c771d Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
* vim-patch:8.2.1698: cannot lock a variable in legacy Vim script like in Vim9 ↵zeertzjq2023-01-19
| | | | | | | | | | (#21883) Problem: Cannot lock a variable in legacy Vim script like in Vim9. Solution: Make ":lockvar 0" work. https://github.com/vim/vim/commit/a187c43cfe8863d48b2159d695fedcb71f8525c1 Co-authored-by: Bram Moolenaar <Bram@vim.org>
* ci: enable CI_BUILD on windows (#21557)dundargoc2023-01-18
| | | | | | | | This will ensure warnings are treated as errors when using MSVC. Also fix const correctness warnings. The warnings in mbyte.c are false positives that triggers this warning on MSVC v19.32 and lower, which our CI still use. The (void *) casts can be removed once the CI MSVC version has been upgraded to v19.33 or higher.
* Merge pull request #21881 from bfredl/uniterrorbfredl2023-01-18
|\ | | | | fix(unittests): do not consider process crash to be a success
| * fix(unittests): fix TUI broken test previously ignoredbfredl2023-01-18
| |
| * fix(unittest): delete unused duplicated codebfredl2023-01-18
| | | | | | | | YAGNI. These were disabled 5 years ago in lint commit 29ed5b3a39abb84d6af602b2d0a7680d9dab381c
| * fix(unittests): do not consider process crash to be a successbfredl2023-01-18
| | | | | | | | | | | | | | | | unittests relied on the exact setup of coredumps on CI to detect process crashing, and otherwise completely discarded errors. Dectect child process failure reliably using process status, so that unittests actually work locally as well.
* | refactor: replace char_u with char 24 (#21823)dundargoc2023-01-18
| | | | | | | | | | refactor: replace char_u with char Work on https://github.com/neovim/neovim/issues/459
* | refactor: replace char_u with char 23 (#21798)dundargoc2023-01-18
| | | | | | Work on https://github.com/neovim/neovim/issues/459
* | build(Windows): fix redoing version generation (#21880)Enan Ajmain2023-01-18
| | | | | | | | | | | | | | | | | | Problem: On Windows, neovim's version is generated every time nvim is built, even if code hasn't been changed. That is because version generation is done based on a hash matching of a file and the content of the file. And in Windows they don't match, because of the DOS line-endings. Solution: Write the file containing nvim version with UNIX line-endings.
* | fix(statuscolumn): always fill click defs array (#21878)zeertzjq2023-01-18
| | | | | | | | | | | | | | | | Click definitions are always filled for tabline, statusline and winbar, so they should also be always filled for statuscolumn, otherwise it will leak memory. Note: this doesn't actually change the existing code much, because of a typo in the existing code.
* | vim-patch:9.0.0149: test for fuzzy completion fails sometimes (#21876)zeertzjq2023-01-18
| | | | | | | | | | | | | | | | | | Problem: Test for fuzzy completion fails sometimes. Solution: Use a more specific file name to minimize the chance of matching a random directory name. (closes vim/vim#10854) https://github.com/vim/vim/commit/5ac4b1a24e3ba52698a0d24b22cdd2e1c7895417 Co-authored-by: Bram Moolenaar <Bram@vim.org>
* | refactor(PVS): suppress false positive V547 in drawline.c (#21875)Lucas Merritt2023-01-18
| | | | | | | | | | | | This is a false positive as "did_emsg" can be set by get_syntax_attr() Example: get_syntax_attr() -> syn_current_attr() -> syn_getcurline() -> ml_get_buf() -> siemsg() -> semsgv() -> emsg() -> emsg_multiline()
* | vim-patch:9.0.1213: adding a line below the last one does not expand fold ↵zeertzjq2023-01-18
| | | | | | | | | | | | | | | | | | | | | | (#21869) Problem: Adding a line below the last one does not expand fold. Solution: Do not skip mark_adjust() when adding lines below the last one. (Brandon Simmons, closes vim/vim#11832, closes vim/vim#10698) https://github.com/vim/vim/commit/da3dd7d857ba4fb4bf408dedd1d9d6a2d5e2ae9f Co-authored-by: Brandon Simmons <simmsbra@gmail.com>
* | refactor(PVS/V1048): remove unnecessary assignment (#21870)Lucas Merritt2023-01-18
| |
* | Merge pull request #21868 from zeertzjq/vim-9.0.1214zeertzjq2023-01-18
|\ \ | | | | | | vim-patch:9.0.{1214,1215}
| * | vim-patch:9.0.1215: using isalpha() adds dependency on current localezeertzjq2023-01-18
| | | | | | | | | | | | | | | | | | | | | | | | Problem: Using isalpha() adds dependency on current locale. Solution: Do not use isalpha() for recognizing a URL or the end of an Ex command. (closes vim/vim#11835) https://github.com/vim/vim/commit/0ef9a5c09482649cf0cc6768ed6fc640b4ed2a0a
| * | vim-patch:9.0.1214: file left behind after running testszeertzjq2023-01-18
|/ / | | | | | | | | | | | | | | | | Problem: File left behind after running tests. Solution: Delete the file. (Dominique Pellé, closes vim/vim#11839) https://github.com/vim/vim/commit/541c87c808df91b55e51fedc4987152a3edfe80d Co-authored-by: Dominique Pelle <dominique.pelle@gmail.com>
* / vim-patch:9.0.1212: cannot read back what setcellwidths() has done (#21867)zeertzjq2023-01-18
|/ | | | | | | | Problem: Cannot read back what setcellwidths() has done. Solution: Add getcellwidths(). (Kota Kato, closes vim/vim#11837) https://github.com/vim/vim/commit/66bb9ae70f7371456ed76518076d2a344f8ab417 Co-authored-by: Kota Kato <github@kat0h.com>
* fix(treesitter): really restore syntaxLewis Russell2023-01-17
| | | | | - also unset b:ts_highlight on stop() Fixes: #21836
* refactor: replace char_u with char 22 (#21786)dundargoc2023-01-17
| | | Work on https://github.com/neovim/neovim/issues/459
* Merge pull request #21859 from zeertzjq/vim-8.2.4617zeertzjq2023-01-17
|\ | | | | vim-patch:8.2.{4617,4618,4620,5126}
| * vim-patch:8.2.5126: substitute may overrun destination bufferzeertzjq2023-01-17
| | | | | | | | | | | | | | | | | | Problem: Substitute may overrun destination buffer. Solution: Disallow switching buffers in a substitute expression. https://github.com/vim/vim/commit/d6211a52ab9f53b82f884561ed43d2fe4d24ff7d Co-authored-by: Bram Moolenaar <Bram@vim.org>
| * vim-patch:8.2.4618: cmdline completion does not recognize single letter commandszeertzjq2023-01-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: Command line completion does not recognize single letter commands. Solution: Use the condition from find_ex_command(). https://github.com/vim/vim/commit/f4f0525c34d2aa32f214155b0dadcd274ed05dd1 vim-patch:8.2.4620: two letter substitute commands don't work Problem: Two letter substitute commands don't work. (Yegappan Lakshmanan) Solution: Invert condition. https://github.com/vim/vim/commit/1e2c4175dce903986dac66ba9326ae562b159421 Co-authored-by: Bram Moolenaar <Bram@vim.org>
| * vim-patch:8.2.4617: no completion for :scriptnameszeertzjq2023-01-17
|/ | | | | | | | | | Problem: No completion for :scriptnames. Solution: Implement :scriptnames completion. (Yegappan Lakshmanan, closes vim/vim#10005) https://github.com/vim/vim/commit/454ce6737cadb82886f1fc0eb9e8666cc59ae42b Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
* build(deps): bump tree-sitter to HEAD - eb970a83a (#21858)Christian Clason2023-01-17
| | | includes https://github.com/tree-sitter/tree-sitter/commit/efd22e452be528b091a8b691e38b65d43dc6f0ff which fixes some errors around infinite loops with injections
* vim-patch:8.2.4483: command completion makes two rounds to collect matches ↵zeertzjq2023-01-17
| | | | | | | | | | | (#21857) Problem: Command completion makes two rounds to collect matches. Solution: Use a growarray to collect matches. (Yegappan Lakshmanan, closes vim/vim#9860) https://github.com/vim/vim/commit/5de4c4372d4366bc85cb66efb3e373439b9471c5 Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
* vim-patch:8.2.4959: using NULL regexp program (#21855)zeertzjq2023-01-17
| | | | | | | | Problem: Using NULL regexp program. Solution: Check for regexp program becoming NULL in more places. https://github.com/vim/vim/commit/b62dc5e7825bc195efe3041d5b3a9f1528359e1c Co-authored-by: Bram Moolenaar <Bram@vim.org>
* vim-patch:8.2.4928: various white space and cosmetic mistakes (#21854)zeertzjq2023-01-17
| | | | | | | | Problem: Various white space and cosmetic mistakes. Solution: Change spaces to tabs, improve comments. https://github.com/vim/vim/commit/6ed545e79735f23ff8e650bc2f0967e5a0baedc9 Co-authored-by: Bram Moolenaar <Bram@vim.org>
* vim-patch:8.2.4917: fuzzy expansion of option names is not right (#21853)zeertzjq2023-01-17
| | | | | | | | | Problem: Fuzzy expansion of option names is not right. Solution: Pass the fuzzy flag down the call chain. (Christian Brabandt, closes vim/vim#10380, closes vim/vim#10318) https://github.com/vim/vim/commit/cb747899bd99361a299a163f3aa55d5fe7d6f798 Co-authored-by: Christian Brabandt <cb@256bit.org>
* vim-patch:9.0.0089: fuzzy argument completion doesn't work for shell ↵zeertzjq2023-01-17
| | | | | | | | | | | commands (#21852) Problem: Fuzzy argument completion doesn't work for shell commands. Solution: Check for cmdidx not being CMD_bang. (Yegappan Lakshmanan, closes vim/vim#10769) https://github.com/vim/vim/commit/7db3a8e3298bf7c7c3f74cc9c1add04f29e78d2d Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>
* Merge pull request #21851 from zeertzjq/vim-8.2.4482zeertzjq2023-01-17
|\ | | | | vim-patch:8.2.{4482,4485}: fuzzy cmdline custom completion
| * fix(completion): correct what modes support fuzzy completionzeertzjq2023-01-17
| |