aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
...
* | | | Merge #9047 from jamessan/log-crashJustin M. Keyes2018-09-25
|\ \ \ \
| * | | | log: Assert that we haven't started freeing memory before loggingJames McCoy2018-09-24
| | | | | | | | | | | | | | | | | | | | | | | | | This is to catch situations like the previous commit, which somehow avoided detection by any of the CI builds.
| * | | | os_unix: Log exit code before freeing all memoryJames McCoy2018-09-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When building with -DEXITFREE, the ILOG call would result in a crash trying to access VV_PROGPATH, which had already been released: (gdb) bt #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 #1 0x00007f8f761082f1 in __GI_abort () at abort.c:79 #2 0x00007f8f760ffa8a in __assert_fail_base (fmt=0x7f8f76253ec8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x1c74280 <.str.8> " ,\t\n", file=file@entry=0x1c73fe2 "256]'", line=line@entry=610, function=function@entry=0x1c742e0 <.str.9+32> "") at assert.c:92 #3 0x00007f8f760ffb02 in __GI___assert_fail (assertion=0x1c74280 <.str.8> " ,\t\n", file=0x1c73fe2 "256]'", line=610, function=0x1c742e0 <.str.9+32> "") at assert.c:101 #4 0x00000000012d87c1 in vim_getenv (name=0x2f5a460 <get_special_key_name.string+64> "NVIM_LOG_FILE") at ../src/nvim/os/env.c:608 #5 0x00000000012d6538 in expand_env_esc (srcp=0x1c2f4e0 <.str.10+32> "", dst=0x2f5a460 <get_special_key_name.string+64> "NVIM_LOG_FILE", dstlen=4095, esc=false, one=false, prefix=0x0) at ../src/nvim/os/env.c:351 #6 0x00000000012d85af in expand_env_esc (srcp=0x625000000100 "\004", dst=0x7ffeed88cf40 "", dstlen=32766, esc=237, one=136, prefix=0x60200401c8b4 <error: Cannot access memory at address 0x60200401c8b4>) at ../src/nvim/os/env.c:472 #7 0x0000000000eb4274 in do_log_to_file (log_file=0x0, log_level=0, context=0x0, func_name=0x0, line_num=0, eol=false, fmt=0x0) at ../src/nvim/log.c:254 #8 0x0000000000eb305b in open_log_file () at ../src/nvim/log.c:164 #9 0x0000000000eb2cc6 in logmsg (log_level=<error reading variable: Cannot access memory at address 0x268>, context=<error reading variable: Cannot access memory at address 0x260>, func_name=<error reading variable: Cannot access memory at address 0x258>, line_num=<error reading variable: Cannot access memory at address 0x254>, eol=<error reading variable: Cannot access memory at address 0x253>, fmt=<error reading variable: Cannot access memory at address 0x248>) at ../src/nvim/log.c:109 #10 0x00000000013022c7 in mch_free_acl (aclent=0x4f59100) at ../src/nvim/os_unix.c:132 #11 0x0000000000efddac in getout (exitval=0) at ../src/nvim/main.c:681 #12 0x0000000000c1bb3e in ex_quit (eap=0x7ffeed88cd00) at ../src/nvim/ex_docmd.c:6067 #13 0x0000000000bab781 in do_one_cmd (cmdlinep=0x7ffeed88f180, flags=10, cstack=0x7ffeed88f1a0, fgetline=0x0, cookie=0x0) at ../src/nvim/ex_docmd.c:2228 #14 0x0000000000b8de6d in do_cmdline (cmdline=0x7ffeed891ae2 "quit", fgetline=0x0, cookie=0x0, flags=10) at ../src/nvim/ex_docmd.c:592 #15 0x0000000000b94036 in do_cmdline_cmd (cmd=0x7ffeed891ae2 "quit") at ../src/nvim/ex_docmd.c:268 #16 0x0000000000efb900 in exe_commands (parmp=0x7ffeed890900) at ../src/nvim/main.c:1699 #17 0x0000000000ee96b2 in main (argc=11, argv=0x7ffeed890fa8) at ../src/nvim/main.c:524
* | | | | TUI: Alacritty supports DECSCUSR (#9048)Christian Duerr2018-09-25
|/ / / / | | | | | | | | Alacritty may set TERM to"alacritty" or "alacritty-direct" if it finds its terminfo.
* | | | deps: revert to jemalloc 4.5.0 (#9035)Justin M. Keyes2018-09-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Since the jemalloc upgrade to 5.1.0, I'm seeing weird behavior such as infinite loops inside jemalloc routines. - VimR maintainer reported major performance regression correlated with jemalloc 5.1.0. ref https://github.com/neovim/neovim/pull/7808 reverts 765515010f8e60596ec67eb7cdfbe7f5e4e60c7d
* | | | build: Unify USE_BUNDLED, USE_BUNDLED_DEPS (#9046)Justin M. Keyes2018-09-24
| | | | | | | | | | | | It's confusing that the Makefile uses a different name than CMake.
* | | | vim-patch:8.1.0428: the :suspend command is not tested (#9043)Jan Edmund Lazo2018-09-24
| | | | | | | | | | | | | | | | | | | | Problem: The :suspend command is not tested. Solution: Add a test. (Dominique Pelle, closes vim/vim#3472) https://github.com/vim/vim/commit/3b30168f04b8a2a2f1bbaa2f90be546550463146
* | | | vim-patch:8.1.0429: no test for :lcd with 'shellslash' (#9041)Daniel Hahler2018-09-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: No test for :lcd with 'shellslash'. Solution: Add a test. (Daniel Hahler, closes vim/vim#3475) https://github.com/vim/vim/commit/c75878c923034b883090aef3f08f565513d98f4d Related NA patch: vim-patch:8.1.0343
* | | | Merge pull request #9039 from blueyed/undercurlBjörn Linse2018-09-23
|\ \ \ \ | | | | | | | | | | tui: code consistency in update_attrs
| * | | | minor: tui: update_attrs: code consistencyDaniel Hahler2018-09-23
|/ / / /
* | | | Merge #9034 'swapfile: always show dialog'Justin M. Keyes2018-09-23
|\ \ \ \
| * | | | test: Do not load entire log-file into memoryJustin M. Keyes2018-09-23
| | | | | | | | | | | | | | | | | | | | With DEBUG-level logging, after `make test`, log file could be 1+ GB.
| * | | | swapfile: Always show swap dialog (E325)Justin M. Keyes2018-09-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If swapfile dialog prompts for input, it must be displayed to the user. fix #8840 fix #9027
| * | | | shortmess+=F: Hide :bnext, :bprev fileinfo messagesJustin M. Keyes2018-09-23
| |/ / /
* / / / vim-patch:8.0.1557: printf() does not work with only one argument (#9038)Daniel Hahler2018-09-23
|/ / / | | | | | | | | | | | | Problem: printf() does not work with only one argument. (Daniel Hahler) Solution: Allow using just the format. (Ken Takata, closes vim/vim#2687) https://github.com/vim/vim/commit/c71807db9c1821baf86796cd76952df36ff1a29a
* | | vim-patch:8.1.0389: :behave command is not tested (#9030)Jan Edmund Lazo2018-09-23
| | | | | | | | | | | | | | | Problem: :behave command is not tested. Solution: Add a test. (Dominique Pelle, closes vim/vim#3429) https://github.com/vim/vim/commit/da1f71d75f0bf5d5ef876a09aa08fb19f6f24b3b
* | | Merge #9031 from janlazo/vim-8.1.0414Justin M. Keyes2018-09-23
|\ \ \
| * | | vim-patch:8.0.0370: invalid memory access when setting wildchar emptyJan Edmund Lazo2018-09-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: Invalid memory access when setting wildchar empty. Solution: Avoid going over the end of the option value. (Dominique Pelle, closes vim/vim#1509) Make option test check all number options with empty value. https://github.com/vim/vim/commit/a12e40351d1357687e8b5dc3122fffef705bdc08
| * | | vim-patch:8.0.0368: not all options are tested with a range of valuesJan Edmund Lazo2018-09-22
| | | | | | | | | | | | | | | | | | | | | | | | Problem: Not all options are tested with a range of values. Solution: Generate a test script from the source code. https://github.com/vim/vim/commit/2f5463df014a406a2b780068e341ef30a99c9b98
| * | | vim-patch:8.1.0414: v:option_old is cleared when using :set in OptionSet autocmdJan Edmund Lazo2018-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: v:option_old and v:option_new are cleared when using :set in OptionSet autocmd. (Gary Johnson) Solution: Don't trigger OptionSet recursively. https://github.com/vim/vim/commit/3f3fb0b14734272e7c817020c847aaa0fba5cea5
* | | | func_attr.h: FUNC_ATTR_PRINTFMichael Hoffmann2018-09-23
|/ / /
* | | Merge #8898 from justinmk/vim-8.1.0310Justin M. Keyes2018-09-22
|\ \ \ | | | | | | | | vim-patch:8.1.0310: file info msg with 'F' in 'shortmess'
| * | | test/old: test_options: Accommodate Nvim defaultJustin M. Keyes2018-09-21
| | | |
| * | | vim-patch:8.1.0310: file info msg with 'F' in 'shortmess'Justin M. Keyes2018-09-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: File info message not always suppressed with 'F' in 'shortmess'. (Asheq Imran) Solution: Save and restore msg_silent. (Christian Brabandt, closes vim/vim#3221) https://github.com/vim/vim/commit/2f0f871159b2cba862fcd41edab65b17da75c422 ref #8840 ref #9027
* | | | Merge pull request #9024 from bfredl/embed_ui2Björn Linse2018-09-22
|\ \ \ \ | | | | | | | | | | always wait for UI with --embed, unless --headless is supplied
| * | | | startup: always wait for UI with --embed, unless --headless also is suppliedBjörn Linse2018-09-22
|/ / / /
* / / / TUI: Reset cursor color when applicable #8572Yichao Zhou2018-09-22
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resets the TUI cursor color if: - current 'guicursor' mode does not specify a highlight group - cursor highlight group has "inverse" or "reverse" flag - on Nvim exit We interpret, "inverse" to mean "default cursor". Example: hi Cursor guifg=bg guibg=fg set termguicolors set guicursor=n-v-c-sm:block,i-ci-ve:ver25-Cursor,r-cr-o:hor20 * When the cursor shape is block, its color will be "inverse" * When the cursor shape is I-beam, its color will be `hi Cursor`. This is useful e.g. to prevent `set listchars=eol:¬` causing your cursor color to a low contrast color in insert mode because you cursor are often at EOL in insert mode. close #8572
* | | Merge #9023Justin M. Keyes2018-09-21
|\ \ \
| * | | man.vim: Fix very long justified lines #9023Justin M. Keyes2018-09-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When nroff justifies a line, it fills the line with whitespace to meet $MANWIDTH. With $MANWIDTH=9999, that of course results in nonsense (and behaves poorly with 'cursorline' option). To work around that, instead of trying to hard-justify the lines, just replace the mega-whitespace with a fixed size of 10 spaces. Perhaps N/Vim needs a "soft justify" feature?
| * | | man.vim: Ignore $MANWIDTH, use soft wrap #9023Doron Behar2018-09-21
| | | | | | | | | | | | | | | | | | | | fix #9017 close #9023
* | | | vim-patch:8.0.0682: no test for synIDtrans() (#8966)KunMing Xie2018-09-21
| | | | | | | | | | | | | | | | | | | | Problem: No test for synIDtrans(). Solution: Add a test. (Dominique Pelle, closes vim/vim#1796) https://github.com/vim/vim/commit/0b2eef24bcbe2c85c90bbde914a1782cbedc5c72
* | | | shell/logging: Fix E730 with verbose system({List}) #9009Justin M. Keyes2018-09-21
|/ / / | | | | | | | | | | | | | | | | | | | | | ref https://github.com/neovim/neovim/issues/9001#issuecomment-421843790 Steps to reproduce: :set verbose=9 :call system(['echo']) E730: using List as a String
* | | Merge #9022 from janlazo/vim-8.0.1215Justin M. Keyes2018-09-21
|\ \ \
| * | | lintJan Edmund Lazo2018-09-21
| | | |
| * | | replace fallthrough comment with macroJan Edmund Lazo2018-09-21
| | | | | | | | | | | | | | | | Follow-up of vim-patch:8.0.1215
| * | | vim-patch:8.0.1215: newer gcc warns for implicit fallthroughJan Edmund Lazo2018-09-20
| | | | | | | | | | | | | | | | | | | | | | | | Problem: Newer gcc warns for implicit fallthrough. Solution: Consistently use a FALLTHROUGH comment. (Christian Brabandt) https://github.com/vim/vim/commit/2f40d129bf45cd35976e4120336ae6d504f5a5dd
* | | | Merge pull request #9021 from bfredl/embed_fixBjörn Linse2018-09-20
|\ \ \ \ | |/ / / |/| | | startup: don't erase screen on `:hi Normal` during startup (for non-newgrid UIs)
| * | | startup: don't erase screen on `:hi Normal` during startupBjörn Linse2018-09-20
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | NB: existing `color default` test was actually enough to trigger the bug, when ext_newgrid=false is used. I created the `:hi Normal` test as I thought the builtin colors wouldn't set Normal (unless 'bg' is changed) But as the root cause actually comes from `:hi Normal`, it makes sense to still add the separate test (if `color default` here gets optimized to become a no-op, or something).
* | | doc: test/README.md (#9020)Daniel Hahler2018-09-20
| | | | | | | | | | | | | | | | | | - testdir location - no old style tests are left in the fixed list in the Makefile [ci skip]
* | | cleanup/TUI: remove old unused code #9013Justin M. Keyes2018-09-19
| | | | | | | | | | | | | | | | | | | | | | | | - Checks for ECHOE, ICANON were left over from Vim code. We already reference the symbols elsewhere without checking. - newline_on_exit, intr_char: Both are vestigial remnants of Vim 4.x, not implemented in Nvim. intr_char is a termios/stty feature, it's probably not useful because users have other ways to configure their terminals.
* | | Merge #9014 from justinmk/log-moreJustin M. Keyes2018-09-19
|\ \ \
| * | | log: RPC, input, other eventsJustin M. Keyes2018-09-19
| | | |
| * | | log: rename do_log to logmsgJustin M. Keyes2018-09-19
|/ / /
* | | test: system_spec: remove redundant clear()Justin M. Keyes2018-09-19
| | |
* | | Merge pull request #8754 from bfredl/embed_uiBjörn Linse2018-09-18
|\ \ \ | | | | | | | | startup: make --embed wait for first request so embedding UI can display startup messages
| * | | startup: wait for embedder before executing startup commands and filesBjörn Linse2018-09-18
|/ / / | | | | | | | | | | | | | | | Give embeders a chance to set up nvim, by processing a request before startup. This allows an external UI to show messages and prompts from --cmd and buffer loading (e.g. swap files)
* | | TUI: Skip redundant "stop" event (macOS kernel panic) (#9007)Justin M. Keyes2018-09-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the TUI suspends (:suspend, CTRL-z) it calls tui_terminal_stop (but does NOT set `ui->data=NULL`, so `tui_is_stopped` returns false). If the host terminal dies, it sends SIGCONT, SIGHUP (usually in that order): ERROR 2018-09-16T19:30:17.065 25821 suspend_event:1153: SIGCONT ERROR 2018-09-16T19:30:17.065 25821 on_signal:162: SIGHUP ERROR 2018-09-16T19:30:17.155 25821 on_signal:162: SIGHUP Race: if SIGHUP is handled before SIGCONT, it calls ui_builtin_stop() which schedules tui_stop before the TUI was resumed? libuv uv_close() aborts if the handle is already closed/closing. Somehow that causes macOS to panic. #8075 Assertion failed: (!uv__is_closing(handle)), function uv_close, file src/unix/core.c, line 117. Thread 0:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x00007fff67d69ec2 kevent + 10 1 libuv.1.dylib 0x000000010609304d uv__io_poll + 892 2 libuv.1.dylib 0x0000000106083904 uv_run + 339 3 nvim 0x0000000105e76f7b loop_poll_events + 74 4 nvim 0x0000000105fa5f51 ui_bridge_stop + 206 5 nvim 0x0000000105fa4c00 ui_builtin_stop + 50 6 nvim 0x0000000105f26ee9 mch_exit + 29 7 nvim 0x0000000105eda84a getout + 518 8 nvim 0x0000000105e778b3 multiqueue_process_events + 77 9 nvim 0x0000000105f24c5a os_breakcheck + 49 10 nvim 0x0000000105eb7ea3 auto_next_pat + 463 11 nvim 0x0000000105eb7603 apply_autocmds_group + 1289 12 nvim 0x0000000105eb0e8d apply_autocmds + 36 13 nvim 0x0000000105f5a412 screenalloc + 1892 14 nvim 0x0000000105f5b223 screen_resize + 190 15 nvim 0x0000000105fa52e3 ui_refresh + 257 16 nvim 0x0000000105e8c3d9 do_cmdline + 6614 17 nvim 0x0000000105f03a72 normal_execute + 3996 18 nvim 0x0000000105f89925 state_enter + 164 19 nvim 0x0000000105efe08d normal_enter + 125 20 nvim 0x0000000105ed9ffd main + 6858 21 libdyld.dylib 0x00007fff67c19115 start + 1 Thread 1 Crashed: 0 libsystem_kernel.dylib 0x00007fff67d68e3e __pthread_kill + 10 1 libsystem_pthread.dylib 0x00007fff67ea7150 pthread_kill + 333 2 libsystem_c.dylib 0x00007fff67cc5312 abort + 127 3 libsystem_c.dylib 0x00007fff67c8d368 __assert_rtn + 320 4 libuv.1.dylib 0x00000001060835bf uv_close + 247 5 nvim 0x0000000105fa0ebb tui_terminal_stop + 221 6 nvim 0x0000000105f9ff3d tui_stop + 14 7 nvim 0x0000000105e778b3 multiqueue_process_events + 77 8 nvim 0x0000000105fa0c89 tui_main + 302 9 libsystem_pthread.dylib 0x00007fff67ea46c1 _pthread_body + 340 10 libsystem_pthread.dylib 0x00007fff67ea456d _pthread_start + 377 11 libsystem_pthread.dylib 0x00007fff67ea3c5d thread_start + 13 TODO: - Set `ui->data = NULL` to flag UI as "stopped"? But loop_poll_events drains *all* fast_events, so could skip some events...
* | | Merge pull request #9011 from janlazo/vim-8.0.1428Justin M. Keyes2018-09-18
|\ \ \ | | | | | | | | vim-patch:8.0.{1428,1443}
| * | | vim-patch:8.0.1443: compiler complains about uninitialized variableJan Edmund Lazo2018-09-17
| | | | | | | | | | | | | | | | | | | | | | | | Problem: Compiler complains about uninitialized variable. (Tony Mechelynck) Solution: Assign a value to the variable. https://github.com/vim/vim/commit/059fd01021779ee369c1e55557275f6c349fda9e
| * | | vim-patch:8.0.1428: compiler warning on 64 bit MS-Windows systemJan Edmund Lazo2018-09-17
|/ / / | | | | | | | | | | | | | | | Problem: Compiler warning on 64 bit MS-Windows system. Solution: Change type from "int" to "size_t". (Mike Williams) https://github.com/vim/vim/commit/200ea8ffaa90e1ccc156b24ee097be87acdd5214
generated by cgit (git 2.34.1) at 2025-07-21 18:48:30 +0000