aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
...
* | | | build: Makefile: use _opt_pylint [ci skip] (#10720)Daniel Hahler2019-08-08
| | | | | | | | | | | | | | | | | | | | | | | | A separate rule it clearer, and allows for `make --keep-going lint` in general later. Ref: https://github.com/neovim/neovim/pull/10714
* | | | tests: output_spec: use shell-test REP_NODELAY (#10726)Daniel Hahler2019-08-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix flaky "shell command :! throttles shell-command output greater than ~10KB:": [ RUN ] shell command :! throttles shell-command output greater than ~10KB: warning: Screen changes were received after the expected state. This indicates indeterminism in the test. Try adding screen:expect(...) (or wait()) between asynchronous (feed(), nvim_input()) and synchronous API calls. - Use screen:redraw_debug() to investigate; it may find relevant intermediate states that should be added to the test to make it more robust. - If the purpose of the test is to assert state after some user input sent with feed(), adding screen:expect() before the feed() will help to ensure the input is sent when Nvim is in a predictable state. This is preferable to wait(), for being closer to real user interaction. - wait() can trigger redraws and consequently generate more indeterminism. Try removing wait(). ERR test/functional/ui/screen.lua:579: Failed to match any screen lines. Expected (anywhere): " %." Actual: |XXXXXXXXXX 591 | |XXXXXXXXXX 592 | |XXXXXXXXXX 593 | |XXXXXXXXXX 594 | | | | | |{3:-- TERMINAL --} | stack traceback: test/functional/ui/screen.lua:579: in function '_wait' test/functional/ui/screen.lua:367: in function 'expect' test/functional/ui/output_spec.lua:63: in function <test/functional/ui/output_spec.lua:53> Log: https://travis-ci.org/neovim/neovim/jobs/569082705#L5355 (gcc-functionaltest-lua)
* | | | build/MSVC: Fix HAVE_ICONV_H #10697erw72019-08-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: HAVE_ICONV_H is not true in MSVC Solution: Since iconv.h does not exist in the standard include directory in MSVC, CMAKE_REQUIRED_INCLUDES must be set. Note: This will be unnecessary after #10708.
* | | | build: port FindLibVterm to LibFindMacros (#10395)Daniel Hahler2019-08-08
| | | |
* | | | build: clean up / remove X_USE_STATIC (#10713)Daniel Hahler2019-08-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was discouraged (as an option) in 5b5d353151 [1], not enabled/used by default, and not working according to the comment in local.mk.example. Taken out of https://github.com/neovim/neovim/pull/10395. 1: https://github.com/neovim/neovim/pull/2465
* | | | ci: AppVeyor: fix upload of coverage for oldtest (#10721)Daniel Hahler2019-08-07
| |/ / |/| | | | | | | | | | | This was not working due to having another `python` in the PATH then. Ref: https://ci.appveyor.com/project/neovim/neovim/builds/26492761/job/dspm40v5l2v6gn40?fullLog=true#L15955
* | | Fix lualint: remove unused varDaniel Hahler2019-08-07
| | |
* | | cmakelists: fixed tests to avoid clang warnings (#10705)Ihor Antonov2019-08-07
| | | | | | | | | | | | * clang/"dead assignment" * clang/"Uninitialized argument value"
* | | tests: more cleanup of plugin/shada_specDaniel Hahler2019-08-07
| | | | | | | | | | | | | | | Ref: https://github.com/neovim/neovim/pull/10701/commits/330a6713#r311005754 Closes https://github.com/neovim/neovim/pull/10710.
* | | build: lint: fix exit with optional pylintDaniel Hahler2019-08-07
| | | | | | | | | | | | Ref: https://github.com/neovim/neovim/pull/10714#issuecomment-518932355
* | | Merge pull request #10703 from ngortheone/clang_dead2Björn Linse2019-08-07
|\ \ \ | | | | | | | | | | | | | | | | | | | | clang/"dead assignment": suppessed getchar.c Possibly invalid, read on line 1972: if (keylen >= 0 && keylen <= typebuf.tb_len) {
| * | | clang/"dead assignment": suppessedIhor Antonov2019-08-05
| | | | | | | | | | | | | | | | | | | | To ensure consistency and avoid possible errors in the code the assigment is considered to be legit.
* | | | Merge pull request #10513 from bfredl/bytecountBjörn Linse2019-08-06
|\ \ \ \ | | | | | | | | | | api/lua: add {byte_count} parameter to line region change event
| * | | | lua: support getting UTF-32 and UTF-16 sizes of replaced textBjörn Linse2019-08-06
| | | | |
| * | | | lua: add {old_byte_size} to on_lines buffer change eventBjörn Linse2019-08-06
| | |/ / | |/| |
* | | | Fix list_features to include space after first feature (#10711)Daniel Hahler2019-08-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Regressed in e134cc9d4a: the use of list_in_columns was not adding a space after the first features, because we do not start on a new line: > Features: -acl+iconv +tui This moves all the related code to `list_features`, and just joins them with spaces.
* | | | build: move pylint to Makefile, optional with "make lint" (#10714)Daniel Hahler2019-08-06
| | | | | | | | | | | | | | | | | | | | This avoids errors when using "make lint", but "flake8" is not available. We do not want to install it then via third-party. On CI "make pylint" is used explicitly.
* | | | tests: unit.helpers: provide string with write errors (#10715)Daniel Hahler2019-08-06
|/ / / | | | | | | | | | This might help to have more information in case of errors, like mentioned in https://github.com/neovim/neovim/commit/eec529cf9e.
* | | Merge #10701 from justinmk/test-fixesJustin M. Keyes2019-08-06
|\ \ \ | | | | | | | | test: Eliminate plugin/helpers.lua
| * | | test/mbyte_spec: skip broken test on QuickBuildJustin M. Keyes2019-08-06
| | | | | | | | | | | | | | | | Forgot `return` in eec529cf9e13.
| * | | test: Eliminate plugin/helpers.luaJustin M. Keyes2019-08-05
| | | |
* | | | Merge #10655 'environ(), getenv(), setenv()'Justin M. Keyes2019-08-06
|\ \ \ \ | | | | | | | | | | | | | | | close #10655
| * | | | f_environ: cleanup/refactorDaniel Hahler2019-08-06
| | | | | | | | | | | | | | | | | | | | | | | | | - use os_getenvname_at_index / os_getenv - f_getenv: empty (*p == NUL) is not null (undefined)
| * | | | vim-patch:8.1.1305: there is no easy way to manipulate environment variablesDaniel Hahler2019-08-06
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | Problem: There is no easy way to manipulate environment variables. Solution: Add environ(), getenv() and setenv(). (Yasuhiro Matsumoto, closes vim/vim#2875) https://github.com/vim/vim/commit/691ddeefb545d8488e5a495af61caba2e57b3de9
* / / / clang/"dead assignment": screen.c #10702Ihor Antonov2019-08-06
|/ / / | | | | | | | | | | | | | | | | | | Suppress the warning. mb_c and mb_l describe a char together, they are not independent variables. The coupled assignments are good practice to avoid future confusion, even if the current code doesn't use an assigned value.
* / / vim-patch:8.1.1439: ga_grow(): 1.5x growth rate #10699Jan Edmund Lazo2019-08-05
|/ / | | | | | | | | | | Problem: Json_encode() is very slow for large results. Solution: In the growarray use a growth of at least 50%. (Ken Takata, closes vim/vim#4461) https://github.com/vim/vim/commit/c47ed44be76a520ded90913099771999c8a79eeb
* | Merge pull request #10690 from bfredl/lua_printBjörn Linse2019-08-05
|\ \ | | | | | | lua: laundry list (crashes and additions)
| * | lua: add vim.in_fast_event() to check if we are in a luv callbackBjörn Linse2019-08-05
| | |
| * | lua: do not crash on syntax error in debug.debug()Björn Linse2019-08-05
| | |
| * | lua: immediate-callback safe print()Björn Linse2019-08-05
| | |
* | | Merge #10695 from justinmk/test-fixesJustin M. Keyes2019-08-05
|\ \ \ | | | | | | | | test: various fixes
| * | | test/man_spec: remove plugin_helpers.reset()Justin M. Keyes2019-08-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The call to plugin_helpers.reset() is redundant with the clear() call above it. Probably just a copy-paste mistake. Avoids exit_event race #8813. Helped-by: Björn Linse <bjorn.linse@gmail.com>
| * | | test/mbyte_spec: skip broken test on QuickBuildJustin M. Keyes2019-08-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 14:13:04,119 INFO - # ./test/unit/helpers.lua @ 760: mbyte utf_char2bytes for chars 0xa000 - 0xafff 14:13:06,307 WARN - E908: using an invalid value as a String /usr/home/quickbuild/buildagent/workspace/root/neovim/pull-requests-automated/.deps/usr/bin/luajit: ./test/unit/helpers.lua:459: write() error: 32: Broken pipe 14:13:06,308 WARN - stack traceback: 14:13:06,308 WARN - [C]: in function 'throw' 14:13:06,308 WARN - ...quests-automated/.deps/usr/share/lua/5.1/busted/core.lua:149: in function 'error' 14:13:06,308 WARN - ...ts-automated/.deps/usr/share/lua/5.1/luassert/assert.lua:171: in function 'assert' 14:13:06,308 WARN - ./test/unit/helpers.lua:459: in function 'write' 14:13:06,308 WARN - ./test/unit/helpers.lua:626: in function 'hook' 14:13:06,308 WARN - ./test/unit/helpers.lua:574: in function <./test/unit/helpers.lua:557> 14:13:06,308 WARN - [C]: in function 'type' 14:13:06,308 WARN - ...d/.deps/usr/share/lua/5.1/busted/outputHandlers/base.lua:57: in function 'copyElement' 14:13:06,308 WARN - ...d/.deps/usr/share/lua/5.1/busted/outputHandlers/base.lua:66: in function 'format' 14:13:06,308 WARN - ...d/.deps/usr/share/lua/5.1/busted/outputHandlers/base.lua:172: in function 'fn' 14:13:06,308 WARN - ...-requests-automated/.deps/usr/share/lua/5.1/mediator.lua:103: in function 'publish' 14:13:06,308 WARN - ...quests-automated/.deps/usr/share/lua/5.1/busted/core.lua:201: in function 'safe' 14:13:06,308 WARN - ...quests-automated/.deps/usr/share/lua/5.1/busted/core.lua:312: in function 'execute' 14:13:06,308 WARN - ...sts-automated/.deps/usr/share/lua/5.1/busted/execute.lua:58: in function 'execute' 14:13:06,308 WARN - ...ests-automated/.deps/usr/share/lua/5.1/busted/runner.lua:197: in function <...ests-automated/.deps/usr/share/lua/5.1/busted/runner.lua:11> 14:13:06,308 WARN - ./.deps/usr/lib/luarocks/rocks/busted/2.0.0-1/bin/busted:3: in main chunk 14:13:06,308 WARN - [C]: at 0x004041a0 14:13:06,323 WARN - Terminated 14:13:06,325 INFO - Executing post-execute action... 14:13:06,526 INFO - Checking step execute condition... 14:13:06,526 INFO - Step execute condition satisfied, executing... 14:13:06,706 INFO - Executing pre-execute action... 14:13:06,706 INFO - Running step...
| * | | test: isCI(): add "name" parameterJustin M. Keyes2019-08-05
| | | |
| * | | tests: fix flaky "TermClose … fast-exiting terminal job stops"Justin M. Keyes2019-08-05
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This extra retry() was removed (at my suggestion) in 5b94a2977a22, but it is probably needed: jobwait(…, timeout=0) could return while channel_process_exit_cb() is still queued (so TermClose event didn't fire yet). 20:46:21,288 INFO - not ok 547 - TermClose event triggers when fast-exiting terminal job stops 20:46:21,288 INFO - # test/functional/autocmd/termclose_spec.lua @ 20 20:46:21,288 INFO - # Failure message: ./test/functional/helpers.lua:98: Vim:E121: Undefined variable: g:test_termclose 20:46:21,288 INFO - # stack traceback: 20:46:21,288 INFO - # ./test/functional/helpers.lua:98: in function 'eval' 20:46:21,288 INFO - # test/functional/autocmd/termclose_spec.lua:25: in function <test/functional/autocmd/termclose_spec.lua:20>
* | | vim-patch:8.1.1383: warning for size_t/int mixup (#10694)Jan Edmund Lazo2019-08-05
| | | | | | | | | | | | | | | Problem: Warning for size_t/int mixup. Solution: Change type. (Mike Williams) https://github.com/vim/vim/commit/d33a764123a8aedb20cd84aeff3b94810ee67c4c
* | | :doautocmd : Never show "No matching autocommands" #10689Justin M. Keyes2019-08-05
| | | | | | | | | | | | | | | | | | | | | | | | The message is useless, it doesn't even mention the event name. vim_dev discussion: https://groups.google.com/forum/#!msg/vim_dev/RTbq58TMq9w/Xr4rSoUTCgAJ ref: https://github.com/vim/vim/issues/4300
* | | vim-patch:8.1.1311: test: abort autocmd with exception #10692Jan Edmund Lazo2019-08-05
| | | | | | | | | | | | | | | | | | Problem: Aborting an autocmd with an exception is not tested. Solution: Add a test. Also shows how to abort a command by throwing an exception. https://github.com/vim/vim/commit/23b5139234a79567097ca73aba15ea134381b934
* | | vim-patch:8.1.1251: test completion of mapping keys #10691Jan Edmund Lazo2019-08-05
|/ / | | | | | | | | Problem: No test for completion of mapping keys. Solution: Add a test. Also clean up the code. https://github.com/vim/vim/commit/2cb9f0253228478ec27265ff40f59c629874d695
* | Makefile: only use pattern rules with BUILD_TYPE=Ninja (#10687)Daniel Hahler2019-08-04
| | | | | | | | | | | | While not doing any harm with "Unix Makefiles", they do not work there as-is. Therefore just do not use them then. Followup to #10366 (7f6ff829a).
* | runtime/matchit.vim: workaround broken 'packpath'Justin M. Keyes2019-08-04
| | | | | | | | fix #10680
* | Merge #10161 from equalsraf/tb-clipboard-reloadJustin M. Keyes2019-08-04
|\ \ | | | | | | Support "reload" of providers
| * | provider: check #Call() if g:loaded_xx_provider=2Justin M. Keyes2019-08-04
| | |
| * | health.vim: check has("debug")Justin M. Keyes2019-08-04
| | |
| * | provider: skip non-provider has() feature-namesJustin M. Keyes2019-08-04
| | | | | | | | | | | | | | | We don't want to retry autoload sourcing (slow) for every random has() query that finds it way to eval_call_provider().
| * | provider: g:loaded_xx_provider=2 means "enabled and working"Justin M. Keyes2019-08-04
| | | | | | | | | | | | | | | Value of 1 cannot be used, because users might set that in their vimrc to _disable_ a provider, which would confuse :checkhealth and has().
| * | provider: decide status by g:loaded_xx_providerJustin M. Keyes2019-08-04
| | |
| * | provider: let providers decide their statusRui Abreu Ferreira2019-08-04
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of deciding provider status in eval_has_provider, move the decision to the provider Vim scripts. Previously, provider loading worked as follows: 1. eval_has_provider() verified provider availability by searching for the provider#providername#Call function and cached this verificaion as a static variable for some providers 2. providers short-circuited on loading to prevent the definition of the Call function (with the exception of the node provider that did not) This commit changes the expected interface between nvim and its providers to facilitate provider reloading, by splitting the verification of the provider from the availability of the Call function. eval_has_provider() now checks for a provider#providername#enabled variable. It is up to the provider script to set this to 0 or 1 accordingly. eval_call_provider() remains unchanged. All providers hosting a Call function were updated to respect this. The clipboard provider now has a Reload function to reload the provider.
* | doc: update 'shellredir' advice for powershell #10686Jan Edmund Lazo2019-08-04
| | | | | | | | | | | | | | | | | | | | | | Encoding can be utf8, unicode, utf32. User can choose to omit '-Encoding' to default to 'unicode'. 'ascii' encoding corrupts the following file: https://www.w3.org/2001/06/utf-8-test/UTF-8-demo.html Inspect 'foo.txt' with the following code after downloading the file. Get-Content -Encoding UTF8 UTF-8-demo.html | Out-File -Encoding ascii foo.txt
* | Merge #10683 from janlazo/vim-8.1.1796Justin M. Keyes2019-08-03
|\ \ | | | | | | vim-patch:8.1.{1237,1796}