aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
...
* test: Remove whitespace (avoid LF/CRLF discrepancy)Justin M. Keyes2017-02-04
|
* Revert "tui: update_size(): Fix race condition."Justin M. Keyes2017-02-04
| | | | This reverts commit 0e75438a388f91c6219d2f22ade0472b067f5dca.
* Revert "build: LuaRocks: require unzip (#6049)"Justin M. Keyes2017-02-04
| | | | This reverts commit 54293b73d4bef32eca7f5d6b3a3f177379940a49.
* tests: Migrate legacy test 8. #4179Lucas Hoffmann2017-02-03
| | | | | The test produces some "hit enter" prompts and error messages that had to be dealt with by `feed`ing CTRL-L to nvim.
* Merge #2990 'tests: Migrate legacy test 69.'Justin M. Keyes2017-02-03
|\
| * tests: Modernize migrated legacy test 69.Lucas Hoffmann2017-02-03
| |
| * tests: Migrate legacy test 69.Lucas Hoffmann2016-05-23
| |
* | build: LuaRocks: require unzip (#6049)Matthieu Coudron2017-02-04
| |
* | Merge pull request #6050 from jamessan/fix-xclip-testsJames McCoy2017-02-03
|\ \ | | | | | | Fix xclip tests to cleanup on their own
| * | test: Turn printargs_path into a functionJames McCoy2017-02-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When test/functional/eval/system_spec.lua is run on its own, helpers.os_name() was being called before a session had been created. This caused that describe block to fail. Turning printargs_path into a function delays the call of helpers.os_name() until the test is being run, which ensures a session is available.
| * | test: Make xclip exit after one selection requestJames McCoy2017-02-02
| | | | | | | | | | | | Closes #4900
* | | tui: update_size(): Fix race condition.Justin M. Keyes2017-02-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bridge.width and bridge.height reach ui.c:ui_refresh() when it iterates through all UIs, so they do not need to be set directly by tui.c:update_size(). Race found by helgrind: ==18532== Helgrind, a thread error detector ==18532== Copyright (C) 2007-2015, and GNU GPL'd, by OpenWorks LLP et al. ==18532== Using Valgrind-3.12.0 and LibVEX; rerun with -h for copyright info ==18532== Command: ./build/bin/nvim -u NONE --cmd set\ rtp+=~/.vim/bundle/vimfiler.vim,~/.vim/bundle/unite.vim --cmd runtime\ plugin/vimfiler.vim --cmd runtime\ plugin/unite.vim ==18532== Parent PID: 6477 ==18532== ==18532== ---Thread-Announcement------------------------------------------ ==18532== ==18532== Thread #2 was created ==18532== at 0x68FA98E: clone (clone.S:73) ==18532== by 0x5270179: create_thread (createthread.c:102) ==18532== by 0x5271BE2: pthread_create@@GLIBC_2.2.5 (pthread_create.c:679) ==18532== by 0x4C32B07: pthread_create_WRK (hg_intercepts.c:427) ==18532== by 0x4E53A3F: uv_thread_create (in /usr/lib/x86_64-linux-gnu/libuv.so.1.0.0) ==18532== by 0x6A7154: ui_bridge_attach (ui_bridge.c:89) ==18532== by 0x6A164C: tui_start (tui.c:116) ==18532== by 0x6A4CFC: ui_builtin_start (ui.c:89) ==18532== by 0x55A825: main (main.c:433) ==18532== ==18532== ---Thread-Announcement------------------------------------------ ==18532== ==18532== Thread #1 is the program's root thread ==18532== ==18532== ---------------------------------------------------------------- ==18532== ==18532== Possible data race during write of size 4 at 0x770E7B4 by thread #2 ==18532== Locks held: none ==18532== at 0x6A3071: update_size (tui.c:759) ==18532== by 0x6A30DB: sigwinch_cb (tui.c:269) ==18532== by 0x4D0A54: signal_event (signal.c:44) ==18532== by 0x4CDDB6: multiqueue_process_events (multiqueue.c:146) ==18532== by 0x4CD135: loop_poll_events (loop.c:56) ==18532== by 0x6A2451: tui_main (tui.c:239) ==18532== by 0x6A857A: ui_thread_run (ui_bridge.c:112) ==18532== by 0x4E539F6: ??? (in /usr/lib/x86_64-linux-gnu/libuv.so.1.0.0) ==18532== by 0x4C32D06: mythread_wrapper (hg_intercepts.c:389) ==18532== by 0x5271423: start_thread (pthread_create.c:333) ==18532== by 0x68FA9BE: clone (clone.S:105) ==18532== ==18532== This conflicts with a previous read of size 4 by thread #1 ==18532== Locks held: none ==18532== at 0x6A542A: ui_refresh (ui.c:169) ==18532== by 0x6A5870: ui_refresh_event (ui.c:181) ==18532== by 0x4CDDB6: multiqueue_process_events (multiqueue.c:146) ==18532== by 0x4CD135: loop_poll_events (loop.c:56) ==18532== by 0x5DEDB4: os_breakcheck (input.c:150) ==18532== by 0x59263D: line_breakcheck (misc1.c:2667) ==18532== by 0x621AE5: nfa_regmatch (regexp_nfa.c:6171) ==18532== by 0x61DCF7: nfa_regtry (regexp_nfa.c:6240) ==18532== Address 0x770e7b4 is 4 bytes inside a block of size 352 alloc'd ==18532== at 0x4C2EFE5: calloc (vg_replace_malloc.c:711) ==18532== by 0x57C962: xcalloc (memory.c:119) ==18532== by 0x6A6E29: ui_bridge_attach (ui_bridge.c:53) ==18532== by 0x6A164C: tui_start (tui.c:116) ==18532== by 0x6A4CFC: ui_builtin_start (ui.c:89) ==18532== by 0x55A825: main (main.c:433) ==18532== Block was alloc'd by thread #1 ==18532== ==18532== ---------------------------------------------------------------- ==18532== ==18532== Possible data race during write of size 4 at 0x770E7B8 by thread #2 ==18532== Locks held: none ==18532== at 0x6A3085: update_size (tui.c:760) ==18532== by 0x6A30DB: sigwinch_cb (tui.c:269) ==18532== by 0x4D0A54: signal_event (signal.c:44) ==18532== by 0x4CDDB6: multiqueue_process_events (multiqueue.c:146) ==18532== by 0x4CD135: loop_poll_events (loop.c:56) ==18532== by 0x6A2451: tui_main (tui.c:239) ==18532== by 0x6A857A: ui_thread_run (ui_bridge.c:112) ==18532== by 0x4E539F6: ??? (in /usr/lib/x86_64-linux-gnu/libuv.so.1.0.0) ==18532== by 0x4C32D06: mythread_wrapper (hg_intercepts.c:389) ==18532== by 0x5271423: start_thread (pthread_create.c:333) ==18532== by 0x68FA9BE: clone (clone.S:105) ==18532== ==18532== This conflicts with a previous read of size 4 by thread #1 ==18532== Locks held: none ==18532== at 0x6A5455: ui_refresh (ui.c:170) ==18532== by 0x6A5870: ui_refresh_event (ui.c:181) ==18532== by 0x4CDDB6: multiqueue_process_events (multiqueue.c:146) ==18532== by 0x4CD135: loop_poll_events (loop.c:56) ==18532== by 0x5DEDB4: os_breakcheck (input.c:150) ==18532== by 0x59263D: line_breakcheck (misc1.c:2667) ==18532== by 0x621AE5: nfa_regmatch (regexp_nfa.c:6171) ==18532== by 0x61DCF7: nfa_regtry (regexp_nfa.c:6240) ==18532== Address 0x770e7b8 is 8 bytes inside a block of size 352 alloc'd ==18532== at 0x4C2EFE5: calloc (vg_replace_malloc.c:711) ==18532== by 0x57C962: xcalloc (memory.c:119) ==18532== by 0x6A6E29: ui_bridge_attach (ui_bridge.c:53) ==18532== by 0x6A164C: tui_start (tui.c:116) ==18532== by 0x6A4CFC: ui_builtin_start (ui.c:89) ==18532== by 0x55A825: main (main.c:433) ==18532== Block was alloc'd by thread #1
* | | Merge #5975 from jamessan/execute-with-attrsJustin M. Keyes2017-02-03
|\ \ \ | |/ / |/| | execute: Correctly capture output with highlight attributes
| * | test: execute() + :redirJustin M. Keyes2017-02-01
| | |
| * | execute: Correctly capture output with highlight attributesJames McCoy2017-02-01
| | | | | | | | | | | | Closes #5422
* | | Merge pull request #5869 from hardenedapple/undojoin-curheadJames McCoy2017-02-02
|\ \ \ | | | | | | | | Don't set `b_u_curhead` in `ex_undojoin()`
| * | | Don't set b_u_curhead in ex_undojoin()Matthew Malcomson2017-01-22
| | | | | | | | | | | | | | | | | | | | vim-patch:8.0.0205 This provides no benefit, and introduces some bugs.
* | | | Merge pull request #6045 from jamessan/vim-a02a551James McCoy2017-02-01
|\ \ \ \ | |_|/ / |/| | | vim-patch:a02a551,802a0d9,e18dbe8,063b9d1
| * | | vim-patch:063b9d1James McCoy2017-02-01
| | | | | | | | | | | | | | | | | | | | | | | | Updated runtime files. https://github.com/vim/vim/commit/063b9d15abea041a5bfff3ffc4e219e26fd1d4fa
| * | | Run cleanup.vim on {eo,fr}.poJames McCoy2017-02-01
| | | |
| * | | vim-patch:e18dbe8James McCoy2017-02-01
| | | | | | | | | | | | | | | | | | | | | | | | Updated runtime files. https://github.com/vim/vim/commit/e18dbe865d190e74fb5d43ac8bc6ac22507d0223
| * | | vim-patch:802a0d9James McCoy2017-02-01
| | | | | | | | | | | | | | | | | | | | | | | | Updated runtime files. https://github.com/vim/vim/commit/802a0d902fca423acb15f835d7b09183883d79a0
| * | | vim-patch:a02a551James McCoy2017-02-01
|/ / / | | | | | | | | | | | | | | | Updated runtime files. https://github.com/vim/vim/commit/a02a551e18209423584fcb923e93c6be18f3aa45
* | | doc: QuickBuildJustin M. Keyes2017-01-31
| | |
* | | xstrlcat: Allow overlapped pointers. (#6017)Justin M. Keyes2017-01-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | memcpy is not equivalent to memmove (which is used by vim_strcat), this could cause subtle bugs if xstrlcat is used as a replacement for vim_strcat. But vim_strcat is inconsistent: in the `else` branch it uses strcpy, which doesn't allow overlap. Helped-by: oni-link <knil.ino@gmail.com> Helped-by: James McCoy <jamessan@jamessan.com> Helped-by: Nikolai Aleksandrovich Pavlov <kp-pav@yandex.ru>
* | | undo: :earlier, g-: Set b_u_seq_cur correctly. (#6016)Matthew Malcomson2017-01-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously alternate branches were not accounted for properly, with this change g- after an undo to a branch point works. The current sequence number b_u_seq_cur is used in undo_time(), in u_doit() this was calculated by subtracting one from the curhead sequence number. The curhead header entry represents the change that was just undone, so the sequence number we want is that of the change we have moved to. This is the sequence number of the undo head that is the uh_next element of this curhead. That sequence number is not always one less than the curhead sequence number -- there may have been an alternate branch at this point. Instead of subtracting one, we now directly find the sequence number of curhead->uh_next.
* | | man.vim: get page after opening split (#6032)Anmol Sethi2017-01-31
| | | | | | | | | This will ensure that $MANWIDTH is correctly set.
* | | man.vim: remove terminal escape characters (#6033)Anmol Sethi2017-01-31
| | | | | | | | | This will make man.vim work on nixOS.
* | | dist: runtime/nvim.desktopMatthieu Coudron2017-01-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #3689 cmake: Add `desktop-install` and `icon-install` targets. `runtime` target will trigger them. Specification: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#recognized-keys Icons are stored system-wide in /usr/share/applications or user wide at /usr/share/icons/hicolor/scalable/apps and can be overriden in ~/.local/share/icons nvim.desktop file can be installed system wide or in ~/.local/share/applications/ To test without an installer: $ xdg-desktop-menu install --novendor runtime/nvim.desktop $ xdg-icon-resource install --novendor --mode user --size 64 contrib/nvim-icon.png Once it is installed, you can test with gtk-launch if installed or dmenu/rofi (drun mode)
* | | eval.c: Fix findfile(), :find, gf in :terminal. #6009Tommy Allen2017-01-31
| | | | | | | | | | | | Closes #4299
* | | defaults: Revert 'mouse=a' (#6022)Justin M. Keyes2017-01-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This default causes too much confusion for terminal users. Until a better approach is implemented, revert to the traditional default. Better solution would be: - Implement a right-click menu for TUI - Set 'mouse=a' *only* if clipboard is working. Closes #5938
* | | Merge pull request #6012 from jamessan/override-TI-cursor-normalJames McCoy2017-01-26
|\ \ \ | | | | | | | | tui: Ignore DECRST 12 in terminfo's cursor_normal, if present
| * | | tui: Ignore DECRST 12 in terminfo's cursor_normal, if presentJames McCoy2017-01-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As discussed in neovim/neovim#5977, it's typical for the terminfo database to disable cursor blink as part of setting up the normal cursor. Since this interferes with the user's control over the cursor, we'll skip over DECRST 12 if it starts the cursor_normal entry. Note, this doesn't handle any case where DECRST 12 is not at the start of the entry since unibilium simply stores the given pointer. We would need to allocate (and somewhere free) a modified copy of what we get back from unibi_get_str to handle that.
* | | | refactor: Remove strncpy/STRNCPY. (#6008)Justin M. Keyes2017-01-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes #731 References #851 Note: This does not remove some intentional legacy usages of strncpy. - memcpy isn't equivalent because it doesn't check the string length of `src`, and doesn't zero-out the remainder of `dst`. - xstrlcpy isn't equivalent because it doesn't zero-out the remainder of `dst`. Some Vim logic depends on that (e.g. ex_append which calls vim_strnsave). Helped-by: Douglas Schneider <ds3@ualberta.ca> Helped-by: oni-link <knil.ino@gmail.com> Helped-by: James McCoy <jamessan@jamessan.com>
* | | | build: Disable jemalloc for FreeBSD. (#6007)Justin M. Keyes2017-01-26
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | jemalloc's README states: > jemalloc [is] the FreeBSD libc allocator since 2005. ... Modern jemalloc > releases continue to be integrated back into FreeBSD Since FreeBSD ships with jemalloc in some form, we don't need to require jemalloc there. Less risk, low cost.
* | | test: Fix broken test.Justin M. Keyes2017-01-24
| | |
* | | Merge #5964 from equalsraf/windows-clipboardJustin M. Keyes2017-01-24
|\ \ \ | | | | | | | | Windows clipboard support
| * | | Windows: Install runtime dependencies with Neovim binaryRui Abreu Ferreira2017-01-20
| | | | | | | | | | | | | | | | | | | | | | | | Look for runtime dependencies diff.exe and win32yank.exe (and recursively for DLL dependencies) and install them with nvim.exe. If a dependency is missing a warning will be issued.
| * | | Enable clipboard provider tests in WindowsRui Abreu Ferreira2017-01-20
| | | |
| * | | third-party: Add helper to fetch binary dependenciesRui Abreu Ferreira2017-01-20
| | | | | | | | | | | | | | | | | | | | Add cmake script with recipes to download binary dependencies, currently the only dependency is win32yank.
| * | | Windows: Clipboard provider win32yankRui Abreu Ferreira2017-01-20
| | | |
* | | | ci: XXX: Disable "throttle" test on Travis macOS.Justin M. Keyes2017-01-23
| | | |
* | | | Merge #5996 from justinmk/coverity-133845Justin M. Keyes2017-01-23
|\ \ \ \ | | | | | | | | | | xstrlcat() + coverity fixes
| * | | | clint.py: Suggest xstrlcat instead of strcat.Justin M. Keyes2017-01-23
| | | | |
| * | | | refactor: Replace vim_strcat() with xstrlcat().Justin M. Keyes2017-01-23
| | | | |
| * | | | coverity/133853: Out-of-bounds accessJustin M. Keyes2017-01-23
| | | | |
| * | | | coverity/155512: Pass correct length to strncat()Justin M. Keyes2017-01-23
| | | | | | | | | | | | | | | | | | | | References 8bc2bffda94bf2de4e8adae57b4b5597ed4e8247
| * | | | coverity/133845: Negative array index read. (FP)Justin M. Keyes2017-01-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `find_command(s->ca.cmdchar) >= 0` was established near the start of normal_execute(). And `unshift_special(&s->ca);` "should" not ever result in s->ca.cmdchar containing a multibyte char. So only an assert() is needed here.
| * | | | errors: Introduce "E856: Filename too long"Justin M. Keyes2017-01-23
| | | | |
| * | | | add_pathsep(): Return false if filename is too long.cztchoice2017-01-23
| | | | | | | | | | | | | | | | | | | | References #3042
generated by cgit (git 2.34.1) at 2025-06-26 02:02:27 +0000