| Commit message (Collapse) | Author | Age |
|
|
|
| |
https://github.com/neovim/neovim/issues/7572#issuecomment-345257295
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closes #7572
closes #7579
closes #7628
ASAN report:
==9500==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6040000024c0 at pc 0x00000187d2ca bp 0x7fc3c6e58d10 sp 0x7fc3c6e58d08
READ of size 8 at 0x6040000024c0 thread T1
0 0x187d2c9 in ugrid_put /home/vagrant/neovim/build/../src/nvim/ugrid.c:107:17
1 0x1850adf in tui_put /home/vagrant/neovim/build/../src/nvim/tui/tui.c:1012:10
2 0x18a6ce6 in ui_bridge_put_event /home/vagrant/neovim/build/src/nvim/auto/ui_events_bridge.generated.h:154:3
3 0xa4dcda in multiqueue_process_events /home/vagrant/neovim/build/../src/nvim/event/multiqueue.c:150:7
4 0xa478bf in loop_poll_events /home/vagrant/neovim/build/../src/nvim/event/loop.c:63:3
5 0x185451c in tui_main /home/vagrant/neovim/build/../src/nvim/tui/tui.c:362:12
6 0x18a3080 in ui_thread_run /home/vagrant/neovim/build/../src/nvim/ui_bridge.c:106:3
7 0x7fc3caaac6b9 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9)
8 0x7fc3c9ca33dc in clone /build/glibc-bfm8X4/glibc-2.23/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:109
0x6040000024c0 is located 0 bytes to the right of 48-byte region [0x604000002490,0x6040000024c0)
allocated by thread T1 here:
0 0x50e048 in malloc (/home/vagrant/neovim/build/bin/nvim+0x50e048)
1 0xf7ab71 in try_malloc /home/vagrant/neovim/build/../src/nvim/memory.c:87:15
2 0xf7ad99 in xmalloc /home/vagrant/neovim/build/../src/nvim/memory.c:121:15
3 0x187937b in ugrid_resize /home/vagrant/neovim/build/../src/nvim/ugrid.c:32:17
4 0x184be58 in tui_resize /home/vagrant/neovim/build/../src/nvim/tui/tui.c:770:3
5 0x18a3dc8 in ui_bridge_resize_event /home/vagrant/neovim/build/src/nvim/auto/ui_events_bridge.generated.h:4:3
6 0xa4dcda in multiqueue_process_events /home/vagrant/neovim/build/../src/nvim/event/multiqueue.c:150:7
7 0xa478bf in loop_poll_events /home/vagrant/neovim/build/../src/nvim/event/loop.c:63:3
8 0x185451c in tui_main /home/vagrant/neovim/build/../src/nvim/tui/tui.c:362:12
9 0x18a3080 in ui_thread_run /home/vagrant/neovim/build/../src/nvim/ui_bridge.c:106:3
10 0x7fc3caaac6b9 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x76b9)
Thread T1 created by T0 here:
0 0x4655ed in __interceptor_pthread_create (/home/vagrant/neovim/build/bin/nvim+0x4655ed)
1 0x1ad87b0 in uv_thread_create /home/vagrant/neovim/.deps/build/src/libuv/src/unix/thread.c:75
2 0x184b9aa in tui_start /home/vagrant/neovim/build/../src/nvim/tui/tui.c:159:10
3 0x188dd4c in ui_builtin_start /home/vagrant/neovim/build/../src/nvim/ui.c:125:3
4 0xe6d399 in main /home/vagrant/neovim/build/../src/nvim/main.c:457:5
5 0x7fc3c9bbc82f in __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:291
|
|\ |
|
|/
|
|
| |
Closes #7859
|
|\ |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Problem: Cursor column is not updated after ]s. (Gary Johnson)
Solution: Set the curswant flag.
https://github.com/vim/vim/commit/b73fa629d6d3d705c1f8e8d5f8109fc9abd7bb6f
|
| |
| |
| |
| |
| |
| |
| | |
Problem: No check for spell region being zero. (geeknik)
Solution: Check for zero. (closes vim/vim#2252)
https://github.com/vim/vim/commit/ee03b941241eae1d36bc29b84eec09116cefe7cd
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Problem: Spell test leaves files behind.
Solution: Delete the files.
https://github.com/vim/vim/commit/1a0f2005002a9993ba7313d1978fa2043314f8b8
|
| |
| |
| |
| |
| |
| |
| | |
Problem: Spell test is old style.
Solution: Turn the spell test into a new style test (pschuh, closes vim/vim#1778)
https://github.com/vim/vim/commit/d2c061d24c0534f1f1b92f3462ed6ae8fa848a9a
|
| |
| |
| |
| |
| |
| |
| | |
Problem: No test coverage for :spellrepall.
Solution: Add a test. (Dominique Pelle, closes vim/vim#1717)
https://github.com/vim/vim/commit/545cb79da586be3333a0a55616046f94b01f6b1a
|
| |
| |
| |
| |
| |
| |
| | |
Install en.utf-8.spl by default.
- Allows spell-related tests to run.
- Avoids download prompt for spelllang=en users
|
| |
| |
| |
| |
| |
| |
| |
| | |
Problem: Illegal memory access with z= command. (Dominique Pelle)
Solution: Avoid case folded text to be longer than the original text. Use
MB_PTR2LEN() instead of MB_BYTE2LEN().
https://github.com/vim/vim/commit/5b276aa80e112ae1993bd43e28f599f257827c54
|
| |
| |
| |
| |
| |
| | |
Problem: Invalid memory access when using :sc in Ex mode. (Dominique Pelle)
Solution: Avoid the column being negative. Also fix a hang in Ex mode.
https://github.com/vim/vim/commit/ba748c8a847561c043a63827bcb1d98bdebe16e6
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
vim-patch:8.0.0151
Problem: To pass buffer content to system() and systemlist() one has to
first create a string or list.
Solution: Allow passing a buffer number. (LemonBoy,
closes vim/vim#1240)
https://github.com/vim/vim/commit/12c4492dd35e0cd83c8816be2ec849b836109882
vim-patch:8.0.0153
Problem: system() test fails on MS-Windows.
Solution: Deal when extra space and CR.
https://github.com/vim/vim/commit/9d9c35651712b88c81f1ae11091de1fd0bbbd35c
vim-patch:8.0.0154
Problem: system() test fails on OS/X.
Solution: Deal with leading spaces.
https://github.com/vim/vim/commit/31f19ce0a052f7c76d44a9a190e468c79cf5d56d
|
|\ \
| | |
| | | |
Add a way to collect list usage statistics
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
New logging is guarded by cmake LOG_LIST_ACTIONS define. To make it more
efficient it is allocated as a linked list with chunks of length
2^(7+chunk_num); that uses basically the same idea as behind increasing kvec
length (make appending O(1) (amortized)), but reduces constant by not bothering
to move memory around what realloc() would surely do: it is not like we need
random access to log entries here to justify usage of a single continuous memory
block.
|
| | | |
|
| |/ |
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Problem: The arabic shaping code is verbose.
Solution: Shorten the code without changing the functionality.
https://github.com/vim/vim/commit/7f73b54631af3f0e6f0acd1a1b4c9e8436784705
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Problem: Arabic support is verbose and not well tested.
Solution: Simplify the code. Add more tests.
https://github.com/vim/vim/commit/5f53dd3f747711be90879fa2f22a207970b86750
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Problem: Test for arabic does not check what is displayed.
Solution: Improve what is asserted. (Dominique Pelle, closes vim/vim#1523)
Add a first shaping test.
https://github.com/vim/vim/commit/5342f00ff95ed0256b8183063a83d72112f1243c
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Problem: No tests for arabic.
Solution: Add a first test for arabic. (Dominique Pelle, closes vim/vim#1518)
https://github.com/vim/vim/commit/b5e8377364110ee70090274da15d202778e96a64
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Problem: Diff mode is not sufficiently tested.
Solution: Add more diff mode tests. (Dominique Pelle, closes vim/vim#1515)
https://github.com/vim/vim/commit/aeb661e1f4a491286ef7af8c3105aff1f3b16f1c
|
| |/
| |
| |
| |
| |
| |
| |
| |
| | |
Problem: With 'linebreak' set and 'breakat' includes ">" a double-wide
character results in "<<" displayed.
Solution: Check for the character not to be replaced. (Ozaki Kiichi,
closes vim/vim#1456)
https://github.com/vim/vim/commit/38632faf635f6434441827e136bceb5a930c59ad
|
|\ \ |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
*** CID 161216: Memory - illegal accesses (RETURN_LOCAL)
/src/nvim/eval.c: 11143 in get_user_input()
11137 rettv->vval.v_string =
11138 (char_u *)getcmdline_prompt(inputsecret_flag ? NUL : '@', p, echo_attr,
11139 xp_type, xp_arg, input_callback);
11140 ex_normal_busy = save_ex_normal_busy;
11141 callback_free(&input_callback);
11142
>>> CID 161216: Memory - illegal accesses (RETURN_LOCAL)
>>> Using "cancelreturn", which points to an out-of-scope variable "def".
11143 if (rettv->vval.v_string == NULL && cancelreturn != NULL) {
11144 rettv->vval.v_string = (char_u *)xstrdup(cancelreturn);
11145 }
11146
11147 xfree(xp_arg);
11148
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
*** CID 169163: Null pointer dereferences (FORWARD_NULL)
/src/nvim/eval/decode.c: 290 in decode_string()
284 if (elw_ret == -1) {
285 tv_clear(&tv);
286 return (typval_T) { .v_type = VAR_UNKNOWN, .v_lock = VAR_UNLOCKED };
287 }
288 return tv;
289 } else {
>>> CID 169163: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "s" to "xmemdupz", which dereferences it. (The dereference is assumed on the basis of the 'nonnull' parameter attribute.)
290 return (typval_T) {
291 .v_type = VAR_STRING,
292 .v_lock = VAR_UNLOCKED,
293 .vval = { .v_string = (char_u *)(
294 s_allocated ? (char *)s : xmemdupz(s, len)) },
295 };
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Problem: Diff mode is displayed wrong when adding a line at the end of a
buffer.
Solution: Adjust marks in diff mode. (James McCoy, closes vim/vim#1329)
https://github.com/vim/vim/commit/f58a8475e17bd566760fc7e2a17d35ddf4edacf2
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Problem: :map completion does not have <special>. (Dominique Pelle)
Solution: Recognize <special> in completion. Add a test.
https://github.com/vim/vim/commit/cf5fdf7d1689ecb145b634dcb9c6e9fc60f63869
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | | |
Problem: Illegal memory access with "t".
Solution: Use strncmp() instead of memcmp(). (Dominique Pelle, closes vim/vim#1528)
https://github.com/vim/vim/commit/66727e16079fbac6db3897b5c3736ec9fba995bb
|
| | | |
|
| | | |
|
|/ /
| |
| |
| |
| | |
Error detected while processing function man#open_page[58]..<SNR>54_put_page:
line 8:
E5105: Error while calling lua chunk: /usr/share/nvim/runtime/lua/man.lua:165: Vim(let):E805: Using a Float as a Number
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
| |
vim-patch:8.0.0364: ]s does not move cursor with two spell errors in one line
Problem: ]s does not move cursor with two spell errors in one line. (Manuel
Ortega)
Solution: Don't stop search immediately when wrapped, search the line first.
(Ken Takata) Add a test.
https://github.com/vim/vim/commit/d3f78dc9ebd729475a7f24a50a91112e300d5ac9
* disable spell test for now
|
|\ |
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement nvim_command_output with `execute({cmd},"silent")`.
Behavior changes:
- does not provoke any hit-enter prompt
- no longer prepends a newline char
- does not capture some noise (like the "[New File]" message, see the
change to tabnewentered_spec.lua)
Technically ("bug-for-bug") this a breaking change. But the previous
behavior of nvim_command_output meant that it probably wasn't used for
anything outside of tests.
Also remove the undocumented `v:command_output` variable which was
a hack introduced only for the purposes of nvim_command_output.
closes #7726
|
|
|
|
|
|
|
|
|
|
|
|
| |
Workaround for this fun new issue:
==27404==LeakSanitizer has encountered a fatal error.
==27404==HINT: For debugging, try setting environment variable LSAN_OPTIONS=verbosity=1:log_threads=1
==27404==HINT: LeakSanitizer does not work under ptrace (strace, gdb, etc)
Failed: E /build|logs :: Runtime errors detected.
https://github.com/travis-ci/travis-ci/issues/9033
https://github.com/google/sanitizers/issues/764
|
| |
|
|\ |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|