| Commit message (Collapse) | Author | Age |
... | |
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
- cursel argument for qf_list_entry() changed from int to bool
- Return type of qf_list_has_valid_entries() changed from int to bool
- Unnecessary size_t casting in qf_new_list removed
- Use Doxygen-style comment blocks for functions
|
| |
| |
| |
| |
| |
| |
| | |
Problem: Cannot navigate through errors relative to the cursor.
Solution: Add :cabove, :cbelow, :labove and :lbelow. (Yegappan Lakshmanan,
closes vim/vim#4316)
https://github.com/vim/vim/commit/3ff33114d70fc0f7e9c3187c5fec9028f6499cf3
|
| |
| |
| |
| |
| |
| | |
Problem: Duplicate code in quickfix file.
Solution: Move code into functions. (Yegappan Lakshmanan, closes vim/vim#4207)
https://github.com/vim/vim/commit/87f59b09ea4b9af2712598374a6044f5fa1b54a4
|
| |
| |
| |
| |
| |
| |
| | |
Problem: Quickfix code duplication.
Solution: Refactor the qf_init_ext() function. (Yegappan Lakshmanan,
closes vim/vim#4193)
https://github.com/vim/vim/commit/95946f1209ad088bfe55c83256c299156c11d8e0
|
| |
| |
| |
| |
| |
| |
| | |
Problem: Quickfix code is repeated.
Solution: Define FOR_ALL_QFL_ITEMS(). Move some code to separate functions.
(Yegappan Lakshmanan, closes vim/vim#4166)
https://github.com/vim/vim/commit/a16123a666b4656543614cb5bdaa69ea69f35d30
|
| |
| |
| |
| |
| |
| |
| | |
Problem: Quickfix function arguments are inconsistent.
Solution: Pass a list pointer instead of info and index. (Yegappan
Lakshmanan, closes vim/vim#4135)
https://github.com/vim/vim/commit/0398e00a1bf79e85223fb26938c8dd0d54883b77
|
| |
| |
| |
| |
| |
| | |
Problem: Repeated code in quickfix support.
Solution: Move code to functions. (Yegappan Lakshmanan, closes vim/vim#4091)
https://github.com/vim/vim/commit/4aa47b28f453b40d3b93ef209a3447c62b6f855b
|
| |
| |
| |
| |
| |
| | |
Problem: Cannot distinguish between quickfix and location list.
Solution: Add an explicit type variable. (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/2d67d307ee5dba911e8fbe73193bf596ebf76c1a
|
| |
| |
| |
| |
| |
| |
| | |
Problem: Using freed memory in quickfix code. (Dominique Pelle)
Solution: Add the quickfix_busy() flag to postpone deleting quickfix lists
until it is safe. (Yegappan Lakshmanan, closes #3538)
https://github.com/vim/vim/commit/9f84ded38b62c82a4ee57b54f403b1b185ed8170
|
| |
| |
| |
| |
| |
| | |
Problem: Too often indexing in qf_lists[].
Solution: Use a qf_list_T pointer. (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/108e7b422b7b59153dd5af1fb75e83fa36ff3db4
|
| |
| |
| |
| |
| |
| |
| | |
Problem: Quickfix code mixes using the stack and a list pointer.
Solution: Use a list pointer in more places. (Yegappan Lakshmanan,
closes vim/vim#3443)
https://github.com/vim/vim/commit/fe15b7dfa628d4edd683dae9528194c0e5510128
|
| |
| |
| |
| |
| |
| | |
Problem: Quickfix functions are too long.
Solution: Refactor. (Yegappan Lakshmanan, closes vim/vim#2950)
https://github.com/vim/vim/commit/de3b3677f7eace66be454196db0fbf710cfc8c5e
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Problem: Quickfix window height wrong when there is a tabline. (Daniel
Hahler)
Solution: Take the tabline height into account. (closes vim/vim#5058)
https://github.com/vim/vim/commit/1142a31b8c44c4e7dbf28a83ae52995113b37917
|
|/
|
|
|
|
|
| |
Problem: ":copen 10" sets height in full-height window. (Daniel Hahler)
Solution: Don't set the height if the quickfix window is full height.
(closes vim/vim#4325)
https://github.com/vim/vim/commit/36d502225c3ec5e8b30771d58ee20171ce564b2f
|
|
|
|
|
|
|
| |
Problem: :cfile does not abort like other quickfix commands.
Solution: Abort when desired. Add tests for aborting. (Yegappan Lakshmanan,
closes vim/vim#5121)
https://github.com/vim/vim/commit/6a0cc916bd3cd6c2fd88b2972c92ade225603229
|
|
|
|
|
|
| |
Problem: Searchit() has too many arguments.
Solution: Move optional arguments to a struct. Add the "wrapped" argument.
https://github.com/vim/vim/commit/92ea26b925a0835badb0af2d5887238a4198cabb
|
|
|
|
|
| |
Problem: "%v" in 'errorformat' does handle multi-byte characters.
Solution: Handle multi-byte characters. (Yegappan Lakshmanan, closes vim/vim#3700)
https://github.com/vim/vim/commit/c45eb770a5988734ff2c572e5e2ce307158c33c8
|
|
|
|
|
|
| |
Problem: Checking for empty quickfix stack is not consistent.
Solution: Use qf_stack_empty(). (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/019dfe6855e011c02427bb922aafeae0245372c9
|
|
|
|
|
|
| |
Problem: The ex_make() function is too long.
Solution: Split it into several functions. (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/b434ae2a1fcbbd43244c6130451de7f14346e224
|
|
|
|
|
|
| |
Problem: copy_loclist() is too long.
Solution: Split in multiple functions. (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/09037503ea5f957ad23121bc61e15e4bb1765edf
|
|
|
|
|
|
| |
Problem: The ex_copen() function is too long.
Solution: Refactor to split off two functions. (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/476c0db00205590974395df717519407a7717270
|
|
|
|
|
|
|
| |
Problem: Cannot get the window id associated with the location list.
Solution: Add the "filewinid" argument to getloclist(). (Yegappan
Lakshmanan, closes vim/vim#3202)
https://github.com/vim/vim/commit/c9cc9c78f21caba7ecb5c90403df5e19a57aa96a
|
|
|
|
|
|
| |
Problem: Quickfix code uses cmdidx too often.
Solution: Add is_loclist_cmd(). (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/396659592fe039decc8c088694912067fe32a681
|
|
|
|
|
|
|
| |
Problem: qf_init_ext() is too long.
Solution: Split it into multiple functions. (Yegappan Lakshmanan,
closes vim/vim#2939)
https://github.com/vim/vim/commit/6053f2d29a979ffed1fe01b0a2f28e23750530e9
|
|
|
|
|
|
| |
Problem: The qf_add_entries() function is too long.
Solution: Split in two parts. (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/6f6ef7c1951b080843f3da049d3f5d0679de7348
|
|
|
|
|
|
| |
Problem: Helpgrep with language doesn't work properly. (Takuya Fujiwara)
Solution: Check for the language earlier. (Hirohito Higashi)
https://github.com/vim/vim/commit/c631f2df624954184509df49479d52ad7fe5233b
|
|
|
|
|
|
| |
Problem: Directly checking 'buftype' value.
Solution: Add the bt_normal() function. (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/91335e5a67aaa9937e65f1e779b9f3f10fd33ee4
|
| |
|
|
|
|
|
|
| |
Problem: efm_to_regpat() is too long.
Solution: Split off three functions. (Yegappan Lakshmanan, closes vim/vim#2924)
https://github.com/vim/vim/commit/6bff719f7e472e918c60aa336de03e799b806c4f
|
|
|
|
|
| |
Problem: ex_helpgrep() is too long.
Solution: Refactor the function. (Yegappan Lakshmanan, closes vim/vim#2766)
https://github.com/vim/vim/commit/2225ebb48644f3924311b8df02a1319ab7675d42
|
|
|
|
|
| |
Problem: The qf_jump_to_usable_window() function is too long.
Solution: Split it in parts. (Yegappan Lakshmanan, closes vim/vim#2891)
https://github.com/vim/vim/commit/7a2b0e55e9460493c4a949bda8be70950dbb8f85
|
|
|
|
|
|
| |
Problem: Cursor moves to wrong column after quickfix jump.
Solution: Set the curswant flag. (Andy Massimino, closes vim/vim#3331)
https://github.com/vim/vim/commit/2dfcef4c08a3371e2126504bea00b274f937a840
|
|
|
|
|
|
| |
Problem: No good check if restoring quickfix list worked.
Solution: Let qf_restore_list() return OK/FAIL. (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/90f1e2b7bcf56112e1535b693acf131727179a6e
|
|
|
|
|
|
| |
Problem: Coverity complains about a negative array index.
Solution: When qf_id2nr() cannot find the list then don't set qf_curlist.
https://github.com/vim/vim/commit/38efd1d17a6e6aa2add71efdf2cde4a788e5f5e5
|
|
|
|
|
|
| |
Problem: No test for fixed quickfix issue.
Solution: Add a test. Clean up the code a bit. (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/3f347e4716c44cf6458be407e712e3d708d82580
|
|
|
|
|
|
| |
Problem: duplicated quickfix code.
Solution: Move the code to a function.
https://github.com/vim/vim/commit/8d8a65e389cef318ae661ff0fe7b1b00fd7cb25f
|
|
|
|
|
|
| |
Problem: Quickfix: mixup of FALSE and FAIL, returning -1.
Solution: Use FAIL and INVALID_QFIDX. (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/29ce409bfca52bb8a07e2975d06fd788458e9861
|
| |
|
|
|
|
|
|
|
|
| |
Problem: Highlighting in quickfix window could be better. (Axel Bender)
Solution: Use the qfSeparator highlight item. (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/93a32e2ec4b5a391c5006ca09f196e6510c8c2e9
This adds `syn_name2attr` already (from previous patch 8.0.1123,
vim/vim@1b9645de3).
|
|
|
|
|
|
|
| |
Problem: Superfluous quickfix code, missing examples.
Solution: Remove unneeded code. Add a few examples. Add a bit more
testing. (Yegappan Lakshmanan, closes vim/vim#2916)
https://github.com/vim/vim/commit/78ddc06bdd5c59cffdbb61eed7dcb5dcc4a17f19
|
|
|
|
|
|
|
| |
Problem: qf_set_properties() is to long.
Solution: Refactor the function. Define INVALID_QFIDX. (Yegappan
Lakshmanan, closes vim/vim#2812)
https://github.com/vim/vim/commit/a2aa8a2b22de909619d7faa3ff5383a6224defc5
|
|
|
|
| |
ll_get_or_alloc_list() never fails because OOM is an abort condition.
|
|
|
|
|
|
| |
Problem: :cepxr no longer jumps to the first error.
Solution: Use the quickfix list identifier. (Yegappan Lakshmanan)
Fixes https://github.com/neovim/neovim/issues/10895
|
|
|
|
| |
Also revert possibly-wrong change in f_sign_getplaced() from
652be3cb0040.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Problem: Calling message_filtered() a bit too often.
Solution: Only call message_filtered() when filtering is already false.
https://github.com/vim/vim/commit/a9defadb8f03ecd03f3297305d5482ba380774dc
|