| Commit message (Collapse) | Author | Age |
| |
|
|
|
| |
* fixup: force exactly one whitespace between type and variable
|
| |
|
| |
|
|
|
|
|
| |
b_signcols_max isn't used to store the max value, it is use to
invalidate b_signcols.
|
|
|
|
| |
vim_strsave() returns nonnull.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows, `new_lnum + MAXLNUM` causes overflow and as a result the
line number of that sign becomes invalid negative number. This occurs
when the `set signcolumn=yes`, in other words `signcolumn` is not `auto`
and the sign column is less than 2 columns.
The related change was made in the commit
f2ed7605da45eb79a4f7bb89fb19f680fb5a4927. Originally the above addition
is only executed if `amount != MAXLNUM`, so reintroducing this check
fixes the bug and will hardly produces a new bug.
Fixes https://github.com/neovim/neovim/issues/14460
|
| |
|
|
|
|
| |
Problem: Sign entry structure has confusing name.
Solution: Rename signlist_T to sign_entry_T and prefix se_ to the fields.
|
|
|
|
|
|
| |
Problem: sign_place() does not work as documented.
Solution: Make accept line numbers like line(). (Yegappan Lakshmanan,
closes #4848)
|
|
|
|
|
|
|
|
| |
...signs is slow
Problem: Placing a larger number of signs is slow.
Solution: Add functions for dealing with a list of signs. (Yegappan
Lakshmanan, closes #4636)
|
|
|
|
|
|
|
|
| |
+ support for neovim's dynamic width signcolumn
Problem: Displaying signs is inefficient.
Solution: Avoid making multiple calls to get information about a placed
sign. (Yegappan Lakshmanan, closes #4586)
|
|
|
|
| |
Adds support for signs to be 0 cells wide. If all signs of the same
group have no width, the signcolumn will not be rendered for that group.
|
|
|
|
|
|
|
| |
Problem: Display wrong with signs in narrow number column.
Solution: Increase the numbercolumn width if needed. (Yegappan Lakshmanan,
closes vim/vim#4606)
https://github.com/vim/vim/commit/e4b407f536ba8bd007152649a347a95320d80fce
|
|
|
|
|
|
|
| |
Problem: When sign text is changed a manual redraw is needed. (Pontus
Lietzler)
Solution: Redraw automatically. (closes vim/vim#5455)
https://github.com/vim/vim/commit/bf0acff012c2f75563c20241f1a5478534fe2c7a
|
|
|
|
|
|
|
| |
Problem: No completion for sign group names.
Solution: Add completion for sign group names and buffer names. (Yegappan
Lakshmanan, closes vim/vim#3980)
https://github.com/vim/vim/commit/3678f65d43d10b36dc62738aab2f341fa1e18a32
|
|
|
|
|
|
|
| |
Problem: Cursor position is wrong after sign column appears or disappears.
(Yegappan Lakshmanan)
Solution: Call changed_line_abv_curs() instead of changed_cline_bef_curs().
https://github.com/vim/vim/commit/f85e40afc204c241c6a01023be3e7b8101d36367
|
|
|
|
|
|
|
| |
Problem: Sign order wrong when priority was changed.
Solution: Reorder signs when priority is changed. (Yegappan Lakshmanan,
closes vim/vim#4502)
https://github.com/vim/vim/commit/64416127fc184b5544530afe818722679158f059
|
|
|
|
|
|
| |
Problem: Not updating priority on existing sign.
Solution: Set the sign priority. Add a test. (Yegappan Lakshmanan)
https://github.com/vim/vim/commit/58a7f87c8653b4cb5b0794b6b88e2ec140d3d2c3
|
|
|
|
|
|
|
|
|
|
|
|
| |
Problem:
During a refactor long ago, we changed the `getdigits_*` familiy of
functions to abort on overflow. But this is often wrong, because many
of these codepaths are handling user input.
Solution:
Decide at each call-site whether to use "strict" mode.
fix #5555
|
|
|
|
| |
Functions marked with FUNC_ATTR_NONNULL_RET do not return NULL.
Remove redundant checks.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
buf_signcols sorting breaks signlist structure.
Remove sorting in buf_signcols, because signlist is already kept
sorted and it did not correctly update the double linked list.
Fixes #10078
|
| |
|
| |
|
| |
|
|
|
|
|
| |
This partly rolls back 36762a00a8010c5e14ad4347ab8287d1e8e7e064,
but it matches vim behaviour (covered with recent tests - oldtest).
|
| |
|
|
|
|
|
|
| |
Vim does not delete/free signs if they are placed on lines which get
deleted. In case of undo it does make a difference as in vim the sign
will be still available.
|
|
|
|
|
|
|
| |
Problem: The sign_define_by_name() function is too long.
Solution: Split it into smaller functions. (Yegappan Lakshmanan,
closes vim/vim#3819)
https://github.com/vim/vim/commit/0314236aabcb2ca9d0b74074dadecf68d7c7ed5f
|
|
|
|
|
|
|
| |
Problem: When deleting lines at the bottom signs are misplaced.
Solution: Properly update the line number of signs at the end of a buffer
after a delete/undo operation. (Yegappan Lakshmanan, closes vim/vim#3798)
https://github.com/vim/vim/commit/c771bf901622064dc27421b04853e16b6914a295
|
|
|
|
|
|
|
|
| |
Problem: When the last sign is deleted the signcolumn may not be removed
even though 'signcolumn' is "auto".
Solution: When deleting the last sign redraw the buffer. (Dominique Pelle,
closes vim/vim#3803, closes vim/vim#3804)
https://github.com/vim/vim/commit/8144acbec33b751788a7912e2d880c083c6cfe93
|
|
|
|
|
|
| |
Problem: There is no function for the ":sign jump" command.
Solution: Add the sign_jump() function. (Yegappan Lakshmanan, closes vim/vim#3780)
https://github.com/vim/vim/commit/6b7b7190aa9e5c4f51bceaebf9275aa5097cfea1
|
|
|
|
|
|
|
| |
Problem: Windows are updated for every added/deleted sign.
Solution: Do not call update_debug_sign(). Only redraw when the line with
the sign is visible. (idea from neovim vim/vim#9479)
https://github.com/vim/vim/commit/27a472c32ed5b5298bca50864570a4a71ec1d204
|
|
|
|
|
|
|
|
| |
Problem: ":sign place" only uses the current buffer.
Solution: List signs for all buffers when there is no buffer argument.
Fix error message for invalid buffer name in sign_place().
(Yegappan Lakshmanan, closes vim/vim#3774)
https://github.com/vim/vim/commit/b589f95b38ddd779d7e696abb0ea011dc92ea903
|
|
|
|
|
|
|
| |
Problem: Sign message not translated and inconsistent spacing.
Solution: Add _() for translation. Add a space. (Ken Takata) Also use
MSG_BUF_LEN instead of BUFSIZ.
https://github.com/vim/vim/commit/d730c8e2974609034016ca66db09d2ef78784343
|
|
|
|
|
|
|
| |
Problem: ":sign place" requires the buffer argument.
Solution: Make the argument optional. Also update the help and clean up the
sign test. (Yegappan Lakshmanan, closes vim/vim#3767)
https://github.com/vim/vim/commit/b328cca2548936c5f68fff683049a929882f5011
|
|
Problem: Functionality for signs is spread out over several files.
Solution: Move most of the sign functionality into sign.c. (Yegappan
Lakshmanan, closes vim/vim#3751)
https://github.com/vim/vim/commit/bbea47075cc4e7826e9f8c203e4272ba023ed7b0
|