| Commit message (Collapse) | Author | Age |
| |
|
|\ |
|
| |
| |
| |
| |
| |
| |
| | |
If swapfile dialog prompts for input, it must be displayed to the user.
fix #8840
fix #9027
|
| | |
|
|/
|
|
|
| |
Problem: printf() does not work with only one argument. (Daniel Hahler)
Solution: Allow using just the format. (Ken Takata, closes vim/vim#2687)
https://github.com/vim/vim/commit/c71807db9c1821baf86796cd76952df36ff1a29a
|
|
|
|
|
| |
Problem: :behave command is not tested.
Solution: Add a test. (Dominique Pelle, closes vim/vim#3429)
https://github.com/vim/vim/commit/da1f71d75f0bf5d5ef876a09aa08fb19f6f24b3b
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
Problem: Invalid memory access when setting wildchar empty.
Solution: Avoid going over the end of the option value. (Dominique Pelle,
closes vim/vim#1509) Make option test check all number options with
empty value.
https://github.com/vim/vim/commit/a12e40351d1357687e8b5dc3122fffef705bdc08
|
| |
| |
| |
| |
| |
| | |
Problem: Not all options are tested with a range of values.
Solution: Generate a test script from the source code.
https://github.com/vim/vim/commit/2f5463df014a406a2b780068e341ef30a99c9b98
|
| |
| |
| |
| |
| |
| |
| | |
Problem: v:option_old and v:option_new are cleared when using :set in
OptionSet autocmd. (Gary Johnson)
Solution: Don't trigger OptionSet recursively.
https://github.com/vim/vim/commit/3f3fb0b14734272e7c817020c847aaa0fba5cea5
|
|/ |
|
|\
| |
| | |
vim-patch:8.1.0310: file info msg with 'F' in 'shortmess'
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Problem: File info message not always suppressed with 'F' in 'shortmess'.
(Asheq Imran)
Solution: Save and restore msg_silent. (Christian Brabandt, closes vim/vim#3221)
https://github.com/vim/vim/commit/2f0f871159b2cba862fcd41edab65b17da75c422
ref #8840
ref #9027
|
| | |
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Resets the TUI cursor color if:
- current 'guicursor' mode does not specify a highlight group
- cursor highlight group has "inverse" or "reverse" flag
- on Nvim exit
We interpret, "inverse" to mean "default cursor".
Example:
hi Cursor guifg=bg guibg=fg
set termguicolors
set guicursor=n-v-c-sm:block,i-ci-ve:ver25-Cursor,r-cr-o:hor20
* When the cursor shape is block, its color will be "inverse"
* When the cursor shape is I-beam, its color will be `hi Cursor`.
This is useful e.g. to prevent `set listchars=eol:¬` causing your cursor
color to a low contrast color in insert mode because you cursor are
often at EOL in insert mode.
close #8572
|
|
|
|
|
| |
Problem: No test for synIDtrans().
Solution: Add a test. (Dominique Pelle, closes vim/vim#1796)
https://github.com/vim/vim/commit/0b2eef24bcbe2c85c90bbde914a1782cbedc5c72
|
|
|
|
|
|
|
|
| |
ref https://github.com/neovim/neovim/issues/9001#issuecomment-421843790
Steps to reproduce:
:set verbose=9
:call system(['echo'])
E730: using List as a String
|
|\ |
|
| | |
|
| |
| |
| |
| | |
Follow-up of vim-patch:8.0.1215
|
| |
| |
| |
| |
| |
| | |
Problem: Newer gcc warns for implicit fallthrough.
Solution: Consistently use a FALLTHROUGH comment. (Christian Brabandt)
https://github.com/vim/vim/commit/2f40d129bf45cd35976e4120336ae6d504f5a5dd
|
|/
|
|
|
|
|
|
|
| |
NB: existing `color default` test was actually enough to trigger the bug,
when ext_newgrid=false is used. I created the `:hi Normal` test as
I thought the builtin colors wouldn't set Normal (unless 'bg' is changed)
But as the root cause actually comes from `:hi Normal`, it makes sense
to still add the separate test (if `color default` here gets optimized to
become a no-op, or something).
|
|
|
|
|
|
|
|
| |
- Checks for ECHOE, ICANON were left over from Vim code. We already
reference the symbols elsewhere without checking.
- newline_on_exit, intr_char: Both are vestigial remnants of Vim 4.x,
not implemented in Nvim. intr_char is a termios/stty feature, it's
probably not useful because users have other ways to configure their
terminals.
|
| |
|
| |
|
|
|
|
|
|
| |
Give embeders a chance to set up nvim, by processing a request before
startup. This allows an external UI to show messages and prompts from
--cmd and buffer loading (e.g. swap files)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the TUI suspends (:suspend, CTRL-z) it calls tui_terminal_stop (but
does NOT set `ui->data=NULL`, so `tui_is_stopped` returns false). If the
host terminal dies, it sends SIGCONT, SIGHUP (usually in that order):
ERROR 2018-09-16T19:30:17.065 25821 suspend_event:1153: SIGCONT
ERROR 2018-09-16T19:30:17.065 25821 on_signal:162: SIGHUP
ERROR 2018-09-16T19:30:17.155 25821 on_signal:162: SIGHUP
Race: if SIGHUP is handled before SIGCONT, it calls ui_builtin_stop()
which schedules tui_stop before the TUI was resumed?
libuv uv_close() aborts if the handle is already closed/closing.
Somehow that causes macOS to panic. #8075
Assertion failed: (!uv__is_closing(handle)), function uv_close, file src/unix/core.c, line 117.
Thread 0:: Dispatch queue: com.apple.main-thread
0 libsystem_kernel.dylib 0x00007fff67d69ec2 kevent + 10
1 libuv.1.dylib 0x000000010609304d uv__io_poll + 892
2 libuv.1.dylib 0x0000000106083904 uv_run + 339
3 nvim 0x0000000105e76f7b loop_poll_events + 74
4 nvim 0x0000000105fa5f51 ui_bridge_stop + 206
5 nvim 0x0000000105fa4c00 ui_builtin_stop + 50
6 nvim 0x0000000105f26ee9 mch_exit + 29
7 nvim 0x0000000105eda84a getout + 518
8 nvim 0x0000000105e778b3 multiqueue_process_events + 77
9 nvim 0x0000000105f24c5a os_breakcheck + 49
10 nvim 0x0000000105eb7ea3 auto_next_pat + 463
11 nvim 0x0000000105eb7603 apply_autocmds_group + 1289
12 nvim 0x0000000105eb0e8d apply_autocmds + 36
13 nvim 0x0000000105f5a412 screenalloc + 1892
14 nvim 0x0000000105f5b223 screen_resize + 190
15 nvim 0x0000000105fa52e3 ui_refresh + 257
16 nvim 0x0000000105e8c3d9 do_cmdline + 6614
17 nvim 0x0000000105f03a72 normal_execute + 3996
18 nvim 0x0000000105f89925 state_enter + 164
19 nvim 0x0000000105efe08d normal_enter + 125
20 nvim 0x0000000105ed9ffd main + 6858
21 libdyld.dylib 0x00007fff67c19115 start + 1
Thread 1 Crashed:
0 libsystem_kernel.dylib 0x00007fff67d68e3e __pthread_kill + 10
1 libsystem_pthread.dylib 0x00007fff67ea7150 pthread_kill + 333
2 libsystem_c.dylib 0x00007fff67cc5312 abort + 127
3 libsystem_c.dylib 0x00007fff67c8d368 __assert_rtn + 320
4 libuv.1.dylib 0x00000001060835bf uv_close + 247
5 nvim 0x0000000105fa0ebb tui_terminal_stop + 221
6 nvim 0x0000000105f9ff3d tui_stop + 14
7 nvim 0x0000000105e778b3 multiqueue_process_events + 77
8 nvim 0x0000000105fa0c89 tui_main + 302
9 libsystem_pthread.dylib 0x00007fff67ea46c1 _pthread_body + 340
10 libsystem_pthread.dylib 0x00007fff67ea456d _pthread_start + 377
11 libsystem_pthread.dylib 0x00007fff67ea3c5d thread_start + 13
TODO:
- Set `ui->data = NULL` to flag UI as "stopped"? But loop_poll_events
drains *all* fast_events, so could skip some events...
|
|
|
|
|
|
| |
Problem: Compiler complains about uninitialized variable. (Tony Mechelynck)
Solution: Assign a value to the variable.
https://github.com/vim/vim/commit/059fd01021779ee369c1e55557275f6c349fda9e
|
|
|
|
|
|
| |
Problem: Compiler warning on 64 bit MS-Windows system.
Solution: Change type from "int" to "size_t". (Mike Williams)
https://github.com/vim/vim/commit/200ea8ffaa90e1ccc156b24ee097be87acdd5214
|
|\
| |
| | |
support "virtual text" annotations (currently after EOL only)
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
Problem: Test doesn't search for a sentence. Still fails when searching for
start of sentence. (Dominique Pelle)
Solution: Add paren. Check for MAXCOL in dec().
https://github.com/vim/vim/commit/1bd999f982e783219a06e6c8f219df1d53ac7e77
|
| |
| |
| |
| |
| |
| | |
Problem: Crash when searching for a sentence.
Solution: Return NUL when getting character at MAXCOL. (closes vim/vim#2468)
https://github.com/vim/vim/commit/8ada6aa9298b4764d9ca0024dd21b17e815595ce
|
| | |
|
|/
|
|
|
|
| |
Problem: CTRL-A does not work with an empty line. (Alex)
Solution: Decrement the end only once. (Hirohito Higashi, closes vim/vim#2387)
https://github.com/vim/vim/commit/5fe6bdf858a7f2f288d599ffb5efb3c08449c817
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
loop_schedule_deferred may leak its allocated Event if the Event does
not get processed (when Nvim exits).
It only happens on exit, so we tried to ignore it in .asan-blacklist,
but for that isn't working for unknown reasons.
= ==22007==ERROR: LeakSanitizer: detected memory leaks
= Direct leak of 88 byte(s) in 1 object(s) allocated from:
= 0 0x4ef7a3 in malloc /local/mnt/workspace/tmp/ubuntu_rel/llvm/utils/release/final/llvm.src/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:67:3
= 1 0xfcafc1 in try_malloc /home/travis/build/neovim/neovim/build/../src/nvim/memory.c:88:15
= 2 0xfcb1e9 in xmalloc /home/travis/build/neovim/neovim/build/../src/nvim/memory.c:122:15
= 3 0xa6e75f in loop_schedule_deferred /home/travis/build/neovim/neovim/build/../src/nvim/event/loop.c:91:19
= 4 0x18ab048 in tui_main /home/travis/build/neovim/neovim/build/../src/nvim/tui/tui.c:377:5
= 5 0x18fe120 in ui_thread_run /home/travis/build/neovim/neovim/build/../src/nvim/ui_bridge.c:102:3
= 6 0x7f09e5e58183 in start_thread /build/eglibc-ripdx6/eglibc-2.19/nptl/pthread_create.c:312
= SUMMARY: AddressSanitizer: 88 byte(s) leaked in 1 allocation(s).
|
|
|
|
|
| |
Problem: Incorrect adjusting the popup menu for the preview window.
Solution: Compute position and height properl. (Ronan Pigott) Also show at
least ten items. (closes vim/vim#3414)
|
|
|
|
|
|
|
| |
Problem: Recovering does not work when swap file ends in .stz.
Solution: Check for all possible swap file names. (Elfling, closes vim/vim#2395,
closes vim/vim#2396)
https://github.com/vim/vim/commit/af903e5d490ec9c6c49079f67de7e92e3c35a725
|
|\ |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Problem: CmdlineLeave autocmd prevents fold from opening. (Waivek)
Solution: Save and restore KeyTyped. (closes vim/vim#2305)
https://github.com/vim/vim/commit/c9e9c7140994154bb4a29764491d42c001b24596
|
| |
| |
| |
| |
| | |
Problem: "yL" is affected by 'scrolloff'. (Eli the Bearded)
Solution: Don't use 'scrolloff' when an operator is pending.
https://github.com/vim/vim/commit/44cc4cf72fdd12cd9a779031d443aac4254d51ae
|
| |
| |
| |
| |
| |
| | |
Problem: Marks test fails in very wide window. (Vladimir Lomov)
Solution: Extend the text to match 'columns'. (closes vim/vim#3180, closes vim/vim#3181)
https://github.com/vim/vim/commit/bde14d8e24f6b8ca409290733dbf11cb6fee5751
|
| |
| |
| |
| |
| |
| |
| | |
Problem: Output of :marks is too short with multi-byte chars. (Tony
Mechelynck)
Solution: Get more bytes from the text line.
https://github.com/vim/vim/commit/9d5185bf9dfaef59e47c573a60044a21d5e29c0c
|
|/
|
|
|
|
| |
Problem: The :marks command is not tested.
Solution: Add a test. (Dominique Pelle, closes vim/vim#2197)
https://github.com/vim/vim/commit/9b69f22e66d51d764e9ade87ae8a57ac13ab7348
|
| |
|
| |
|