aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
* job_start: Do not close in/out/err on error.Scott Prager2014-10-28
| | | | | | The streams job_close_*() reference have not been initialized by the time we call uv_spawn() and libuv closes these pipes for us when spawn() fails.
* job/valgrind: Fix invalid reads/missing free.Scott Prager2014-10-28
| | | | | | | | The JobEvent structure may refer to a job after it has been freed. Apply @tarruda's patch to extract the job data before pushing the event. Also, fix the type, "data" -> "job", in on_job_exit() and free the job name in the last job event.
* input: Fix conversion error in `convert_input()`Thiago de Arruda2014-10-28
| | | | | | | The `rbuffer_consumed` was being passed a consumed count from another buffer, causing integer overflow in `rbuffer_relocate`. Fixes #1343
* msgpack-rpc: Terminate server->client calls when the channel closesThiago de Arruda2014-10-28
|
* channel: fix `REQ` definition for msgpack-rpc loggingThiago de Arruda2014-10-28
|
* msgpack-rpc: Improve logging of msgpack-rpc messagesThiago de Arruda2014-10-23
| | | | | | | | | | - Expose more logging control from the log.c module(get log stream and omit newlines) - Remove logging from the generated functions in msgpack-gen.lua - Refactor channel.c/helpers.c to log every msgpack-rpc payload using msgpack_object_print(a helper function from msgpack.h) - Remove the api_stringify function, it was only useful for logging msgpack-rpc which is now handled by msgpack_object_print.
* job: Only decrease refcount after `settmode` in `job_wait`Thiago de Arruda2014-10-23
| | | | This is required to prevent the scenario explained by @akkartik in #1324
* job: Refactor to ensure that all callbacks will be invokedThiago de Arruda2014-10-23
| | | | | | | | | | | | | | It's possible that a child process won't close it's standard streams, even after it exits. This can be evidenced with the "xclip" program: :call system('xclip -i -selection clipboard', 'DATA') Before this commit, the above command wouldn't return, even though the xclip program had exited. That is because `xclip` wasn't closing it's stdout/stderr streams, which would block pending_refs from ever reaching 0. Now the job.c module was refactored to ensure all streams are closed when the uv_process_t handle is closed.
* msgpack-rpc: Fix error handling and leak in call_request_handlerThiago de Arruda2014-10-23
| | | | | Free the arguments array after sending the response and also avoid double-sending responses in cases of errors.
* msgpack-rpc: Ensure stdio channels are properly closedThiago de Arruda2014-10-23
| | | | | | When stdio was closed, parse_msgpack was called with eof == true, with caused a free_channel call. To ensure the correct behavior for all types of channels, the close_channel must be called before free_channel.
* Merge pull request #1332 from splinterofchaos/listbrJustin M. Keyes2014-10-23
|\ | | | | vim-patch:7.4.422
| * vim-patch:7.4.422Scott Prager2014-10-23
| | | | | | | | | | | | | | | | Problem: When using conceal with linebreak some text is not displayed correctly. (Grüner Gimpel) Solution: Check for conceal mode when using linebreak. (Christian Brabandt) https://code.google.com/p/vim/source/detail?r=v7-4-422
* | version: update patches to 488Scott Prager2014-10-23
| |
* | version: More NA patches.Scott Prager2014-10-23
| |
* | vim-patch:7.4.406Scott Prager2014-10-23
|/ | | | | | | Problem: Test 72 and 100 fail on MS-Windows. Solution: Set fileformat to unix in the tests. (Taro Muraoka) https://code.google.com/p/vim/source/detail?r=v7-4-406
* legacy tests: migrate test35. #1318Nate Sullivan2014-10-22
| | | | | Migrate vim's integration test 35 (increment/decrement commands) to lua/busted.
* debug: Improve debugging of msgpack-rpc requestsThiago de Arruda2014-10-22
| | | | | | - Add the api_stringify function to display API objects - Use api_stringify to display request arguments and return values in DLOG statements.
* debug: Fix broken DLOG macro callsThiago de Arruda2014-10-22
|
* input: Fix ctrl+c handling in convert_inputThiago de Arruda2014-10-22
|
* input: Don't remove Ctrl+C from the input_bufferThiago de Arruda2014-10-21
|
* event: Remove direct calls to `uv_run` from job.c/shell.cThiago de Arruda2014-10-21
|
* compilation: Add -Wconversion to more files and validate CONV_SOURCESThiago de Arruda2014-10-21
| | | | | | All files under the os, api and msgpack_rpc directories have -Wconversion automatically applied. CONV_SOURCES is also checked for missing files(when renaming, for example)
* api: Add FUNC_ATTR_DEFERRED attribute to a number of functionsThiago de Arruda2014-10-21
| | | | | Any function that can directly mutate the screen or execute vimscript had the attribute applied.
* msgpack-rpc: Allow selective deferral API callsThiago de Arruda2014-10-21
| | | | | | | | | | | | | Since all API functions now run immediately after a msgpack-rpc request is parsed by libuv callbacks, a mechanism was added to override this behavior and allow certain functions to run in Nvim main loop. The mechanism is simple: Any API function tagged with the FUNC_ATTR_DEFERRED (a "dummy" attribute only used by msgpack-gen.lua) will be called when Nvim main loop receives a K_EVENT key. To implement this mechanism it was necessary some restructuration on the msgpack-rpc modules, especially in the msgpack-gen.lua script.
* eval: Defer execution of JobActivity autocommandsThiago de Arruda2014-10-21
| | | | | | JobActivity autocommands run vimscript and must be executed on Nvim main loop. Since the previous commit removed automatic calls to `event_push` on RStream/Job callbacks, this adds it back, but in eval.c where job control is implemented.
* event: Extract event_poll loops to `event_poll_until` macroThiago de Arruda2014-10-21
| | | | | | | A pattern that is becoming common across the project is to poll for events until a certain condition is true, optionally passing a timeout. To address this scenario, the event_poll_until macro was created and the job/channel/input modules were refactored to use it on their blocking functions.
* event: Remove automatic event deferallThiago de Arruda2014-10-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is how asynchronous events are currently handled by Nvim: - Libuv event loop is entered when Nvim blocks for user input(os_inchar is called) - Any event delivered by libuv that is not user input is queued for processing - The `K_EVENT` special key code is returned by os_inchar - `K_EVENT` is returned to a loop that is reading keys for the current Nvim mode, which will be handled by calling event_process() This approach has the advantage of integrating nicely with the current codebase, eg: vimscript code can be executed asynchronously with little surprises(Its the same as if the user typed a key). The problem with using keys to represent any event is that it also interferes with operators, and not every event needs or should do that. For example, consider this scenario: - A msgpack-rpc client calls vim_feedkeys("d") - Nvim processes K_EVENT, pushing "d" to the input queue - Nvim processes "d", entering operator-pending mode to wait for a motion - The client calls vim_feedkeys("w"), expecting Nvim to delete a word - Nvim processes K_EVENT, breaking out of operator-pending and pushing "w" - Nvim processes "w", moving a word This commit fixes the above problem by removing all automatic calls to `event_push`(which is what generates K_EVENT input). Right now this also breaks redrawing initiated by asynchronous events(and possibly other stuff too, Nvim is a complex state machine and we can't simply run vimscript code anywhere). In future commits the calls to `event_push` will be inserted only where it's absolutely necessary to run code in "key reading loops", such as when executing vimscript code or mutating editor data structures in ways that currently can only be done by the user.
* event: Remove EventType enum and pass a callback to `event_push`Thiago de Arruda2014-10-21
| | | | | | This approach is more flexible because we don't need to support a fixed set of "event types", any module can push events to be handled in main loop by simply passing a callback to the Event structure.
* channel: Simplify resource managementThiago de Arruda2014-10-21
| | | | | | | | | - Remove unused rpc_call_level field - Add `returned` field to ChannelCallFrame. This is set when the call returns and is the only condition checked by `channel_send_call`. - Add job_exit callback for properly closing channels created from job(the job_exit callback is only called after all read callbacks, so it's the only safe place to free the channel).
* msgpack-rpc: Create subdirectory for msgpack-rpc modulesThiago de Arruda2014-10-21
| | | | | Create the msgpack_rpc subdirectory and move all modules that deal with msgpack-rpc to it. Also merge msgpack_rpc.c into msgpack_rpc/helpers.c
* Merge pull request #1311 from GokuITA/issue1295Justin M. Keyes2014-10-20
|\ | | | | Fixed sign column redraw
| * Fix sign column redrawVictor Fonseca2014-10-20
| | | | | | | | | | | | | | Fixed a bug introduced in SHA:aa66f2487edde49b9a5ba10cd70d706d06a94e25, due to a misapplied patch. buf_del_sign should redraw the window if the sign deleted was the last one in the buffer. Also moved the curwin verification to the correct function.
* | version: remove "Running in Vi compatible mode" message #1309Jeff Widman2014-10-20
|/
* rstream: Add rbuffer_read_ptr/rbuffer_write_ptr functionsThiago de Arruda2014-10-19
| | | | | | | | | rbuffer_data was renamed to rbuffer_read_ptr, and it represents the next read position in a RBuffer instance. Similarly, rbuffer_write_ptr was added to represent the next write position. Also, rbuffer_data was being used for writing(in alloc_cb), replace that by rbuffer_write_ptr.
* rstream: Initialize 'rstream' field in RBuffer classThiago de Arruda2014-10-19
| | | | | This field is used in a conditional jump, so this initialization is fixing a bug.
* ui: Refactor input buffer handlingThiago de Arruda2014-10-18
| | | | | All input buffer code was moved to os/input.c, and `inbuf` is now a `RBuffer` instance(which abstracts static buffer manipulation).
* rstream: Extract some RStream functionality to RBufferThiago de Arruda2014-10-18
| | | | | | | | RBuffer instances represent the internal buffer used by RStreams. This changes RStream constructor to receive RBuffer pointers and adds a set of RBuffer methods that expose the lower level buffer manipulation to consumers of the RStream API.
* Merge pull request #1297 from splinterofchaos/server-errorsJustin M. Keyes2014-10-17
|\ | | | | server: Improve error reporting.
| * server: Improve error reporting.Scott Prager2014-10-17
| | | | | | | | | | | | | | | | If we fail to bind to the server address, do not try and listen lest the reported error always be "invalid argument". Also, return whether or not we errored from server_init() in case we want to respond differently in the future.
* | vim-patch:7.4.418Scott Prager2014-10-16
|/ | | | | | | | Problem: When leaving ":append" the cursor shape is like in Insert mode. (Jacob Niehus) Solution: Do not have State set to INSERT when calling getline(). https://code.google.com/p/vim/source/detail?r=v7-4-418
* vim-patch:7.4.440 #1244Naveen Kumar Molleti2014-10-16
| | | | | | | | Problem: Omni complete popup drawn incorrectly. Solution: Call validate_cursor() instead of check_cursor(). (Hirohito Higashi) https://code.google.com/p/vim/source/detail?r=v7-4-440
* vim-patch:7.4.439 #1245Naveen Kumar Molleti2014-10-16
| | | | | | | | Problem: Duplicate message in message history. Some quickfix messages appear twice. (Gary Johnson) Solution: Do not reset keep_msg too early. (Hirohito Higashi) https://code.google.com/p/vim/source/detail?r=v7-4-439
* vim-patch:7.4.436 #1246Naveen Kumar Molleti2014-10-16
| | | | | | | | | Problem: ml_get error for autocommand that moves the cursor of the current window. Solution: Check the cursor position after switching back to the current buffer. (Christian Brabandt) https://code.google.com/p/vim/source/detail?r=v7-4-436
* Merge pull request #1265 from dkns/vp-7.4.444Justin M. Keyes2014-10-13
|\ | | | | vim-patch:7.4.444
| * vim-patch:7.4.444Daniel Kosinski2014-10-04
| | | | | | | | | | | | | | Problem: Reversed question mark not recognized as punctuation. ( Issue 258 ) Solution: Add the Supplemental Punctuation range. https://code.google.com/p/vim/source/detail?r=v7-4-444
* | vim-patch:7.4.408Scott Prager2014-10-10
| | | | | | | | | | | | | | Problem: Visual block insert breaks a multi-byte character. Solution: Calculate the position properly. (Yasuhiro Matsumoto) https://code.google.com/p/vim/source/detail?r=v7-4-408
* | vim-patch:7.4.397Scott Prager2014-10-09
| | | | | | | | | | | | | | | | Problem: Matchparen only uses the topmost syntax item. Solution: Go through the syntax stack to find items. (James McCoy) Also use getcurpos() when possible. https://code.google.com/p/vim/source/detail?r=v7-4-397
* | version: remove "Compilation" and "Linking" messages.Justin M. Keyes2014-10-07
| | | | | | | | | | | | Can't reliably get this information from cmake (#1267), so it's misleading to show these messages at all. We can always revert this commit if we find a way later.
* | version: generate "build number" from commit timestampJustin M. Keyes2014-10-07
| | | | | | | | | | | | | | | | | | | | - cmake: git_timestamp() returns last commit time formatted as `YYYYMMddHHmm`. - Always include commit hash in :version and --version output. `nvim --version` sample output: NVIM 0.0.0-alpha+201410070245 (compiled Oct 7 2014 05:30:45) Commit: f747b2b1ff7bfe7eb00cc2be82d7af87c98f1111
* | version: remove non-functional Vim version identifiersJustin M. Keyes2014-10-07
| |
generated by cgit (git 2.34.1) at 2025-05-31 00:38:05 +0000