aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAge
...
* | | PVS/V547: expression is always true/false #10640Ihor Antonov2019-07-29
| | | | | | | | | | | | Functions marked with FUNC_ATTR_NONNULL_RET do not return NULL. Remove redundant checks.
* | | PVS/V512: memcpy overflow/underflow #10642Ihor Antonov2019-07-28
|/ / | | | | | | | | problem: bfredl: pvs thinks the type of the pointed at item is too small. solution: refactored address calculation.
* | PVS/V560: condition is always false #10638Ihor Antonov2019-07-28
| | | | | | * shorten_buf_name: condition inside outer if-branch with inverse condition
* | vim-patch:8.0.1753: fix various warnings #10639Ihor Antonov2019-07-28
| | | | | | | | | | | | vim-patch:8.0.1753: various warnings from a static analyser Problem: Various warnings from a static analyser Solution: Remove unneeded conditions. https://github.com/vim/vim/commit/1c17ffa4611f4efe68c61f7cdd9ed692a866ba75
* | context: shada_encode_regs(): init WriteMergerState #10637Justin M. Keyes2019-07-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Check shada_pack_xx() result, abort on failure. - Use xcalloc() to zero-initialize `wms`, fixes below ASAN failure. ASAN failure (running vim_spec.lua in a loop): ../src/nvim/shada.c:1773:13: runtime error: load of value 224, which is not a valid value for type 'bool' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../src/nvim/shada.c:1773:13 Adding an explicit check just before the ASAN failed line: case kSDItemRegister: { if (*((int *)(void *)&entry.data.reg.is_unnamed) != 1 && *((int *)(void *)&entry.data.reg.is_unnamed) != 0) { abort(); (gdb) p entry.data.reg +p entry.data.reg $5 = {name = 49 '1', type = kMTLineWise, contents = 0x60200000c250, is_unnamed = true, contents_size = 1, width = 0, additional_data = 0x0} (gdb) p *((uint8_t *)(void *)&entry.data.reg.is_unnamed) +p *((uint8_t *)(void *)&entry.data.reg.is_unnamed) $7 = 2049
* | PVS/V560: expression is always false/true #10623Ihor Antonov2019-07-28
| |
* | src/clint.py: flake8 fixes [ci skip] (#10631)Daniel Hahler2019-07-28
| |
* | Merge #10628 from notomo/vim-8.1.1759Justin M. Keyes2019-07-28
|\ \
| * | Fix clint errornotomo2019-07-28
| | |
| * | vim-patch:8.1.1759: no mode char for terminal mapping from maparg()notomo2019-07-28
| | | | | | | | | | | | | | | | | | Problem: No mode char for terminal mapping from maparg(). Solution: Check for TERMINAL mode. (closes vim/vim#4735) https://github.com/vim/vim/commit/14371ed69778107654e39268d0d90982e53ad6e0
* | | PVS/V560: condition is always true #10630Ihor Antonov2019-07-28
| | | | | | | | | earlier condition leads to short-circuit of the loop
* | | PVS/V560: condition is always true #10624Ihor Antonov2019-07-28
| | | | | | | | | | | | | | | | | | | | | | | | * before changed line status variable is set to RA_FAIL in 2 places line 3816 and 3826, both lead to short-circuit of the loop, making comparing it to RA_FAIL useless close #10624
* | | pvs/V560: part of conditional expression is always true (#10629)Ihor Antonov2019-07-28
|/ / | | | | | | Since timed_out is pointer to int condition timed_out != NULL && timed_out makes no sense as both are effectively the same thing. Most likely the first check was meant to guard the dereference of the second. Wrong import of Vim patch (8.0.0643).
* | vim-patch:8.1.1748: :args output is not aligned (#10625)Daniel Hahler2019-07-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: :args output is not aligned. Solution: Output a line break after the last item in a row. https://github.com/vim/vim/commit/74da39373c90fcb390068903b5bbb93ce7ac16fa vim-patch:8.1.1750: depending on the terminal width :version may miss a line break Problem: Depending on the terminal width :version may miss a line break. Solution: Add a line break when needed. https://github.com/vim/vim/commit/8a5c29aee978345132ad7f318b8a84633c33905c vim-patch:8.1.1760: extra line break for wrapping output of :args Problem: Extra line break for wrapping output of :args. Solution: Avoid the extra line break. (Daniel Hahler, closes vim/vim#4737) https://github.com/vim/vim/commit/9800bfe0fc7596e8fee97172139f0777bac639fb
* | Merge #10619 'API: context'Justin M. Keyes2019-07-27
|\ \
| * | API: Context: save/restoreAbdelhakeem2019-07-27
| | |
| * | eval: context: add ctx-family functionsAbdelhakeem2019-07-27
| | |
| * | API: ContextJustin M. Keyes2019-07-27
| |/
* / vim-patch:8.1.0956: context:0 in 'diffopt' #10622Jan Edmund Lazo2019-07-27
|/ | | | | Problem: Using context:0 in 'diffopt' does not work well. Solution: Make zero context do the same as one line context. (closes vim/vim#4005) https://github.com/vim/vim/commit/b9ddda6c2d98d99c09d58145c1b5b4042a8fd92c
* tests: test_arglist.vim: align with Vim [ci skip] (#10612)Daniel Hahler2019-07-27
| | | This just moves the test to where it is in Vim.
* Merge #10606 'vim-patch:8.1.0404'Justin M. Keyes2019-07-27
|\
| * Revert "vim-patch:8.1.0430: Xargadd file left behind after running test"Jan Edmund Lazo2019-07-26
| | | | | | | | This reverts commit ce1b4f95fe684082cc9fb7e7e018e4f7c04338c4.
| * vim-patch:8.1.0404: accessing invalid memory with long argument nameJan Edmund Lazo2019-07-26
| | | | | | | | | | | | | | Problem: Accessing invalid memory with long argument name. Solution: Use item_count instead of checking for a terminating NULL. (Dominique Pelle, closes vim/vim#3444) https://github.com/vim/vim/commit/e961cba3cb8281c47f1dc2c2bc031b07504f17d4
* | vim-patch:8.1.1747: unused variables #10605Jan Edmund Lazo2019-07-26
| | | | | | | | | | Problem: Compiler warning for unused variables. (Tony Mechelynck) Solution: Add #ifdef. https://github.com/vim/vim/commit/fbfb757d4cb19e14853605f70ac663e42ec74663
* | cleanup: remove mch_fopen in favor of os_fopenJustin M. Keyes2019-07-25
| |
* | os/fs: introduce os_fopen()Justin M. Keyes2019-07-25
|/ | | | | | | Windows: Using fopen() directly may need UTF-16 filepath conversion. To achieve that, os_fopen() goes through os_open(). fix #10586
* PVS/V768: do use enum as bool #10582Ihor Antonov2019-07-25
| | | Fix win_draw_end invocation, pass HLF symbol explicitly.
* regexp: add function attributesJan Edmund Lazo2019-07-25
|
* vim-patch:8.1.0913: CI crashes when running out of memoryJan Edmund Lazo2019-07-25
| | | | | | Problem: CI crashes when running out of memory. Solution: Apply 'maxmempattern' also to new regexp engine. https://github.com/vim/vim/commit/688b3983d8b321e0d32dd51914fa474a0988daf6
* vim-patch:8.1.0910: crash with tricky search patternJan Edmund Lazo2019-07-25
| | | | | | Problem: Crash with tricky search pattern. (Kuang-che Wu) Solution: Check for runnning out of memory. (closes vim/vim#3950) https://github.com/vim/vim/commit/15bbd6ec871a0efdd16256e1fccbaac0fd374cbd
* vim-patch:8.1.0907: CI tests on AppVeyor are failingJan Edmund Lazo2019-07-25
| | | | | | Problem: CI tests on AppVeyor are failing. Solution: Reduce the recursiveness limit for regexp. https://github.com/vim/vim/commit/5382f12c910b7f8e46acdde5488f26a86f9fcac1
* vim-patch:8.1.0905: complicated regexp causes a crashJan Edmund Lazo2019-07-25
| | | | | | Problem: Complicated regexp causes a crash. (Kuang-che Wu) Solution: Limit the recursiveness of addstate(). (closes vim/vim#3941) https://github.com/vim/vim/commit/5567ad48b66dff13670af52a48509059acc34dfe
* regexp: use fixed types to avoid overflowJan Edmund Lazo2019-07-24
|
* Checks for overflow when parsing string to intGabriel2019-07-24
|
* vim-patch:8.1.0908: can't handle large value for %{nr}v in regexpJan Edmund Lazo2019-07-24
| | | | | | Problem: Can't handle large value for %{nr}v in regexp. (Kuang-che Wu) Solution: Give an error if the value is too large. (closes vim/vim#3948) https://github.com/vim/vim/commit/9403a2168db82b7de80f792984084bb3f00e2263
* vim-patch:8.1.1746: ":dl" is seen as ":dlist" instead of ":delete"Jan Edmund Lazo2019-07-24
| | | | | | Problem: ":dl" is seen as ":dlist" instead of ":delete". Solution: Do not use cmdidxs2[] if the length is 1. (closes vim/vim#4721) https://github.com/vim/vim/commit/94f82cbacf76767b5ac32f813e1d670501dbd0e6
* vim-patch:8.1.0903: struct uses more bytes than neededJan Edmund Lazo2019-07-24
| | | | | | Problem: Struct uses more bytes than needed. Solution: Reorder members of regitem_S. (Dominique Pelle, closes vim/vim#3936) https://github.com/vim/vim/commit/beb7574d6b0eea1cae70aa2913a690da56de5307
* vim-patch:8.1.0899: no need to check restricted mode for setwinvar()Jan Edmund Lazo2019-07-24
| | | | | | Problem: No need to check restricted mode for setwinvar(). Solution: Remove check_restricted(). https://github.com/vim/vim/commit/e0fb7d1e38e1cf699412e212cda863420f5f8bd2
* vim-patch:8.1.1740: exepath() doesn't work for "bin/cat" (#10556)Daniel Hahler2019-07-24
| | | | | | | | Problem: Exepath() doesn't work for "bin/cat". Solution: Check for any path separator. (Daniel Hahler, closes vim/vim#4724, closes vim/vim#4710) https://github.com/vim/vim/commit/d08b8c4c04db9433340df38d21f0e26878f28421 Fixes https://github.com/neovim/neovim/issues/10554.
* vim-patch:8.1.1738: testing lambda with timer is slow (#10590)Daniel Hahler2019-07-24
| | | | | | Problem: Testing lambda with timer is slow. Solution: Do not test timer accuracy, only that it works. (Daniel Hahler, closes vim/vim#4723) https://github.com/vim/vim/commit/9bc4dde45d45df732953491d0f2c3fd3b10a627e
* sign: REMOVE FEAT_SIGN_ICONS, dead code #10595Jan Edmund Lazo2019-07-24
|
* vim-patch:8.1.1737: :args command that outputs one line gives more promptDaniel Hahler2019-07-24
| | | | | | | | Problem: :args command that outputs one line gives more prompt. Solution: Only output line break if needed. (Daniel Hahler, closes vim/vim#4715) https://github.com/vim/vim/commit/949f1989cba8bf7653316c2b1444c26f1536bfab Closes https://github.com/neovim/neovim/pull/10147.
* vim-patch:8.0.1738: ":args" output is hard to readDaniel Hahler2019-07-24
| | | | | | | | | | | | | | | Problem: ":args" output is hard to read. Solution: Make columns with the names if the output is more than one line. https://github.com/vim/vim/commit/5d69da462f584a3aefb3427b127334bf9af3a4b0 vim-patch:8.0.1740: warning for signed-unsigned incompatibility Problem: Warning for signed-unsigned incompatibility. Solution: Change type from "char *" to "char_u *". (John Marriott) https://github.com/vim/vim/commit/405dadb63ea2b7aa4c8c659807506a35a8a9504c Removes ported legacy test that was re-added later. Ref: https://github.com/neovim/neovim/pull/10147#issuecomment-512609513
* env: invalid pointer after os_setenv() #10558erw72019-07-23
|
* win/TUI: workaround libuv LF => CRLF conversion #10558erw72019-07-23
| | | | | | Replace cud1 with \x1b[B because \n is CRLF on Windows (due to libuv). fix #9461
* Revert "vim-patch:8.0.1723: using one item array size declaration is ↵Jan Edmund Lazo2019-07-23
| | | | | misleading" (#10583) This reverts commit 315076a26d225a3bdc34a2cbba1f124adf4e1087.
* PVS/V1019: "readability" warning #10566Ihor Antonov2019-07-22
|
* build: fix gcc warnings #10568ddcien2019-07-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gcc version 8.3.0 (Debian 8.3.0-6) ../src/nvim/ex_docmd.c: In function ‘commands_array’: ../src/nvim/ex_docmd.c:10192:36: warning: ‘%ld’ directive output may be truncated writing between 1 and 19 bytes into a region of size 10 [-Wformat-truncation=] snprintf(str, sizeof(str), "%" PRId64, (int64_t)cmd->uc_def); ^~~ ../src/nvim/ex_docmd.c:10192:37: note: format string is defined here snprintf(str, sizeof(str), "%" PRId64, (int64_t)cmd->uc_def); ../src/nvim/ex_docmd.c:10192:36: note: directive argument in the range [0, 9223372036854775807] snprintf(str, sizeof(str), "%" PRId64, (int64_t)cmd->uc_def); ^~~ ../src/nvim/ex_docmd.c:10192:9: note: ‘snprintf’ output between 2 and 20 bytes into a destination of size 10 snprintf(str, sizeof(str), "%" PRId64, (int64_t)cmd->uc_def); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/nvim/ex_docmd.c:10205:36: warning: ‘%ld’ directive output may be truncated writing between 1 and 19 bytes into a region of size 10 [-Wformat-truncation=] snprintf(str, sizeof(str), "%" PRId64, (int64_t)cmd->uc_def); ^~~ ../src/nvim/ex_docmd.c:10205:37: note: format string is defined here snprintf(str, sizeof(str), "%" PRId64, (int64_t)cmd->uc_def); ../src/nvim/ex_docmd.c:10205:36: note: directive argument in the range [0, 9223372036854775807] snprintf(str, sizeof(str), "%" PRId64, (int64_t)cmd->uc_def); ^~~ ../src/nvim/ex_docmd.c:10205:9: note: ‘snprintf’ output between 2 and 20 bytes into a destination of size 10 snprintf(str, sizeof(str), "%" PRId64, (int64_t)cmd->uc_def); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/nvim/spell.c: In function ‘did_set_spelllang’: ../src/nvim/spell.c:1631:61: warning: ‘%s’ directive output may be truncated writing up to 254 bytes into a region of size 84 [-Wformat-truncation=] "autocmd VimEnter * call spellfile#LoadFile('%s')|set spell", ^~ ../src/nvim/spell.c:2063:25: spell_load_lang(lang); ~~~~ ../src/nvim/spell.c:1630:7: note: ‘snprintf’ output between 57 and 311 bytes into a destination of size 128 snprintf(autocmd_buf, sizeof(autocmd_buf), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ "autocmd VimEnter * call spellfile#LoadFile('%s')|set spell", ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lang); ~~~~~ ../src/nvim/window.c: In function ‘win_rotate’: ../src/nvim/window.c:1780:22: warning: ‘wp2’ may be used uninitialized in this function [-Wmaybe-uninitialized] wp2->w_pos_changed = true; ^ ../src/nvim/window.c:1779:22: warning: ‘wp1’ may be used uninitialized in this function [-Wmaybe-uninitialized] wp1->w_pos_changed = true;
* vim-patch:8.1.0706: introduce :redrawtabline #10570Jan Edmund Lazo2019-07-22
| | | | | | | Problem: Tabline is not always redrawn when something that is used in 'tabline' changes. Solution: Add ":redrawtabline" so that a plugin can at least cause the redraw when needed. https://github.com/vim/vim/commit/e12bab3144af8943937bd0ff4bc57f04e53037b3
* vim-patch:8.1.1724: too much overhead checking for CTRL-C #10564Jan Edmund Lazo2019-07-21
| | | | | | Problem: Too much overhead checking for CTRL-C while processing text. Solution: Increase BREAKCHECK_SKIP. Remove the difference for when built with the GUI. (suggested by Andy Massimino, closes vim/vim#4708) https://github.com/vim/vim/commit/b4fe0eb4b4fe52a68a1df05162c03fe51c2fce79