From ea10e0c104897528a20bb1d9618e2b941eed1b3a Mon Sep 17 00:00:00 2001 From: Gregory Anders <8965202+gpanders@users.noreply.github.com> Date: Sat, 3 Sep 2022 21:49:45 -0600 Subject: ci: remove gpanders from api reviewers (#20074) --- .github/scripts/reviews.js | 1 - 1 file changed, 1 deletion(-) (limited to '.github/scripts') diff --git a/.github/scripts/reviews.js b/.github/scripts/reviews.js index 6e9a829353..0f14707179 100644 --- a/.github/scripts/reviews.js +++ b/.github/scripts/reviews.js @@ -9,7 +9,6 @@ module.exports = async ({github, context}) => { const reviewers = new Set() if (labels.includes('api')) { reviewers.add("bfredl") - reviewers.add("gpanders") reviewers.add("muniter") } -- cgit From 82d93429e78b661027c05f3fbc862aa0e0c6cd95 Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Sat, 10 Sep 2022 11:08:46 +0200 Subject: ci: add more reviewers based on label (#17975) --- .github/scripts/reviews.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to '.github/scripts') diff --git a/.github/scripts/reviews.js b/.github/scripts/reviews.js index 0f14707179..c76f25b7da 100644 --- a/.github/scripts/reviews.js +++ b/.github/scripts/reviews.js @@ -14,9 +14,11 @@ module.exports = async ({github, context}) => { if (labels.includes('build')) { reviewers.add("jamessan") + reviewers.add("justinmk") } if (labels.includes('ci')) { + reviewers.add("dundargoc") reviewers.add("jamessan") } @@ -53,17 +55,14 @@ module.exports = async ({github, context}) => { reviewers.add("gpanders") } - if (labels.includes('gui')) { - reviewers.add("glacambre") - reviewers.add("smolck") - } - if (labels.includes('lsp')) { reviewers.add("mfussenegger") + reviewers.add("glepnir") } if (labels.includes('treesitter')) { reviewers.add("bfredl") + reviewers.add("clason") reviewers.add("vigoux") } -- cgit From 72b2353ab2f01ea96d7526c19f05571688d81e13 Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Tue, 18 Oct 2022 11:13:58 +0200 Subject: ci: add reviewers based on labels (#20703) --- .github/scripts/reviews.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to '.github/scripts') diff --git a/.github/scripts/reviews.js b/.github/scripts/reviews.js index c76f25b7da..c1318edec0 100644 --- a/.github/scripts/reviews.js +++ b/.github/scripts/reviews.js @@ -53,11 +53,12 @@ module.exports = async ({github, context}) => { if (labels.includes('filetype')) { reviewers.add("clason") reviewers.add("gpanders") + reviewers.add("smjonas") } if (labels.includes('lsp')) { - reviewers.add("mfussenegger") reviewers.add("glepnir") + reviewers.add("mfussenegger") } if (labels.includes('treesitter')) { -- cgit From ef5ab2bf76a8037c3ca87c08d4083e03686fd7a1 Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Wed, 30 Nov 2022 14:19:11 +0100 Subject: ci: add more reviewers based on label (#21155) --- .github/scripts/reviews.js | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) (limited to '.github/scripts') diff --git a/.github/scripts/reviews.js b/.github/scripts/reviews.js index c1318edec0..a31c94eebd 100644 --- a/.github/scripts/reviews.js +++ b/.github/scripts/reviews.js @@ -20,12 +20,17 @@ module.exports = async ({github, context}) => { if (labels.includes('ci')) { reviewers.add("dundargoc") reviewers.add("jamessan") + reviewers.add("justinmk") } if (labels.includes('column')) { reviewers.add("lewis6991") } + if (labels.includes('dependencies')) { + reviewers.add("jamessan") + } + if (labels.includes('diagnostic')) { reviewers.add("gpanders") } @@ -34,10 +39,6 @@ module.exports = async ({github, context}) => { reviewers.add("lewis6991") } - if (labels.includes('dependencies')) { - reviewers.add("jamessan") - } - if (labels.includes('distribution')) { reviewers.add("jamessan") } @@ -61,6 +62,19 @@ module.exports = async ({github, context}) => { reviewers.add("mfussenegger") } + if (labels.includes('project-management')) { + reviewers.add("bfredl") + reviewers.add("justinmk") + } + + if (labels.includes('refactor')) { + reviewers.add("bfredl") + } + + if (labels.includes('test')) { + reviewers.add("justinmk") + } + if (labels.includes('treesitter')) { reviewers.add("bfredl") reviewers.add("clason") -- cgit From 5c52971f603d35aa689022eb0a0bc670ab6788e6 Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Mon, 5 Dec 2022 11:58:13 +0100 Subject: ci: use shell script to deduplicate workflow (#21079) --- .github/scripts/install_deps_ubuntu.sh | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100755 .github/scripts/install_deps_ubuntu.sh (limited to '.github/scripts') diff --git a/.github/scripts/install_deps_ubuntu.sh b/.github/scripts/install_deps_ubuntu.sh new file mode 100755 index 0000000000..012409ba4a --- /dev/null +++ b/.github/scripts/install_deps_ubuntu.sh @@ -0,0 +1,19 @@ +#!/bin/bash + +PACKAGES=( + autoconf + automake + build-essential + cmake + cpanminus + curl + gettext + libtool-bin + locales-all + ninja-build + pkg-config + unzip +) + +sudo apt-get update +sudo apt-get install -y "${PACKAGES[@]}" -- cgit From ef95174694d705e921ee0271d62badd45f00deaa Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Thu, 15 Dec 2022 20:40:30 +0100 Subject: ci: add team reviewers (#21434) Using team reviewers when possible reduces the churn on the git history as we'll be able to add or remove reviewers without needing to change the workflow files. This requires using Github fine-grained personal access tokens with Pull Requests set to "Read and write" and Members to "Read-only". --- .github/scripts/remove-reviewers.js | 4 +++- .github/scripts/reviews.js | 15 ++++++--------- 2 files changed, 9 insertions(+), 10 deletions(-) (limited to '.github/scripts') diff --git a/.github/scripts/remove-reviewers.js b/.github/scripts/remove-reviewers.js index 631f08e57d..40a8eca423 100644 --- a/.github/scripts/remove-reviewers.js +++ b/.github/scripts/remove-reviewers.js @@ -6,11 +6,13 @@ module.exports = async ({github, context}) => { }); const reviewers = requestedReviewers.data.users.map(e => e.login) + const team_reviewers = requestedReviewers.data.teams.map(e => e.name); github.rest.pulls.removeRequestedReviewers({ owner: context.repo.owner, repo: context.repo.repo, pull_number: context.issue.number, - reviewers: reviewers + reviewers: reviewers, + team_reviewers: team_reviewers }); } diff --git a/.github/scripts/reviews.js b/.github/scripts/reviews.js index a31c94eebd..ab81a61047 100644 --- a/.github/scripts/reviews.js +++ b/.github/scripts/reviews.js @@ -7,6 +7,7 @@ module.exports = async ({github, context}) => { const labels = pr_data.data.labels.map(e => e.name) const reviewers = new Set() + const team_reviewers = new Array() if (labels.includes('api')) { reviewers.add("bfredl") reviewers.add("muniter") @@ -18,9 +19,7 @@ module.exports = async ({github, context}) => { } if (labels.includes('ci')) { - reviewers.add("dundargoc") - reviewers.add("jamessan") - reviewers.add("justinmk") + team_reviewers.push('ci'); } if (labels.includes('column')) { @@ -58,8 +57,7 @@ module.exports = async ({github, context}) => { } if (labels.includes('lsp')) { - reviewers.add("glepnir") - reviewers.add("mfussenegger") + team_reviewers.push('lsp'); } if (labels.includes('project-management')) { @@ -76,9 +74,7 @@ module.exports = async ({github, context}) => { } if (labels.includes('treesitter')) { - reviewers.add("bfredl") - reviewers.add("clason") - reviewers.add("vigoux") + team_reviewers.push('treesitter'); } if (labels.includes('typo')) { @@ -102,6 +98,7 @@ module.exports = async ({github, context}) => { owner: context.repo.owner, repo: context.repo.repo, pull_number: context.issue.number, - reviewers: Array.from(reviewers) + reviewers: Array.from(reviewers), + team_reviewers: team_reviewers }); } -- cgit From 788eb654941efe1f725143d7e1bc9b5236ecbb37 Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Fri, 23 Dec 2022 12:54:30 +0100 Subject: ci: remove needs:response label if author responds (#21489) ci: remove "needs:response" label if author responds The default behavior of the stale action is to indiscriminately remove the `needs:response` label for any activity whatsoever, from anyone. The other option is to turn it off completely, meaning the maintainers needs to manually remove the label themselves when the author responds for an issue to not close automatically. Neither of these behaviors are useful to us. --- .github/scripts/unstale.js | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 .github/scripts/unstale.js (limited to '.github/scripts') diff --git a/.github/scripts/unstale.js b/.github/scripts/unstale.js new file mode 100644 index 0000000000..f645fca5cb --- /dev/null +++ b/.github/scripts/unstale.js @@ -0,0 +1,19 @@ +module.exports = async ({ github, context }) => { + const commenter = context.actor; + const issue = await github.rest.issues.get({ + owner: context.repo.owner, + repo: context.repo.repo, + issue_number: context.issue.number, + }); + const author = issue.data.user.login; + const labels = issue.data.labels.map((e) => e.name); + + if (author === commenter && labels.includes("needs:response")) { + github.rest.issues.removeLabel({ + owner: context.repo.owner, + repo: context.repo.repo, + issue_number: context.issue.number, + name: "needs:response", + }); + } +}; -- cgit From ab11157808955c40880cc0efb05d2aa5a21c897a Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Wed, 28 Dec 2022 15:19:23 +0100 Subject: ci: add platform:nix label when changing nix files (#21569) Also update the reviewer list. --- .github/scripts/reviews.js | 4 ++++ 1 file changed, 4 insertions(+) (limited to '.github/scripts') diff --git a/.github/scripts/reviews.js b/.github/scripts/reviews.js index ab81a61047..cc6aaa1e8b 100644 --- a/.github/scripts/reviews.js +++ b/.github/scripts/reviews.js @@ -60,6 +60,10 @@ module.exports = async ({github, context}) => { team_reviewers.push('lsp'); } + if (labels.includes('platform:nix')) { + reviewers.add("teto") + } + if (labels.includes('project-management')) { reviewers.add("bfredl") reviewers.add("justinmk") -- cgit